From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90510 invoked by alias); 14 Oct 2015 22:02:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 90483 invoked by uid 89); 14 Oct 2015 22:02:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 14 Oct 2015 22:02:17 +0000 Received: by obbrx8 with SMTP id rx8so50808187obb.3 for ; Wed, 14 Oct 2015 15:02:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=bs1pd23Ddr+PTwEjum0+PHO9z6uy4bW/rLm7Dciz+LM=; b=R7fXxLmSz29mWlsBJGr8We96nXGAjsSJNx4VVBxPLzaDGKRe0M1TTMZjnYsyVJfSra zlfuJ48TsDlfRvd989yQP3ffYnlLIWAy62u1qZEJjdFaHfbiR8dZL6RAKDanMYiAYf4A n0Tl6nISLz2LcjB91g5BDBst4s9fP0d6EYoKq74XVYsPxlLPYUVo9i1hpB+EIVtFYkTF W3PtJPmFKQh4GgjafZb/jX0PJzNVpJalew9nGsG/A8yaE1ps9VvOSAz38nAF2zYijp4t ClSISrUmq7zLpOM/TNZbm4lWW2Zm/rgcmsnWE0FkPvwGu6XlXBYT2zcq3M5/kiuJO3Lg UmBw== X-Gm-Message-State: ALoCoQn9BSMJJJo6XXgx+AI2w6ZzeHLJGI4KuD5s5U4r9WJ8rOIOrlMNmuaGQVQ3yemrhs7ImCAG MIME-Version: 1.0 X-Received: by 10.60.42.105 with SMTP id n9mr3472613oel.1.1444860135222; Wed, 14 Oct 2015 15:02:15 -0700 (PDT) Received: by 10.202.60.195 with HTTP; Wed, 14 Oct 2015 15:02:15 -0700 (PDT) In-Reply-To: <561B9242.1060506@arm.com> References: <1444175989-24944-1-git-send-email-charles.baylis@linaro.org> <1444175989-24944-2-git-send-email-charles.baylis@linaro.org> <561B9242.1060506@arm.com> Date: Wed, 14 Oct 2015 22:02:00 -0000 Message-ID: Subject: Re: [PATCH 1/3] [ARM] PR63870 Add qualifiers for NEON builtins From: Charles Baylis To: Alan Lawrence Cc: Kyrylo Tkachov , Ramana Radhakrishnan , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg01428.txt.bz2 On 12 October 2015 at 11:58, Alan Lawrence wrote: > On 07/10/15 00:59, charles.baylis@linaro.org wrote: >> >> diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c > > ... >> >> case NEON_ARG_MEMORY: >> /* Check if expand failed. */ >> if (op[argc] == const0_rtx) >> { >> - va_end (ap); >> return 0; >> } > > > ...and drop the braces? Will do. >> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c >> index 02f5dc3..448cde3 100644 >> --- a/gcc/config/arm/arm.c >> +++ b/gcc/config/arm/arm.c >> @@ -30117,4 +30117,5 @@ arm_sched_fusion_priority (rtx_insn *insn, int >> max_pri, >> *pri = tmp; >> return; >> } >> + >> #include "gt-arm.h" > > > This looks unrelated (and is the only change to arm.c) - perhaps commit > separately? (Note I am not a maintainer! But this looks "obvious"...) It doesn't seem very useful. I'll drop it. >> diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h >> index 87c9f90..27ac4dc 100644 >> --- a/gcc/config/arm/arm.h >> +++ b/gcc/config/arm/arm.h >> @@ -288,6 +288,9 @@ extern void >> (*arm_lang_output_object_attributes_hook)(void); >> #define TARGET_BPABI false >> #endif >> >> +#define ENDIAN_LANE_N(mode, n) \ >> + (BYTES_BIG_ENDIAN ? GET_MODE_NUNITS (mode) - 1 - n : n) >> + > > > Given we are making changes here to how this all works on bigendian, have > you tested armeb at all? I tested on big endian, and it passes, except for a testsuite issue with the *_f16 tests, which fail because they are built without the fp16 options on big endian. This is because check_effective_target_arm_neon_fp16_ok_nocache gets an ICE when it attempts to compile the test program. I think those fp16 intrinsics are in your area, do you want to take a look? :) Thanks for the review Charles