From: Jason Merrill <jason@redhat.com>
To: Jeff Law <law@redhat.com>
Cc: Marek Polacek <polacek@redhat.com>,
Jakub Jelinek <jakub@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: Split c-common.c?
Date: Tue, 27 Sep 2016 15:10:00 -0000 [thread overview]
Message-ID: <CADzB+2=0XX+tO6ddwEqV4ibc9e6tQO5eRbRrLe6+XoP7LhqwjA@mail.gmail.com> (raw)
In-Reply-To: <5e3f3b20-c3a8-6a36-51a4-efc0c2ff3e14@redhat.com>
Sure.
On Mon, Sep 26, 2016 at 10:57 AM, Jeff Law <law@redhat.com> wrote:
> On 09/26/2016 07:38 AM, Marek Polacek wrote:
>>
>> On Mon, Sep 26, 2016 at 03:26:28PM +0200, Jakub Jelinek wrote:
>>>
>>> On Mon, Sep 26, 2016 at 03:22:08PM +0200, Marek Polacek wrote:
>>>>
>>>> Before I spend time on this, I wanted to check if you consider this a
>>>> good
>>>> idea. Since c-common.c has grown a lot and is quite large now, I think
>>>> we
>>>> might split it into c-warn.c, where various warning routines would go.
>>>> What do
>>>> you think?
>>>
>>>
>>> Perhaps c-attribs.c for the attribute handling stuff too?
>>
>>
>> Yeah. The way I envision c-common.c is to contain shared c-family
>> routines
>> such as c_common_type_for_*, c_save_expr, max_align_t_align, and similar,
>> but
>> the warnings/diagnostics might use their own file.
>
> Works for me.
>
> jeff
next prev parent reply other threads:[~2016-09-27 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 13:34 Marek Polacek
2016-09-26 13:38 ` Jakub Jelinek
2016-09-26 13:42 ` Marek Polacek
2016-09-26 15:15 ` Jeff Law
2016-09-27 15:10 ` Jason Merrill [this message]
2016-09-27 23:10 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2=0XX+tO6ddwEqV4ibc9e6tQO5eRbRrLe6+XoP7LhqwjA@mail.gmail.com' \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).