From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59103 invoked by alias); 12 Sep 2016 20:58:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59074 invoked by uid 89); 12 Sep 2016 20:58:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.4 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=942b, 54C7, 44D5, 54c7 X-HELO: mail-it0-f41.google.com Received: from mail-it0-f41.google.com (HELO mail-it0-f41.google.com) (209.85.214.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Sep 2016 20:57:53 +0000 Received: by mail-it0-f41.google.com with SMTP id n143so24150945ita.1 for ; Mon, 12 Sep 2016 13:57:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ez/03NscadXsz26R4O9r/0GRXHFvOOIM7ehUPu4a6v8=; b=M+sIdte1hvOK08aGIDAZupBcKlP7IXCW/QXRcxvv86lERA7QNnTYQeqfHUxlm0LE/s jRTPouzOawOKpgge3xsl6jYJ1Ul2M86p4nieGkQB0n/Kg2fVPh7yVqGnilQW79GqiaJr 5w8kOV+bQ+Xu8Imb9sgUu/a0sfXXjkUcRTzIrcG6UuNxIWxG8U1hsEhLj7cC9EWr8XFQ HOF1O3FZJiG4ExfWDUNzsrAWoeuUw3ySR3iTPIdgToKICFBMZ+Qp1ci8CqQgq9fj4Sbj 2xVxMAX4Rrmgji3P8Ihs8HtWhN8ruDT+ItLFPXtdDStahVHligpsbDrQKPW12SJB+U+j bEJg== X-Gm-Message-State: AE9vXwMn/vp3EfMg+sA7of5VPmpGK7rTtKeQ8kg1swNvfP+UExwcEaj+LTnO6b0qdBQjBRtXjAy4QC067L+3MTk3 X-Received: by 10.157.50.203 with SMTP id u69mr25057324otb.157.1473713871344; Mon, 12 Sep 2016 13:57:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.105.169 with HTTP; Mon, 12 Sep 2016 13:57:30 -0700 (PDT) In-Reply-To: <87oa3vwrkf.fsf@linux-m68k.org> References: <20160908110641.GB23306@redhat.com> <87oa3vwrkf.fsf@linux-m68k.org> From: Jason Merrill Date: Mon, 12 Sep 2016 21:13:00 -0000 Message-ID: Subject: Re: RFA (libstdc++): PATCH to implement C++17 over-aligned new To: Andreas Schwab Cc: Jonathan Wakely , libstdc++@gcc.gnu.org, gcc-patches List Content-Type: multipart/mixed; boundary=001a11494904cd8eaa053c55bf03 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00672.txt.bz2 --001a11494904cd8eaa053c55bf03 Content-Type: text/plain; charset=UTF-8 Content-length: 1242 I'm checking in this patch, which should fix the remaining issues: On Sat, Sep 10, 2016 at 2:14 PM, Andreas Schwab wrote: > FAIL: g++.dg/cpp1z/aligned-new1.C (test for excess errors) > Excess errors: > /daten/aranym/gcc/gcc-20160910/gcc/testsuite/g++.dg/cpp1z/aligned-new1.C:10:20: warning: requested alignment 64 is larger than 16 [-Wattributes] > FAIL: g++.dg/cpp1z/aligned-new1.C execution test > FAIL: g++.dg/cpp1z/aligned-new4.C (test for warnings, line 11) > FAIL: g++.dg/cpp1z/aligned-new4.C (test for excess errors) > Excess errors: > /daten/aranym/gcc/gcc-20160910/gcc/testsuite/g++.dg/cpp1z/aligned-new4.C:3:20: warning: requested alignment 64 is larger than 16 [-Wattributes] > /daten/aranym/gcc/gcc-20160910/gcc/testsuite/g++.dg/cpp1z/aligned-new4.C:4:20: warning: requested alignment 64 is larger than 16 [-Wattributes] > FAIL: g++.dg/cpp1z/aligned-new5.C -std=gnu++11 (test for excess errors) > Excess errors: > aligned-new5.C:(.text+0xe): undefined reference to `operator new(unsigned int, std::align_val_t)' > > Andreas. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 > "And now for something completely different." --001a11494904cd8eaa053c55bf03 Content-Type: text/plain; charset=US-ASCII; name="align.diff" Content-Disposition: attachment; filename="align.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_it0j4tpx0 Content-length: 2884 Y29tbWl0IGRhOGUzYzJkNmNhMDg1YWViODE1ZDc0MWU0ZDg1OGIxMjE2NDcz YTEKQXV0aG9yOiBKYXNvbiBNZXJyaWxsIDxqYXNvbkByZWRoYXQuY29tPgpE YXRlOiAgIE1vbiBTZXAgMTIgMTU6MDE6MDYgMjAxNiAtMDQwMAoKICAgICAg ICAgICAgRml4IGFsaWduZWQtbmV3IHRlc3RzIG9uIG02OGsuCiAgICAKICAg ICAgICAgICAgKiBjLWNvbW1vbi5jIChjaGVja19jeHhfZnVuZGFtZW50YWxf YWxpZ25tZW50X2NvbnN0cmFpbnRzKTogRml4CiAgICAgICAgICAgIGJpdC9i eXRlIGNvbmZ1c2lvbiwgYWxsb3cgbGFyZ2UgYWxpZ25tZW50IGZvciB0eXBl cy4KCmRpZmYgLS1naXQgYS9nY2MvYy1mYW1pbHkvYy1jb21tb24uYyBiL2dj Yy9jLWZhbWlseS9jLWNvbW1vbi5jCmluZGV4IDE2ZjY1NDguLmI0ZjRkMTAg MTAwNjQ0Ci0tLSBhL2djYy9jLWZhbWlseS9jLWNvbW1vbi5jCisrKyBiL2dj Yy9jLWZhbWlseS9jLWNvbW1vbi5jCkBAIC03ODM2LDggKzc4MzYsNyBAQCBj aGVja191c2VyX2FsaWdubWVudCAoY29uc3RfdHJlZSBhbGlnbiwgYm9vbCBh bGxvd196ZXJvKQogICByZXR1cm4gaTsKIH0KIAotLyogCi0gICBJZiBpbiBj KystMTEsIGNoZWNrIGlmIHRoZSBjKystMTEgYWxpZ25tZW50IGNvbnN0cmFp bnQgd2l0aCByZXNwZWN0CisvKiBJZiBpbiBjKystMTEsIGNoZWNrIGlmIHRo ZSBjKystMTEgYWxpZ25tZW50IGNvbnN0cmFpbnQgd2l0aCByZXNwZWN0CiAg ICB0byBmdW5kYW1lbnRhbCBhbGlnbm1lbnQgKGluIFtkY2wuYWxpZ25dKSBh cmUgc2F0aXNmaWVkLiAgSWYgbm90IGluCiAgICBjKystMTEgbW9kZSwgZG9l cyBub3RoaW5nLgogCkBAIC03ODYyLDcgKzc4NjEsNyBAQCBjaGVja19jeHhf ZnVuZGFtZW50YWxfYWxpZ25tZW50X2NvbnN0cmFpbnRzICh0cmVlIG5vZGUs CiAJCQkJCSAgICAgaW50IGZsYWdzKQogewogICBib29sIGFsaWdubWVudF90 b29fbGFyZ2VfcCA9IGZhbHNlOwotICB1bnNpZ25lZCByZXF1ZXN0ZWRfYWxp Z25tZW50ID0gMVUgPDwgYWxpZ25fbG9nOworICB1bnNpZ25lZCByZXF1ZXN0 ZWRfYWxpZ25tZW50ID0gKDFVIDw8IGFsaWduX2xvZykgKiBCSVRTX1BFUl9V TklUOwogICB1bnNpZ25lZCBtYXhfYWxpZ24gPSAwOwogCiAgIGlmICgoIShm bGFncyAmIEFUVFJfRkxBR19DWFgxMSkgJiYgIXdhcm5fY3h4X2NvbXBhdCkK QEAgLTc5MDYsMTUgKzc5MDUsMTkgQEAgY2hlY2tfY3h4X2Z1bmRhbWVudGFs X2FsaWdubWVudF9jb25zdHJhaW50cyAodHJlZSBub2RlLAogICAgIH0KICAg ZWxzZSBpZiAoVFlQRV9QIChub2RlKSkKICAgICB7Ci0gICAgICAvKiBMZXQn cyBiZSBsaWJlcmFsIGZvciB0eXBlcy4gICovCi0gICAgICBpZiAocmVxdWVz dGVkX2FsaWdubWVudCA+IChtYXhfYWxpZ24gPSBCSUdHRVNUX0FMSUdOTUVO VCkpCisgICAgICAvKiBMZXQncyBiZSBsaWJlcmFsIGZvciB0eXBlcy4gIEJJ R0dFU1RfQUxJR05NRU5UIGlzIHRoZSBsYXJnZXN0CisJIGFsaWdubWVudCBh IGJ1aWx0LWluIHR5cGUgY2FuIHJlcXVpcmUsIE1BWF9PRklMRV9BTElHTk1F TlQgaXMgdGhlCisJIGxhcmdlc3QgYWxpZ25tZW50IHRoZSBvYmplY3QgZmls ZSBjYW4gcmVwcmVzZW50LCBidXQgYSB0eXBlIHRoYXQgaXMKKwkgb25seSBh bGxvY2F0ZWQgZHluYW1pY2FsbHkgY291bGQgcmVxdWVzdCBldmVuIGxhcmdl ciBhbGlnbm1lbnQuICBTbworCSBvbmx5IGxpbWl0IHR5cGUgYWxpZ25tZW50 IHRvIHdoYXQgVFlQRV9BTElHTiBjYW4gcmVwcmVzZW50LiAgKi8KKyAgICAg IGlmIChyZXF1ZXN0ZWRfYWxpZ25tZW50ID4gKG1heF9hbGlnbiA9IDhVIDw8 IDI4KSkKIAlhbGlnbm1lbnRfdG9vX2xhcmdlX3AgPSB0cnVlOwogICAgIH0K IAogICBpZiAoYWxpZ25tZW50X3Rvb19sYXJnZV9wKQogICAgIHBlZHdhcm4g KGlucHV0X2xvY2F0aW9uLCBPUFRfV2F0dHJpYnV0ZXMsCiAJICAgICAicmVx dWVzdGVkIGFsaWdubWVudCAlZCBpcyBsYXJnZXIgdGhhbiAlZCIsCi0JICAg ICByZXF1ZXN0ZWRfYWxpZ25tZW50LCBtYXhfYWxpZ24pOworCSAgICAgcmVx dWVzdGVkX2FsaWdubWVudCAvIEJJVFNfUEVSX1VOSVQsIG1heF9hbGlnbiAv IEJJVFNfUEVSX1VOSVQpOwogCiAgIHJldHVybiAhYWxpZ25tZW50X3Rvb19s YXJnZV9wOwogfQo= --001a11494904cd8eaa053c55bf03--