From: Jason Merrill <jason@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PING] C++ Re: [PATCH] C/C++: fix quoting of "aka" typedef information (PR 62170)
Date: Tue, 20 Jun 2017 18:01:00 -0000 [thread overview]
Message-ID: <CADzB+2=80Xbnu7unkryHi=WZ9TzNb8zx9Mi+gtxBhxBG5M_2Gg@mail.gmail.com> (raw)
In-Reply-To: <CADzB+2n-ofSz2yX7E2Di=BcuPvHz3FTzaxwATFFkMqMSyZPJ2Q@mail.gmail.com>
On Tue, Jun 20, 2017 at 1:58 PM, Jason Merrill <jason@redhat.com> wrote:
> On Tue, Jun 20, 2017 at 11:50 AM, David Malcolm <dmalcolm@redhat.com> wrote:
>>> + ob->next_free = p + type_start + type_len;
>
> I'm uncomfortable with modifying the obstack directly. Why not use
> obstack_free?
...because you aren't freeing the object, but shrinking it. So
obstack_blank is a better choice.
Jason
next prev parent reply other threads:[~2017-06-20 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 18:29 David Malcolm
2017-06-06 10:57 ` Marek Polacek
2017-06-20 15:51 ` [PING] C++ " David Malcolm
2017-06-20 17:59 ` Jason Merrill
2017-06-20 18:01 ` Jason Merrill [this message]
2017-06-20 19:06 ` David Malcolm
2017-06-20 19:12 ` Jason Merrill
2017-06-21 7:59 ` Volker Reichelt
2017-07-14 16:24 ` Martin Sebor
2017-07-16 10:02 ` Volker Reichelt
2017-06-21 13:59 ` [PATCH] v3: " David Malcolm
2017-07-14 15:47 ` [PING] " David Malcolm
2017-11-22 20:57 ` [committed] v5: " David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2=80Xbnu7unkryHi=WZ9TzNb8zx9Mi+gtxBhxBG5M_2Gg@mail.gmail.com' \
--to=jason@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).