From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Better location info for "incomplete type" error msg (PR c/70756)
Date: Wed, 04 May 2016 15:53:00 -0000 [thread overview]
Message-ID: <CADzB+2=8vf-gfA05-=xQePTmgajcV-rhEbWzD=bo2-caTv6e5Q@mail.gmail.com> (raw)
In-Reply-To: <20160504130013.GJ5348@redhat.com>
On Wed, May 4, 2016 at 9:00 AM, Marek Polacek <polacek@redhat.com> wrote:
> On Tue, May 03, 2016 at 08:05:47PM -0400, Jason Merrill wrote:
>> Looks good.
>>
>> But I don't see a C++ testcase; can the test go into c-c++-common?
>
> Sadly, no. As of now, the patch doesn't improve things for C++ (?). Seems
> we'd need to pass better locations down to pointer_int_sum / size_in_bytes.
> It cascades :(.
Sure. But can you fix that, too, while you're thinking about it?
Passing the location to cp_pointer_int_sum and pointer_diff seems
pretty simple.
Jason
next prev parent reply other threads:[~2016-05-04 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 15:59 Marek Polacek
2016-04-29 20:04 ` Jason Merrill
2016-05-02 16:41 ` Marek Polacek
2016-05-02 17:34 ` Jason Merrill
2016-05-03 11:27 ` Marek Polacek
2016-05-04 0:05 ` Jason Merrill
2016-05-04 13:00 ` Marek Polacek
2016-05-04 15:53 ` Jason Merrill [this message]
2016-05-05 14:22 ` Marek Polacek
2016-05-12 10:37 ` Marek Polacek
2016-05-12 15:09 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2=8vf-gfA05-=xQePTmgajcV-rhEbWzD=bo2-caTv6e5Q@mail.gmail.com' \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).