From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5135 invoked by alias); 4 May 2016 15:53:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5047 invoked by uid 89); 4 May 2016 15:53:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mail-ob0-f172.google.com Received: from mail-ob0-f172.google.com (HELO mail-ob0-f172.google.com) (209.85.214.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 04 May 2016 15:53:01 +0000 Received: by mail-ob0-f172.google.com with SMTP id dm5so22762570obc.1 for ; Wed, 04 May 2016 08:53:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JRh7HRdqtyrSRxnbwOqCxHFsA1lL4+WEq/0nQRFRax8=; b=WIfQdpdZj4DJFXy+zahJ7HEmY19wRcsOM+aEBcFWXd/vS6oD7nmuXdLclPEXW4mzNT ODvtn4qHiglwXND1CeSyfC8p+HzGNXFseqgPlEjUchZoIWIJ/iMsC36+vFdiK2PiJOLV UcM0Yev3zRtdNcF9kq+TgTg53KZfBrpCMo103KbEUoTXfp4T9+/ST7HOym5hYXM4cAmT hAUkBbPM/txKARA6AbvSTfdECrW9COzXfazBdjY5WyLsy3YdxFL6H3tPKChK6YtWqw6V BukNzeukuhMnL03jISI5kEEXuSYY305c1KfVfanOGFZh0KrfYl60eTxFmnVF9zkBUG1g Rydg== X-Gm-Message-State: AOPr4FUGpBz0oA8xeNcx1XBJ2VLM+uzMmf9wXB3ghFj3jivjTEhWLy8lU8vjbxLBVyAkDPValnxm6wemia4d13ne X-Received: by 10.182.213.8 with SMTP id no8mr4415652obc.8.1462377179087; Wed, 04 May 2016 08:52:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.129.233 with HTTP; Wed, 4 May 2016 08:52:39 -0700 (PDT) In-Reply-To: <20160504130013.GJ5348@redhat.com> References: <20160428155908.GQ28445@redhat.com> <5723BE3D.4070706@redhat.com> <20160502164149.GE5348@redhat.com> <57278FA6.90308@redhat.com> <20160503112707.GH5348@redhat.com> <57293CDB.6040204@redhat.com> <20160504130013.GJ5348@redhat.com> From: Jason Merrill Date: Wed, 04 May 2016 15:53:00 -0000 Message-ID: Subject: Re: [PATCH] Better location info for "incomplete type" error msg (PR c/70756) To: Marek Polacek Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00318.txt.bz2 On Wed, May 4, 2016 at 9:00 AM, Marek Polacek wrote: > On Tue, May 03, 2016 at 08:05:47PM -0400, Jason Merrill wrote: >> Looks good. >> >> But I don't see a C++ testcase; can the test go into c-c++-common? > > Sadly, no. As of now, the patch doesn't improve things for C++ (?). Seems > we'd need to pass better locations down to pointer_int_sum / size_in_bytes. > It cascades :(. Sure. But can you fix that, too, while you're thinking about it? Passing the location to cp_pointer_int_sum and pointer_diff seems pretty simple. Jason