From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9465 invoked by alias); 16 May 2018 01:01:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9453 invoked by uid 89); 16 May 2018 01:01:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f47.google.com Received: from mail-oi0-f47.google.com (HELO mail-oi0-f47.google.com) (209.85.218.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 01:01:19 +0000 Received: by mail-oi0-f47.google.com with SMTP id a6-v6so1943058oia.2 for ; Tue, 15 May 2018 18:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=R02k+c91SJE+vZOa3Ht6+tqAalTAdDguhcMmjZXGhxA=; b=GLNrep28O+JAZmvXHGny2EG6BmggJfytoLA2aZOYza1uojr3XPg9VaHXTNyXuLI7a8 9zNsXcPNK23HLTS6uq5+AnpH1k+bYiykVfdtffVzkRCB26y7tyt46ELYolz55KB9J7P5 FfIiT7l0247IvGv+tIj8xpl7p3T4yJVrp/a0WuDz/EaKn1IU5lMPEtL4ceX/KqLlXKzw haZuAes9sOEa0AAUgpUSjBZB5V8ypN9f/tvf1Gb9yWivPajU0t889JKWLqtu+EpYNv6b 426jyEKsrfTWLr7LAPxq5/0a2dmLENpT0MGj1Yp4bHSt/WxmX3cdWy6q+q4ziPcMR2Tk SPSQ== X-Gm-Message-State: ALKqPwej5pnOJHC3xwiUA99Qv4N+MzTrhw/TB1mw2NIxF79SBInLjMyy t+Z75WYxs0vLRYdKo0feaKfIiKvzkZtwN4MMuK/HOTtJ X-Google-Smtp-Source: AB8JxZrwy38ogAi5ridyEUq34zlqQFrqlbmafc3iyH4lQUlv7V7V+eSlKu5Ls3y7NTYWvzFHIoJ0Qwolckcfca8cDQg= X-Received: by 2002:aca:5b89:: with SMTP id p131-v6mr10946016oib.8.1526432477275; Tue, 15 May 2018 18:01:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.201.13.229 with HTTP; Tue, 15 May 2018 18:00:56 -0700 (PDT) From: Jason Merrill Date: Wed, 16 May 2018 02:34:00 -0000 Message-ID: Subject: RFA (tree.c): PATCH to make warn_deprecated_use return bool To: gcc-patches List Content-Type: multipart/mixed; boundary="000000000000959775056c4841b4" X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00708.txt.bz2 --000000000000959775056c4841b4 Content-Type: text/plain; charset="UTF-8" Content-length: 407 The function "warning" returns bool to indicated whether or not any diagnostic was actually emitted; warn_deprecated_use should as well. It's also unnecessary to duplicate the warning code between the cases of null or non-null "decl", since the actual warnings were the same. The only thing that's different is whether we indicate the source location of "decl". Tested x86_64-pc-linux-gnu. OK for trunk? --000000000000959775056c4841b4 Content-Type: text/x-patch; charset="US-ASCII"; name="warn-depr-bool.diff" Content-Disposition: attachment; filename="warn-depr-bool.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jh8egz1w0 Content-length: 4262 Y29tbWl0IGI0OWYyOTI4MTQ2OTNkZTk3YjIxOGY2ZDhiMzJiMjBkZDY4ZmI4 YzgKQXV0aG9yOiBKYXNvbiBNZXJyaWxsIDxqYXNvbkByZWRoYXQuY29tPgpE YXRlOiAgIFR1ZSBNYXkgMTUgMTc6NDE6MTkgMjAxOCAtMDQwMAoKICAgICAg ICAgICAgKiB0cmVlLmMgKHdhcm5fZGVwcmVjYXRlZF91c2UpOiBSZXR1cm4g Ym9vbC4gIFNpbXBsaWZ5IGxvZ2ljLgoKZGlmZiAtLWdpdCBhL2djYy90cmVl LmMgYi9nY2MvdHJlZS5jCmluZGV4IDc3YTczYjQ0OTVlLi42ODE2NWY0ZGVl ZCAxMDA2NDQKLS0tIGEvZ2NjL3RyZWUuYworKysgYi9nY2MvdHJlZS5jCkBA IC0xMjQyMCwxNCArMTI0MjAsMTYgQEAgdHlwZWRlZl92YXJpYW50X3AgKGNv bnN0X3RyZWUgdHlwZSkKICAgcmV0dXJuIGlzX3R5cGVkZWZfZGVjbCAoVFlQ RV9OQU1FICh0eXBlKSk7CiB9CiAKLS8qIFdhcm4gYWJvdXQgYSB1c2Ugb2Yg YW4gaWRlbnRpZmllciB3aGljaCB3YXMgbWFya2VkIGRlcHJlY2F0ZWQuICAq Lwotdm9pZAorLyogV2FybiBhYm91dCBhIHVzZSBvZiBhbiBpZGVudGlmaWVy IHdoaWNoIHdhcyBtYXJrZWQgZGVwcmVjYXRlZC4gIFJldHVybnMKKyAgIHdo ZXRoZXIgYSB3YXJuaW5nIHdhcyBnaXZlbi4gICovCisKK2Jvb2wKIHdhcm5f ZGVwcmVjYXRlZF91c2UgKHRyZWUgbm9kZSwgdHJlZSBhdHRyKQogewogICBj b25zdCBjaGFyICptc2c7CiAKICAgaWYgKG5vZGUgPT0gMCB8fCAhd2Fybl9k ZXByZWNhdGVkX2RlY2wpCi0gICAgcmV0dXJuOworICAgIHJldHVybiBmYWxz ZTsKIAogICBpZiAoIWF0dHIpCiAgICAgewpAQCAtMTI0NTAsNyArMTI0NTIs NyBAQCB3YXJuX2RlcHJlY2F0ZWRfdXNlICh0cmVlIG5vZGUsIHRyZWUgYXR0 cikKICAgZWxzZQogICAgIG1zZyA9IE5VTEw7CiAKLSAgYm9vbCB3OworICBi b29sIHcgPSBmYWxzZTsKICAgaWYgKERFQ0xfUCAobm9kZSkpCiAgICAgewog ICAgICAgaWYgKG1zZykKQEAgLTEyNDc2LDQ5ICsxMjQ3OCwyOSBAQCB3YXJu X2RlcHJlY2F0ZWRfdXNlICh0cmVlIG5vZGUsIHRyZWUgYXR0cikKIAkgICAg d2hhdCA9IERFQ0xfTkFNRSAoVFlQRV9OQU1FIChub2RlKSk7CiAJfQogCi0g ICAgICBpZiAoZGVjbCkKKyAgICAgIGlmICh3aGF0KQogCXsKLQkgIGlmICh3 aGF0KQotCSAgICB7Ci0JICAgICAgaWYgKG1zZykKLQkJdyA9IHdhcm5pbmcg KE9QVF9XZGVwcmVjYXRlZF9kZWNsYXJhdGlvbnMsCi0JCQkgICAgICIlcUUg aXMgZGVwcmVjYXRlZDogJXMiLCB3aGF0LCBtc2cpOwotCSAgICAgIGVsc2UK LQkJdyA9IHdhcm5pbmcgKE9QVF9XZGVwcmVjYXRlZF9kZWNsYXJhdGlvbnMs Ci0JCQkgICAgICIlcUUgaXMgZGVwcmVjYXRlZCIsIHdoYXQpOwotCSAgICB9 CisJICBpZiAobXNnKQorCSAgICB3ID0gd2FybmluZyAoT1BUX1dkZXByZWNh dGVkX2RlY2xhcmF0aW9ucywKKwkJCSAiJXFFIGlzIGRlcHJlY2F0ZWQ6ICVz Iiwgd2hhdCwgbXNnKTsKIAkgIGVsc2UKLQkgICAgewotCSAgICAgIGlmICht c2cpCi0JCXcgPSB3YXJuaW5nIChPUFRfV2RlcHJlY2F0ZWRfZGVjbGFyYXRp b25zLAotCQkJICAgICAidHlwZSBpcyBkZXByZWNhdGVkOiAlcyIsIG1zZyk7 Ci0JICAgICAgZWxzZQotCQl3ID0gd2FybmluZyAoT1BUX1dkZXByZWNhdGVk X2RlY2xhcmF0aW9ucywKLQkJCSAgICAgInR5cGUgaXMgZGVwcmVjYXRlZCIp OwotCSAgICB9Ci0JICBpZiAodykKLQkgICAgaW5mb3JtIChERUNMX1NPVVJD RV9MT0NBVElPTiAoZGVjbCksICJkZWNsYXJlZCBoZXJlIik7CisJICAgIHcg PSB3YXJuaW5nIChPUFRfV2RlcHJlY2F0ZWRfZGVjbGFyYXRpb25zLAorCQkJ ICIlcUUgaXMgZGVwcmVjYXRlZCIsIHdoYXQpOwogCX0KICAgICAgIGVsc2UK IAl7Ci0JICBpZiAod2hhdCkKLQkgICAgewotCSAgICAgIGlmIChtc2cpCi0J CXdhcm5pbmcgKE9QVF9XZGVwcmVjYXRlZF9kZWNsYXJhdGlvbnMsICIlcUUg aXMgZGVwcmVjYXRlZDogJXMiLAotCQkJIHdoYXQsIG1zZyk7Ci0JICAgICAg ZWxzZQotCQl3YXJuaW5nIChPUFRfV2RlcHJlY2F0ZWRfZGVjbGFyYXRpb25z LCAiJXFFIGlzIGRlcHJlY2F0ZWQiLCB3aGF0KTsKLQkgICAgfQorCSAgaWYg KG1zZykKKwkgICAgdyA9IHdhcm5pbmcgKE9QVF9XZGVwcmVjYXRlZF9kZWNs YXJhdGlvbnMsCisJCQkgInR5cGUgaXMgZGVwcmVjYXRlZDogJXMiLCBtc2cp OwogCSAgZWxzZQotCSAgICB7Ci0JICAgICAgaWYgKG1zZykKLQkJd2Fybmlu ZyAoT1BUX1dkZXByZWNhdGVkX2RlY2xhcmF0aW9ucywgInR5cGUgaXMgZGVw cmVjYXRlZDogJXMiLAotCQkJIG1zZyk7Ci0JICAgICAgZWxzZQotCQl3YXJu aW5nIChPUFRfV2RlcHJlY2F0ZWRfZGVjbGFyYXRpb25zLCAidHlwZSBpcyBk ZXByZWNhdGVkIik7Ci0JICAgIH0KKwkgICAgdyA9IHdhcm5pbmcgKE9QVF9X ZGVwcmVjYXRlZF9kZWNsYXJhdGlvbnMsCisJCQkgInR5cGUgaXMgZGVwcmVj YXRlZCIpOwogCX0KKyAgICAgIGlmICh3ICYmIGRlY2wpCisJaW5mb3JtIChE RUNMX1NPVVJDRV9MT0NBVElPTiAoZGVjbCksICJkZWNsYXJlZCBoZXJlIik7 CiAgICAgfQorCisgIHJldHVybiB3OwogfQogCiAvKiBSZXR1cm4gdHJ1ZSBp ZiBSRUYgaGFzIGEgQ09NUE9ORU5UX1JFRiB3aXRoIGEgYml0LWZpZWxkIGZp ZWxkIGRlY2xhcmF0aW9uCmRpZmYgLS1naXQgYS9nY2MvdHJlZS5oIGIvZ2Nj L3RyZWUuaAppbmRleCA3NGEwZDE4ODFhNi4uZWY4YmZmNDA1ZmUgMTAwNjQ0 Ci0tLSBhL2djYy90cmVlLmgKKysrIGIvZ2NjL3RyZWUuaApAQCAtNDgyOCw3 ICs0ODI4LDcgQEAgZXh0ZXJuIHRyZWUgdHJlZV9zdHJpcF9zaWduX25vcF9j b252ZXJzaW9ucyAodHJlZSk7CiBleHRlcm4gY29uc3RfdHJlZSBzdHJpcF9p bnZhcmlhbnRfcmVmcyAoY29uc3RfdHJlZSk7CiBleHRlcm4gdHJlZSBsaGRf Z2NjX3BlcnNvbmFsaXR5ICh2b2lkKTsKIGV4dGVybiB2b2lkIGFzc2lnbl9h c3NlbWJsZXJfbmFtZV9pZl9uZWVkZWQgKHRyZWUpOwotZXh0ZXJuIHZvaWQg d2Fybl9kZXByZWNhdGVkX3VzZSAodHJlZSwgdHJlZSk7CitleHRlcm4gYm9v bCB3YXJuX2RlcHJlY2F0ZWRfdXNlICh0cmVlLCB0cmVlKTsKIGV4dGVybiB2 b2lkIGNhY2hlX2ludGVnZXJfY3N0ICh0cmVlKTsKIGV4dGVybiBjb25zdCBj aGFyICpjb21iaW5lZF9mbl9uYW1lIChjb21iaW5lZF9mbik7CiAK --000000000000959775056c4841b4--