From: Jason Merrill <jason@redhat.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ PATCH] overloaded operator fns [8/N]
Date: Wed, 01 Nov 2017 20:09:00 -0000 [thread overview]
Message-ID: <CADzB+2k19Efvxc+0yT9g9WeJDMLMTxoh0m70-o=74OdRup8Hmg@mail.gmail.com> (raw)
In-Reply-To: <eda1fe89-a112-6240-b5c6-182cc9a3f98a@acm.org>
On Wed, Nov 1, 2017 at 2:29 PM, Nathan Sidwell <nathan@acm.org> wrote:
> This is the last of the overloaded operator reworking. Now we can cheaply
> go from identifier->overload info, there's no need to specially mark
> identifiers as new or delete operators themselves. Thus we can reorder the
> cp_identifier_kind enumeration and leave space in it for udlit operators.
>
> This patch does that renumbering, and reserves a value for udlit operators.
> Those are currently detected by string compare, which isn't the most
> satisfactory way to do it. But it's a change for another day.
> - && IDENTIFIER_NEWDEL_OP_P (unqualified_id)))
> + && IDENTIFIER_OVL_OP_P (unqualified_id)
> + && (IDENTIFIER_OVL_OP_FLAGS (unqualified_id) & OVL_OP_FLAG_ALLOC)))
Why not keep the name IDENTIFIER_NEWDEL_OP_P, which expands to this?
Jason
next prev parent reply other threads:[~2017-11-01 20:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 13:12 [C++ PATCH] overloaded operator fns [1/N] Nathan Sidwell
2017-10-31 14:45 ` [C++ PATCH] overloaded operator fns [2/N] Nathan Sidwell
2017-10-31 16:30 ` [C++ PATCH] overloaded operator fns [3/N] Nathan Sidwell
2017-10-31 18:45 ` [C++ PATCH] overloaded operator fns [4/N] Nathan Sidwell
2017-10-31 20:20 ` [C++ PATCH] overloaded operator fns [5/N] Nathan Sidwell
2017-11-01 14:02 ` [C++ PATCH] overloaded operator fns [6/N] Nathan Sidwell
2017-11-01 15:45 ` Nathan Sidwell
2017-11-01 18:29 ` [C++ PATCH] overloaded operator fns [8/N] Nathan Sidwell
2017-11-01 20:09 ` Jason Merrill [this message]
2017-11-02 14:15 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2k19Efvxc+0yT9g9WeJDMLMTxoh0m70-o=74OdRup8Hmg@mail.gmail.com' \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).