From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124688 invoked by alias); 1 Nov 2017 20:09:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124465 invoked by uid 89); 1 Nov 2017 20:09:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-io0-f196.google.com Received: from mail-io0-f196.google.com (HELO mail-io0-f196.google.com) (209.85.223.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Nov 2017 20:09:02 +0000 Received: by mail-io0-f196.google.com with SMTP id b186so8754786iof.8 for ; Wed, 01 Nov 2017 13:09:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=n5UJkMxAPB6CiAicNV7iZ9uWeTiKWdX44UdQ0HTOL0M=; b=TznBJvX51jtK60WRvgPTBtwDAC5ZPXQKSSTfvHgEflZSGUAHyVq79nibSV24NY0YLb aH3jCdAjOiPBQu7tFpz9+bz9FfAtVrFcIO/1yMQCX7Vg/hWcYjZBOoG1GhY3ZS435ipF JDNppOoWJRIhxt4T5mIS4F6obzFlIciFx/zjMtmwtCsQ2Qluz4evy2CscnIucc35aHqr XCoWHrUt9doKMV9QWS9vA2Dedd4bxQy+DoKsHyIRkq02R17VC/vhXkMLjOMBFlpImJ0f lkDqv0dY+CtSELcdH+SWx19YtbfHvYA90S9eHGoDACx8dt6eulS5qeVYKivNMtFaAZWQ DyIw== X-Gm-Message-State: AJaThX5mJ/64rptw5QaL3yXBkOCxeB1OJImi8IAjMUPDRVTTdwuekyzA tIr89KF1rQ4VyNWq46wW6CazqDf44a15pacJ/foI7A== X-Google-Smtp-Source: ABhQp+QvLfS1wVjuSJ+XUrzEbebeG/umnOtidjl13SdtNUvkTtUUmiSXX/I0UX61XFewQi/cWmT8T1FG7OCx5rcffgI= X-Received: by 10.107.168.205 with SMTP id e74mr1383842ioj.42.1509566940299; Wed, 01 Nov 2017 13:09:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.170.26 with HTTP; Wed, 1 Nov 2017 13:08:39 -0700 (PDT) In-Reply-To: References: <40b48778-5335-2398-3dd5-e59f68b8f052@acm.org> <006c8467-dde6-1605-243c-f8d033ab4e49@acm.org> <85d3718d-17f4-42f4-db0b-7c2b3632aa6e@acm.org> From: Jason Merrill Date: Wed, 01 Nov 2017 20:09:00 -0000 Message-ID: Subject: Re: [C++ PATCH] overloaded operator fns [8/N] To: Nathan Sidwell Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00042.txt.bz2 On Wed, Nov 1, 2017 at 2:29 PM, Nathan Sidwell wrote: > This is the last of the overloaded operator reworking. Now we can cheaply > go from identifier->overload info, there's no need to specially mark > identifiers as new or delete operators themselves. Thus we can reorder the > cp_identifier_kind enumeration and leave space in it for udlit operators. > > This patch does that renumbering, and reserves a value for udlit operators. > Those are currently detected by string compare, which isn't the most > satisfactory way to do it. But it's a change for another day. > - && IDENTIFIER_NEWDEL_OP_P (unqualified_id))) > + && IDENTIFIER_OVL_OP_P (unqualified_id) > + && (IDENTIFIER_OVL_OP_FLAGS (unqualified_id) & OVL_OP_FLAG_ALLOC))) Why not keep the name IDENTIFIER_NEWDEL_OP_P, which expands to this? Jason