Re: C++ PATCH to remove WITH_CLEANUP_EXPR handling

[Jason Merrill <jason@redhat.com>]

Absolutely.

On Mon, Jul 3, 2017 at 5:35 AM, Marek Polacek <polacek@redhat.com> wrote:
> On Thu, Jun 29, 2017 at 05:44:25PM -0400, Jason Merrill wrote:
>> The C++ front end hasn't generated WITH_CLEANUP_EXPR in a very long
>> time (20+ years?), so there's no need to handle it.
>
> Heh.  Found another one; is this patch ok if it passes testing?
>
> 2017-07-03  Marek Polacek  <polacek@redhat.com>
>
>         * c-warn.c (warn_if_unused_value): Remove WITH_CLEANUP_EXPR handling.
>
> diff --git gcc/c-family/c-warn.c gcc/c-family/c-warn.c
> index 5d67395..b9378c2 100644
> --- gcc/c-family/c-warn.c
> +++ gcc/c-family/c-warn.c
> @@ -465,7 +465,6 @@ warn_if_unused_value (const_tree exp, location_t locus)
>      case TARGET_EXPR:
>      case CALL_EXPR:
>      case TRY_CATCH_EXPR:
> -    case WITH_CLEANUP_EXPR:
>      case EXIT_EXPR:
>      case VA_ARG_EXPR:
>        return false;
>
>         Marek