public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: Reorgnanization of profile count maintenance code, part 1
Date: Thu, 08 Jun 2017 16:57:00 -0000	[thread overview]
Message-ID: <CADzB+2k7kDaV1m4Smo93cjb1Xmc3Ei7NP1uC1ambmRdqeVWnug@mail.gmail.com> (raw)
In-Reply-To: <20170606080047.GB95556@kam.mff.cuni.cz>

On Tue, Jun 6, 2017 at 1:00 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> On Thu, Jun 1, 2017 at 4:35 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> > Index: profile.c
>> > ===================================================================
>> > --- profile.c   (revision 248684)
>> > +++ profile.c   (working copy)
>> > @@ -67,6 +67,10 @@ along with GCC; see the file COPYING3.
>> >
>> >  #include "profile.h"
>> >
>> > +/* Map from BBs/edges to gcov counters.  */
>> > +vec<gcov_type> bb_gcov_counts;
>> > +hash_map<edge,gcov_type> edge_gcov_counts;
>>
>> This completely breaks the compiler with
>> --enable-gather-detailed-mem-stats; edge_gcov_counts gets initialized
>> before hash_table_usage in hash-table.c, and so when the constructor
>> for edge_gcov_counts calls hash_table_usage.register_descriptor, m_map
>> is null and we get a SEGV.
>
> I will change this to pointer to avoid static cdtor.  Thanks!

Ping?

Jason

  reply	other threads:[~2017-06-08 16:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 11:36 Jan Hubicka
2017-06-03 18:51 ` Bernhard Reutner-Fischer
2017-06-04 17:21   ` Jan Hubicka
2017-06-05 15:13     ` Joseph Myers
2017-06-05 15:16       ` Jan Hubicka
2017-06-05 15:37       ` Jan Hubicka
2017-06-05 18:38         ` Andrew Pinski
2017-06-06  5:57 ` Jason Merrill
2017-06-06  8:00   ` Jan Hubicka
2017-06-08 16:57     ` Jason Merrill [this message]
2017-06-09  7:52       ` Jan Hubicka
2017-06-06 16:31 ` Segher Boessenkool
2017-06-06 20:25   ` Jan Hubicka
2017-06-07 18:44     ` Segher Boessenkool
2017-06-07 21:11       ` Jan Hubicka
2017-06-07 21:41         ` Segher Boessenkool
2017-06-05 18:52 Dominique d'Humières
2017-06-05 19:14 ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADzB+2k7kDaV1m4Smo93cjb1Xmc3Ei7NP1uC1ambmRdqeVWnug@mail.gmail.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).