public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Volker Reichelt <v.reichelt@netcologne.de>
Cc: Martin Sebor <msebor@gmail.com>,
	gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: {PATCH] New C++ warning -Wcatch-value
Date: Mon, 05 Jun 2017 19:08:00 -0000	[thread overview]
Message-ID: <CADzB+2k=AKarYJ2dhBZUVEkX_uHHXv-L9WwYjQNYpUsSpoWZGg@mail.gmail.com> (raw)
In-Reply-To: <tkrat.8121d74c0ac2c92d@netcologne.de>

On Mon, Jun 5, 2017 at 6:55 AM, Volker Reichelt
<v.reichelt@netcologne.de> wrote:
> On 15 May, Martin Sebor wrote:
>>> So how about the following then? I stayed with the catch part and added
>>> a parameter to the warning to let the user decide on the warnings she/he
>>> wants to get: -Wcatch-value=n.
>>> -Wcatch-value=1 only warns for polymorphic classes that are caught by
>>> value (to avoid slicing), -Wcatch-value=2 warns for all classes that
>>> are caught by value (to avoid copies). And finally -Wcatch-value=3
>>> warns for everything not caught by reference to find typos (like pointer
>>> instead of reference) and bad coding practices.
>>
>> It seems reasonable to me.  I'm not too fond of multi-level
>> warnings since few users take advantage of anything but the
>> default, but this case is simple and innocuous enough that
>> I don't think it can do harm.
>>
>>>
>>> Bootstrapped and regtested on x86_64-pc-linux-gnu.
>>> OK for trunk?
>>>
>>> If so, would it make sense to add -Wcatch-value=1 to -Wextra or even -Wall?
>>> I would do this in a seperate patch, becuase I haven't checked what that
>>> would mean for the testsuite.
>>
>> I can't think of a use case for polymorphic slicing that's not
>> harmful so unless there is a common one that escapes me, I'd say
>> -Wall.
>
> So that's what I committed after Jason's OK.
>
>> What are your thoughts on enhancing the warning to also handle
>> the rethrow case?
>>
>> Also, it seems that a similar warning would be useful even beyond
>> catch handlers, to help detect slicing when passing arguments to
>> functions by value.  Especially in code that mixes OOP with the
>> STL (or other template libraries).  Have you thought about tackling
>> that at some point as well?
>
> I don't have any plans to handle handle the rethrow case.
>
> A general slicing warning would be very nice to have. Actually
> clang-tidy has one (which is a little buggy, though).
> Implementing this is over my head, though.
> I'd rather stick with something less ambitious.

FWIW I think it would be pretty straightforward to do this in
convert_like_real, under the ck_base case.

Jason

      reply	other threads:[~2017-06-05 19:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-01  8:38 Volker Reichelt
2017-05-03  3:34 ` Martin Sebor
2017-05-07 20:28   ` Volker Reichelt
2017-05-08  3:18     ` Martin Sebor
2017-05-08 13:14       ` Jason Merrill via gcc-patches
2017-05-14 15:30       ` Volker Reichelt
2017-05-15 20:03         ` Martin Sebor
2017-05-24 20:13           ` Jason Merrill
2017-05-30  6:22             ` Volker Reichelt
2017-05-31 20:55               ` Jason Merrill
2017-06-05 10:55           ` Volker Reichelt
2017-06-05 19:08             ` Jason Merrill [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADzB+2k=AKarYJ2dhBZUVEkX_uHHXv-L9WwYjQNYpUsSpoWZGg@mail.gmail.com' \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=msebor@gmail.com \
    --cc=v.reichelt@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).