From: Jason Merrill <jason@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: Jeff Law <law@redhat.com>, gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/2] C++: avoid partial duplicate implementation of cp_parser_error
Date: Wed, 11 Oct 2017 21:21:00 -0000 [thread overview]
Message-ID: <CADzB+2kGNTWrfynftSsz2Vdm6nMuy8sFOz-O=OSEkTJEPG2gnA@mail.gmail.com> (raw)
In-Reply-To: <1506434179-2736-2-git-send-email-dmalcolm@redhat.com>
On Tue, Sep 26, 2017 at 9:56 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> In r251026 (aka 3fe34694f0990d1d649711ede0326497f8a849dc,
> "C/C++: show pertinent open token when missing a close token")
> I copied part of cp_parser_error into cp_parser_required_error,
> leading to duplication of code.
>
> This patch eliminates this duplication by merging the two copies of the
> code into a new cp_parser_error_1 subroutine.
>
> Doing so removes an indentation level, making the patch appear to have
> more churn than it really does.
FWIW, you could also attach a patch generated with -w to ignore
whitespace changes.
The patch is OK.
Jason
next prev parent reply other threads:[~2017-10-11 21:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 18:04 [PATCH] C/C++: add fix-it hints for various missing symbols David Malcolm
2017-07-03 18:57 ` Richard Sandiford
2017-07-03 19:34 ` David Malcolm
2017-07-11 14:09 ` [committed] diagnostics: support compact printing of secondary locations David Malcolm
2017-07-11 17:34 ` Richard Sandiford
2017-07-03 23:01 ` [PATCH] C/C++: add fix-it hints for various missing symbols Joseph Myers
2017-07-05 15:32 ` David Malcolm
2017-07-05 16:17 ` Joseph Myers
2017-08-28 16:11 ` Jeff Law
2017-09-26 13:56 ` [PATCH 0/2] " David Malcolm
2017-09-26 13:56 ` [PATCH 2/2] C/C++: add fix-it hints for various missing symbols (v2) David Malcolm
2017-10-05 16:08 ` [PATCH 2/2] C/C++: add fix-it hints for various missing symbols (v3) David Malcolm
2017-10-11 17:27 ` PING " David Malcolm
2017-10-12 5:23 ` Jason Merrill
2017-09-26 13:56 ` [PATCH 1/2] C++: avoid partial duplicate implementation of cp_parser_error David Malcolm
2017-10-11 17:26 ` PING: " David Malcolm
2017-10-11 21:21 ` Jason Merrill [this message]
2017-10-12 18:10 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2kGNTWrfynftSsz2Vdm6nMuy8sFOz-O=OSEkTJEPG2gnA@mail.gmail.com' \
--to=jason@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).