From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Alexandre Oliva <aoliva@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>,
Mark Wielaard <mjw@redhat.com>
Subject: Re: [PR84620] output symbolic entry_view as data2, not addr
Date: Wed, 07 Mar 2018 15:16:00 -0000 [thread overview]
Message-ID: <CADzB+2kGo79Ssq09Yd=x3duu+vW+wwSW6AERrZisTouHFS_ezw@mail.gmail.com> (raw)
In-Reply-To: <20180306072848.GV5867@tucnak>
On Tue, Mar 6, 2018 at 2:28 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Mar 06, 2018 at 03:13:11AM -0300, Alexandre Oliva wrote:
>> Jakub wrote (in the BZ):
>>
>> > I meant to say:
>> > The char * GTY ((tag ("dw_val_class_symview"))) val_symbolic_view; line
>> > should come at the and of the union, not before the other classes.
>>
>> I've moved the union field down in the revised patch below, but I don't
>> see the point, and I thought it would be better to keep it close to
>> logically-similar entries. If the point is just to make it parallel to
>> the order of the enum (which manh other entries don't seem to have cared
>> about), maybe moving the enum would be better?
>
> I think the order should match the order of the dw_val_class entries and
> should be sorted from the most commonly used ones (ones used by most
> different attributes etc.), so that somebody trying to learn dwarf2out
> stuff can learn it more easily (say the dw_val_class_const,
> dw_val_class_const_unsigned, dw_val_class_flag first etc.), but apparently
> it is completely random already, I'll defer to Jason what he wants.
I don't think the order of the GTY tags matters much, it's just boilerplate.
Jason
next prev parent reply other threads:[~2018-03-07 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 7:57 Alexandre Oliva
2018-03-06 6:13 ` Alexandre Oliva
2018-03-06 7:29 ` Jakub Jelinek
2018-03-07 15:16 ` Jason Merrill [this message]
2018-03-08 9:05 ` Alexandre Oliva
2018-03-08 13:35 ` Jakub Jelinek
2018-03-09 8:49 ` Alexandre Oliva
2018-03-09 9:35 ` Jakub Jelinek
2018-03-09 15:11 ` Jason Merrill
2018-03-10 6:41 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2kGo79Ssq09Yd=x3duu+vW+wwSW6AERrZisTouHFS_ezw@mail.gmail.com' \
--to=jason@redhat.com \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mjw@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).