From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32905 invoked by alias); 9 Sep 2017 14:01:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 32164 invoked by uid 89); 9 Sep 2017 14:01:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=flawed X-HELO: mail-io0-f176.google.com Received: from mail-io0-f176.google.com (HELO mail-io0-f176.google.com) (209.85.223.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Sep 2017 14:01:19 +0000 Received: by mail-io0-f176.google.com with SMTP id j141so10493403ioj.4 for ; Sat, 09 Sep 2017 07:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=d/CdQa1fSKXVBZKuncftRdRUIxsUs5LkNUD83IaX12E=; b=M9XOOjonooBiumgenNxsGlLARfnR4Ez5HXrGbi+7S0abMuRl1rrrovZ5MnGd8X/fic f0PApOqeS4KPcR8izf/yQarvjxmeMbtxPuqHphT9NQdwSqFgCj1op5ya9E4iwy/ZAr9b Slpu3Fhc/fbfHChhAA3k/NzXlvRCajNL4WeY2E/fbpGmrNjRnW9GcR2uDhMeKkAvl/H4 wBrW4+Vx49eqL1Z5r8OHHd6FOs/XNvjdWMfxIay+q3hwaeZtRmlX7Evehcrn4+2/6V6w ccWMrHcIqRd/FZC/AtPfn9xqpk2ppIKGv04pxLJJmV7gtpauG95AeBMhFmCmPFm9LSl1 1dDQ== X-Gm-Message-State: AHPjjUgO3cYnkB5GKaWhD9BKRtK+z8lrz9fRAsaJkk3GqbiCtqSEzEDu kk9oX54k3gxEPPkWJlEzWnj2gjGIL5ET X-Google-Smtp-Source: AOwi7QDKi83GLx3RkzAK9In0sA9zkheb8+o+pKH6vAaOYQmYqU5y9gf6OJ6727WVGMsd7LSfWjqnYvjn/2j9zzW9nVo= X-Received: by 10.107.35.193 with SMTP id j184mr5043911ioj.113.1504965677288; Sat, 09 Sep 2017 07:01:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.181.23 with HTTP; Sat, 9 Sep 2017 07:00:56 -0700 (PDT) In-Reply-To: References: From: Jason Merrill Date: Sat, 09 Sep 2017 14:01:00 -0000 Message-ID: Subject: Re: [PATCH] Early LTO debug TODO To: Richard Biener Cc: gcc-patches List Content-Type: multipart/mixed; boundary="001a1140f29e98a8850558c2208f" X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00541.txt.bz2 --001a1140f29e98a8850558c2208f Content-Type: text/plain; charset="UTF-8" Content-length: 1990 On Thu, Aug 31, 2017 at 4:03 PM, Richard Biener wrote: > On Thu, 31 Aug 2017, Richard Biener wrote: > >> >> As suspected during review the DECL_ABSTRACT_P handling in >> gen_formal_parameter_die is no longer necessary so the following >> patch removes it. >> >> [LTO] bootstrapped on x86_64-unknown-linux-gnu, testing in progress. >> The gdb testsuite shows no regression. >> >> Will apply after testing finished. > > Ok, so it doesn't work - it regresses for example > gcc.dg/debug/dwarf2/inline1.c because we end up annotating the > abstract DIE with a location. This is because in gen_subprogram_die > (with decl set as abstract-self and thus generating a concrete > instance subroutine die) we call > > else if (parm && !POINTER_BOUNDS_P (parm)) > { > dw_die_ref parm_die = gen_decl_die (parm, NULL, NULL, > subr_die); > > thus unconditionally pass NULL as origin where gen_formal_parameter_die > just has > > /* If we have a previously generated DIE, use it, unless this is an > concrete instance (origin != NULL), in which case we need a new > DIE with a corresponding DW_AT_abstract_origin. */ > bool reusing_die; > if (parm_die && origin == NULL) > reusing_die = true; > else > { > parm_die = new_die (DW_TAG_formal_parameter, context_die, node); > reusing_die = false; > } > > but obviously that logic is flawed with us passing origin as NULL... > > What saved us here is the check whether the existing param_die has > the correct parent, if not we didn't re-use it. OTOH for die_parent > == NULL we have the extra check that would have been dead code. > > Any hint as to whether we should pass in anything as origin or > whether we should keep the existing die_parent logic somehow? > (do we ever get a NULL context_die passed?) The problem is that we aren't checking decl_ultimate_origin soon enough, and thereby setting origin. Tested x86_64-pc-linux-gnu, applying to trunk: --001a1140f29e98a8850558c2208f Content-Type: text/plain; charset="US-ASCII"; name="parm-debug.diff" Content-Disposition: attachment; filename="parm-debug.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j7ddowld0 Content-length: 2648 Y29tbWl0IGI3NzAyYTJjYmNhOWM1MGU5NDA1M2NjMTI1ZmY5MzQzOGQzNzcx MjYKQXV0aG9yOiBKYXNvbiBNZXJyaWxsIDxqYXNvbkByZWRoYXQuY29tPgpE YXRlOiAgIFNhdCBTZXAgOSAxMTozMzoxNCAyMDE3ICswMjAwCgogICAgICAg ICAgICAqIGR3YXJmMm91dC5jIChnZW5fZm9ybWFsX3BhcmFtZXRlcl9kaWUp OiBSZW1vdmUgb2Jzb2xldGUgaHVuay4KICAgIAogICAgICAgICAgICBDaGVj ayB1bHRpbWF0ZV9vcmlnaW4gYmVmb3JlIHNldHRpbmcgcmV1c2luZ19kaWUu CgpkaWZmIC0tZ2l0IGEvZ2NjL2R3YXJmMm91dC5jIGIvZ2NjL2R3YXJmMm91 dC5jCmluZGV4IDY1MWRkMGMuLmNjOTNkYjMgMTAwNjQ0Ci0tLSBhL2djYy9k d2FyZjJvdXQuYworKysgYi9nY2MvZHdhcmYyb3V0LmMKQEAgLTIxMjg1LDMw ICsyMTI4NSwxNSBAQCBnZW5fZm9ybWFsX3BhcmFtZXRlcl9kaWUgKHRyZWUg bm9kZSwgdHJlZSBvcmlnaW4sIGJvb2wgZW1pdF9uYW1lX3AsCiAJCQkgIGR3 X2RpZV9yZWYgY29udGV4dF9kaWUpCiB7CiAgIHRyZWUgbm9kZV9vcl9vcmln aW4gPSBub2RlID8gbm9kZSA6IG9yaWdpbjsKLSAgdHJlZSB1bHRpbWF0ZV9v cmlnaW47CiAgIGR3X2RpZV9yZWYgcGFybV9kaWUgPSBOVUxMOwogICAKLSAg aWYgKFRSRUVfQ09ERV9DTEFTUyAoVFJFRV9DT0RFIChub2RlX29yX29yaWdp bikpID09IHRjY19kZWNsYXJhdGlvbikKKyAgaWYgKERFQ0xfUCAobm9kZV9v cl9vcmlnaW4pKQogICAgIHsKICAgICAgIHBhcm1fZGllID0gbG9va3VwX2Rl Y2xfZGllIChub2RlKTsKIAotICAgICAgLyogSWYgdGhlIGNvbnRleHRzIGRp ZmZlciwgd2UgbWF5IG5vdCBiZSB0YWxraW5nIGFib3V0IHRoZSBzYW1lCi0J IHRoaW5nLgotCSA/Pz8gIFdoZW4gaW4gTFRPIHRoZSBESUUgcGFyZW50IGlz IHRoZSAiYWJzdHJhY3QiIGNvcHkgYW5kIHRoZQotCSBjb250ZXh0X2RpZSBp cyB0aGUgc3BlY2lmaWNhdGlvbiAiY29weSIuICBCdXQgdGhpcyB3aG9sZSBi bG9jawotCSBzaG91bGQgZXZlbnR1YWxseSBiZSBubyBsb25nZXIgbmVlZGVk LiAgKi8KLSAgICAgIGlmIChwYXJtX2RpZSAmJiBwYXJtX2RpZS0+ZGllX3Bh cmVudCAhPSBjb250ZXh0X2RpZSAmJiAhaW5fbHRvX3ApCi0JewotCSAgaWYg KCFERUNMX0FCU1RSQUNUX1AgKG5vZGUpKQotCSAgICB7Ci0JICAgICAgLyog VGhpcyBjYW4gaGFwcGVuIHdoZW4gY3JlYXRpbmcgYW4gaW5saW5lZCBpbnN0 YW5jZSwgaW4KLQkJIHdoaWNoIGNhc2Ugd2UgbmVlZCB0byBjcmVhdGUgYSBu ZXcgRElFIHRoYXQgd2lsbCBnZXQKLQkJIGFubm90YXRlZCB3aXRoIERXX0FU X2Fic3RyYWN0X29yaWdpbi4gICovCi0JICAgICAgcGFybV9kaWUgPSBOVUxM OwotCSAgICB9Ci0JICBlbHNlCi0JICAgIGdjY191bnJlYWNoYWJsZSAoKTsK LQl9CisgICAgICB0cmVlIHVsdGltYXRlX29yaWdpbiA9IGRlY2xfdWx0aW1h dGVfb3JpZ2luIChub2RlX29yX29yaWdpbik7CisgICAgICBpZiAobm9kZSB8 fCB1bHRpbWF0ZV9vcmlnaW4pCisJb3JpZ2luID0gdWx0aW1hdGVfb3JpZ2lu OwogCiAgICAgICBpZiAocGFybV9kaWUgJiYgcGFybV9kaWUtPmRpZV9wYXJl bnQgPT0gTlVMTCkKIAl7CkBAIC0yMTM0MywxMCArMjEzMjgsNiBAQCBnZW5f Zm9ybWFsX3BhcmFtZXRlcl9kaWUgKHRyZWUgbm9kZSwgdHJlZSBvcmlnaW4s IGJvb2wgZW1pdF9uYW1lX3AsCiAgIHN3aXRjaCAoVFJFRV9DT0RFX0NMQVNT IChUUkVFX0NPREUgKG5vZGVfb3Jfb3JpZ2luKSkpCiAgICAgewogICAgIGNh c2UgdGNjX2RlY2xhcmF0aW9uOgotICAgICAgdWx0aW1hdGVfb3JpZ2luID0g ZGVjbF91bHRpbWF0ZV9vcmlnaW4gKG5vZGVfb3Jfb3JpZ2luKTsKLSAgICAg IGlmIChub2RlIHx8IHVsdGltYXRlX29yaWdpbikKLQlvcmlnaW4gPSB1bHRp bWF0ZV9vcmlnaW47Ci0KICAgICAgIGlmIChyZXVzaW5nX2RpZSkKIAlnb3Rv IGFkZF9sb2NhdGlvbjsKIAo= --001a1140f29e98a8850558c2208f--