public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: RFA (make_dispatcher_decl): PATCH for c++/83911, ICE with multiversioned constructor
Date: Wed, 14 Mar 2018 20:12:00 -0000	[thread overview]
Message-ID: <CADzB+2kKWMi9NpBq_RKWGqW1WPjg3c-gHY8UWg0TDDp=TAgQPw@mail.gmail.com> (raw)
In-Reply-To: <CADzB+2mJ9yJZ83o5_KhSFkikbqoUrqsjutVcy=+7eToDVkg2_Q@mail.gmail.com>

Ping

On Fri, Mar 2, 2018 at 1:23 PM, Jason Merrill <jason@redhat.com> wrote:
> As I mentioned in the PR, the problem here is that we're replacing a
> constructor with a dispatcher function which doesn't look much like a
> constructor.  This patch adjusts make_dispatcher_decl to make it look
> more like the functions it dispatches to, but other things are certain
> to break for similar reasons down the road.  A proper solution should
> be more transparent, like thunks.
>
> Tested x86_64-pc-linux-gnu.  Does this seem worth applying to fix the
> regression?

  reply	other threads:[~2018-03-14 19:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 18:23 Jason Merrill
2018-03-14 20:12 ` Jason Merrill [this message]
2018-03-15  8:55   ` Richard Biener
2018-03-16 13:50     ` Jason Merrill
2018-05-10 19:34       ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADzB+2kKWMi9NpBq_RKWGqW1WPjg3c-gHY8UWg0TDDp=TAgQPw@mail.gmail.com' \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).