From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22551 invoked by alias); 14 Mar 2018 19:58:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22541 invoked by uid 89); 14 Mar 2018 19:58:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=road X-HELO: mail-it0-f50.google.com Received: from mail-it0-f50.google.com (HELO mail-it0-f50.google.com) (209.85.214.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Mar 2018 19:58:15 +0000 Received: by mail-it0-f50.google.com with SMTP id e98-v6so981894itd.4 for ; Wed, 14 Mar 2018 12:58:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=HwkYaN7Nz7PDrJEVQutpRYRXphIk3fX2SiB3Vh9xXvw=; b=QCC0CIxGOj4POBAyXlO2CylDrviGDf2zqBxephKacDGa9tE0P1/D0VNFh0P/kRoN3s x/+BfHyslBxC9BiSNmFMxEAJvgykOnLPEgQ25fsUPPf1+aL/g3nE772QeY84x9gJ2Kea MxQnjHggS63PxbWbBTB5fBGJM9SanlYXwP+P2b3XffUDTrOc2+WhQLDZQu/pmY/zIRyp 65O46Tekp4geMyaFAfjhSr6T2dXN53YehUrZ8K0V15gVn/3uq7pubozKovk8eR1vwrl8 EYa7VS5h2fs9IgkAFGQ0MuhzCkeaVtgSwQDfPZ6CO5O4YMhVzTB3ZazCeM1EZkUOOJbV F47Q== X-Gm-Message-State: AElRT7HCqDIxC4nwUx31pOxEQcxVHpI2rtB7DBCU9GS6VeaygxWPJ8c8 2vCwZ5Hlkjzge69Vz+sX7ENcd9/SR9zHhdBXQbw/snkV X-Google-Smtp-Source: AG47ELs6VtUvcYq4hM7Y/Ggy1ykbtv7u3waFap3Xk8JXVZpeHLB/bfBKA1vI0+hvp0VJPSyQgdKoS0t9JHbdliz77CI= X-Received: by 2002:a24:2490:: with SMTP id f138-v6mr3303827ita.131.1521057493374; Wed, 14 Mar 2018 12:58:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.30.9 with HTTP; Wed, 14 Mar 2018 12:57:52 -0700 (PDT) In-Reply-To: References: From: Jason Merrill Date: Wed, 14 Mar 2018 20:12:00 -0000 Message-ID: Subject: Re: RFA (make_dispatcher_decl): PATCH for c++/83911, ICE with multiversioned constructor To: gcc-patches List Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00674.txt.bz2 Ping On Fri, Mar 2, 2018 at 1:23 PM, Jason Merrill wrote: > As I mentioned in the PR, the problem here is that we're replacing a > constructor with a dispatcher function which doesn't look much like a > constructor. This patch adjusts make_dispatcher_decl to make it look > more like the functions it dispatches to, but other things are certain > to break for similar reasons down the road. A proper solution should > be more transparent, like thunks. > > Tested x86_64-pc-linux-gnu. Does this seem worth applying to fix the > regression?