From: Jason Merrill <jason@redhat.com>
To: Martin Sebor <msebor@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] replace ICE with error for failed template deduction (PR 84355)
Date: Fri, 16 Feb 2018 19:31:00 -0000 [thread overview]
Message-ID: <CADzB+2kNWEokjK35Xqyodu2-6tSce27-kif=cdH8es65Pn2Ymw@mail.gmail.com> (raw)
In-Reply-To: <CADzB+2nwXVdi3hMBjNNidkERAVox+DoPcq4pe6pL6xkzqbn8CQ@mail.gmail.com>
84015 seems likely to be related.
On Fri, Feb 16, 2018 at 9:04 AM, Jason Merrill <jason@redhat.com> wrote:
> On Thu, Feb 15, 2018 at 6:36 PM, Martin Sebor <msebor@gmail.com> wrote:
>> A failed template deduction in template member of a template
>> triggers an ICE with -std=c++17 due to what seems like
>> a missing handling of invalid input. Replacing
>> the gcc_unreachable() call that causes the ICE with a return
>> statement indicating the deduction failure eliminates the ICE
>> and restores sane diagnostics.
>
> Hmm, we really shouldn't have gotten there; that assert is checking
> that when we see a TEMPLATE_*_PARM node in the template signature, it
> corresponds to one of the actual parms of the template. Sounds like
> something is going wrong in build_deduction_guide.
>
> Jason
next prev parent reply other threads:[~2018-02-16 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 23:36 Martin Sebor
2018-02-16 14:04 ` Jason Merrill
2018-02-16 19:31 ` Jason Merrill [this message]
2018-02-16 21:33 ` Martin Sebor
2018-02-19 4:39 ` Jason Merrill
2018-02-24 2:33 ` Jason Merrill
2018-03-06 0:05 ` Martin Sebor
2018-03-12 14:40 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2kNWEokjK35Xqyodu2-6tSce27-kif=cdH8es65Pn2Ymw@mail.gmail.com' \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).