From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PATCH to fix bogus -Wimplicit-fallthrough warning (PR c++/77803)
Date: Sun, 02 Oct 2016 18:42:00 -0000 [thread overview]
Message-ID: <CADzB+2ka5jbsLNY_cAp_6-sK6NcLjOF47MpMor3BXKVRRfHMEw@mail.gmail.com> (raw)
In-Reply-To: <20161001141721.GK3223@redhat.com>
On Sat, Oct 1, 2016 at 10:17 AM, Marek Polacek <polacek@redhat.com> wrote:
> + && (last_eval == NULL
> + || !gimple_call_internal_p (last_eval, IFN_FALLTHROUGH))
Isn't this still assuming that non-null last_eval must be a gcall, so
we'll get a checking ICE if it's something else?
Jason
next prev parent reply other threads:[~2016-10-02 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 21:39 Marek Polacek
2016-10-01 5:18 ` Markus Trippelsdorf
2016-10-01 14:42 ` Marek Polacek
2016-10-02 18:42 ` Jason Merrill [this message]
2016-10-02 21:57 ` Jakub Jelinek
2016-10-07 8:45 ` Marek Polacek
2016-10-07 9:39 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2ka5jbsLNY_cAp_6-sK6NcLjOF47MpMor3BXKVRRfHMEw@mail.gmail.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=markus@trippelsdorf.de \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).