From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124638 invoked by alias); 20 Jun 2017 19:12:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 124444 invoked by uid 89); 20 Jun 2017 19:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=our X-HELO: mail-it0-f50.google.com Received: from mail-it0-f50.google.com (HELO mail-it0-f50.google.com) (209.85.214.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 19:12:18 +0000 Received: by mail-it0-f50.google.com with SMTP id m47so19863718iti.1 for ; Tue, 20 Jun 2017 12:12:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hsoM3jSI+dyTJ/XzOKFpNCPeowzoF1gXso/NSSBkAb4=; b=QbMvACuEuQKjYZTACUTdm/Chvd+RvcDz0QMcbDStJ+ppMlMa555NsDvQwK3zTm9WX/ mizw7zByCAQIG6ppWXCjKV0V0+r0erUtfQBDVtL70/xXE/IyUxjDkIAbr6rsFM2sXHLt Xk2m5qNJHn350r2JIUYhYyUQpEKP5WHNiUTHqcLVFl154jaduNuCa0v3g4IevuCzZrnN 9l001suG0iEYVS694gxXyt2JRwy1WIJhNzu4DksXRxmDpek4YcADrLjyt5ZZocxio1tE cFjpRr3ZZIKnLRRqg5hzl7C8D8RbIxYdq2h//fyPy3urYE3lwfkdZEEeRZQjA/USx8Mg UkZQ== X-Gm-Message-State: AKS2vOzDzkszOuDeE7B0iPkzeHl+FH2fG2kq6YZ1cGicPdon5nAaEqyf Xatw6rllVVkTgaMNpF1qmomeW+Bovwyy X-Received: by 10.36.76.22 with SMTP id a22mr1689829itb.83.1497985937069; Tue, 20 Jun 2017 12:12:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.20.139 with HTTP; Tue, 20 Jun 2017 12:11:56 -0700 (PDT) In-Reply-To: <1497985575.7551.179.camel@redhat.com> References: <1496689294-11629-1-git-send-email-dmalcolm@redhat.com> <1497973859.7551.171.camel@redhat.com> <1497985575.7551.179.camel@redhat.com> From: Jason Merrill Date: Tue, 20 Jun 2017 19:12:00 -0000 Message-ID: Subject: Re: [PING] C++ Re: [PATCH] C/C++: fix quoting of "aka" typedef information (PR 62170) To: David Malcolm Cc: gcc-patches List , Volker Reichelt Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01501.txt.bz2 On Tue, Jun 20, 2017 at 3:06 PM, David Malcolm wrote: > It's not clear to me what the issue alluded to with negative > obstack_blank is, but I chose to follow the above docs and use > obstack_blank_fast; am testing an updated patch in which the above line > now looks like: > > obstack_blank_fast (ob, -(type_start + type_len)); > > Is the patch OK with that change? (assuming bootstrap®rtesting > pass), or should I re-post? OK with that change. > On a related matter, this patch conflicts with Volker's patch here: > > https://gcc.gnu.org/ml/gcc-patches/2017-04/msg01576.html > > in which he removes the trailing "{enum}" info (and hence all of our > changes to the testsuite conflict between the two patches...) > > Do you have any thoughts on that other patch? [Ccing Volker] That patch makes sense to me; I prefer "enum E" to "E {enum}". Jason