public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
	Nathan Sidwell <nathan@acm.org>
Subject: Re: [PATCH] [PR c++/84943] allow folding of array indexing indirect_ref
Date: Fri, 23 Mar 2018 22:04:00 -0000	[thread overview]
Message-ID: <CADzB+2koRicaeyWMKYu9wpNbFwGHK9qTz2hrTfRbi75r9OeYkQ@mail.gmail.com> (raw)
In-Reply-To: <CADzB+2kPvPute770350hRx8qACVyvE7ni+-aFLPuxBWEZShuaw@mail.gmail.com>

On Fri, Mar 23, 2018 at 4:55 PM, Jason Merrill <jason@redhat.com> wrote:
> On Fri, Mar 23, 2018 at 12:44 PM, Jason Merrill <jason@redhat.com> wrote:
>> Seems like cp_fold should update CALL_EXPR_FN with "callee" if non-null.
>
> Did you try this?  That should avoid it being ADDR_EXPR of a decl.

Oh, I was assuming the ICE was in the middle-end, but it's in
build_call_a.  And it looks like the problem isn't that it's an
ADDR_EXPR of a decl, but that the function isn't marked TREE_USED.

Jason

  reply	other threads:[~2018-03-23 20:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 23:03 Alexandre Oliva
2018-03-23 13:12 ` Jason Merrill
2018-03-23 16:19   ` Alexandre Oliva
2018-03-23 16:45     ` Jason Merrill
2018-03-23 20:59       ` Jason Merrill
2018-03-23 22:04         ` Jason Merrill [this message]
2018-03-28  6:31           ` Alexandre Oliva
2018-03-28 19:21             ` Jason Merrill
2018-03-30  1:07               ` Alexandre Oliva
2018-03-30  2:31                 ` Alexandre Oliva
2018-03-30  7:49                   ` Alexandre Oliva
2018-03-30 14:46                     ` Jason Merrill
2018-03-31  8:23                       ` Alexandre Oliva
2018-04-03  1:17                         ` Jason Merrill
2018-04-03  7:44                           ` Alexandre Oliva
2018-04-03 15:48                             ` Jason Merrill
2018-04-03 15:48                               ` Jason Merrill
2018-04-04  2:41                                 ` Alexandre Oliva
2018-03-23 20:55   ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADzB+2koRicaeyWMKYu9wpNbFwGHK9qTz2hrTfRbi75r9OeYkQ@mail.gmail.com \
    --to=jason@redhat.com \
    --cc=aoliva@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).