public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Nathan Sidwell <nathan@acm.org>
Subject: Re: [C++ Patch] PR 84423 ("[6/7/8/9 Regression] [concepts] ICE with invalid using declaration")
Date: Fri, 28 Sep 2018 17:53:00 -0000	[thread overview]
Message-ID: <CADzB+2kqCdAf679uR8iqP3RbHyzK3TtbUBn6Ah_7ZhF7hR++3w@mail.gmail.com> (raw)
In-Reply-To: <61471b27-ea85-8fc2-a7e3-178547e518d6@oracle.com>

On Fri, Sep 28, 2018 at 12:42 PM, Paolo Carlini
<paolo.carlini@oracle.com> wrote:
> Hi,
>
> the primary issue here is a rather straightforward error-recovery, where,
> after a sensible (but see below) error message we ICE in
> get_underlying_template - called by convert_template_argument - because we
> don't handle correctly error_mark_node as TREE_TYPE, as set in
> grokdeclarator. While working on it I noticed that the error message emitted
> by grokdeclarator seems suboptimal, because, per 10.1.3/2, we correctly
> handle the alias declaration like a typedef but, I believe, we don't want to
> just say *typedef* in the error message: luckily the infrastructure to be
> more accurate is fully available, because we need it to set
> TYPE_DECL_ALIAS_P anyway.

OK, though as long as you're messing with this error you might want to
improve its location as well.

Jason

  reply	other threads:[~2018-09-28 17:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 16:43 Paolo Carlini
2018-09-28 17:53 ` Jason Merrill [this message]
2018-09-28 20:26   ` Paolo Carlini
2018-09-29 20:14     ` Paolo Carlini
2018-10-09 11:37       ` [C++ Patch PING] " Paolo Carlini
2018-10-09 16:51       ` Jason Merrill
2018-10-09 19:27         ` Paolo Carlini
2018-10-09 20:34           ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADzB+2kqCdAf679uR8iqP3RbHyzK3TtbUBn6Ah_7ZhF7hR++3w@mail.gmail.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nathan@acm.org \
    --cc=paolo.carlini@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).