From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-474497-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 50431 invoked by alias); 9 Mar 2018 15:11:28 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 49094 invoked by uid 89); 9 Mar 2018 15:11:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=day
X-HELO: mail-it0-f43.google.com
Received: from mail-it0-f43.google.com (HELO mail-it0-f43.google.com) (209.85.214.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 15:11:26 +0000
Received: by mail-it0-f43.google.com with SMTP id e64-v6so3175518ita.5        for <gcc-patches@gcc.gnu.org>; Fri, 09 Mar 2018 07:11:26 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=/hcBRPSSyB9vWkVQlcnZwvf2iv7qAcE9zIbbUi0kAPk=;        b=R4Pr0+DDF63bMQ/21lVi2m+N8HXCuZzasSHLrVw60fWjBYehgUM3qLDkVpEKyXZqVf         H4U9M0KTH5qWIkiz1cZ4arTznT7zh5c0Kz62QNzUnb5JLYOyF+lE0kX75HeLqGnfzMc+         oPcOEvRvN1fJ2DgqUdWXRYij0qUIIH4hw8Yx7cc6Bngh5AhHOM6W/tAQZHJfmnywEwc7         6dmVx0O9LVWfkv2Ge/wBijUBJ2GMJppLWvg4YaSrbfYwraJUPYqphCULWf6+Qh1+JuAx         YoVbiblk+Z4oUEjJEcbyfanOUOPuoaLPw7bfTP/aQGILGK+qR6vPGVRTZ/Zuc9eJAZx7         w3uA==
X-Gm-Message-State: AElRT7EP2GpKYhxE5qc1hrJk+YyZFvUtcDflXlZ9b6sFdWoyZBOkfqjx	C7D1diQiCQqCsM04CWMR8ciWSeOvWNhLNTJg0uRg3A==
X-Google-Smtp-Source: AG47ELuf7p19F8vFKufM1kMywik0cCQHWXQvOh5ZxtYFmLXqRoOLMD15yHyMLl3Y5giYzJkBO59E+ans5QVdOR8c5dk=
X-Received: by 10.36.185.24 with SMTP id w24mr3808460ite.127.1520608284586; Fri, 09 Mar 2018 07:11:24 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.30.9 with HTTP; Fri, 9 Mar 2018 07:11:04 -0800 (PST)
In-Reply-To: <20180309090245.GA5867@tucnak>
References: <orfu5ix62w.fsf@lxoliva.fsfla.org> <orwoypspe0.fsf@lxoliva.fsfla.org> <20180306072848.GV5867@tucnak> <orh8prvsxr.fsf@lxoliva.fsfla.org> <20180308093928.GP5867@tucnak> <ormuzhab1d.fsf@lxoliva.fsfla.org> <20180309090245.GA5867@tucnak>
From: Jason Merrill <jason@redhat.com>
Date: Fri, 09 Mar 2018 15:11:00 -0000
Message-ID: <CADzB+2m6f4RM+C8tBwCDvCcjJYaTHW_9zWbVLRhwMRgHnDCu2A@mail.gmail.com>
Subject: Re: [PR84620] output symbolic entry_view as data2, not addr
To: Jakub Jelinek <jakub@redhat.com>
Cc: Alexandre Oliva <aoliva@redhat.com>, gcc-patches List <gcc-patches@gcc.gnu.org>, 	Mark Wielaard <mjw@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2018-03/txt/msg00433.txt.bz2

On Fri, Mar 9, 2018 at 4:02 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Mar 09, 2018 at 05:49:34AM -0300, Alexandre Oliva wrote:
>> @@ -27699,6 +27780,9 @@ dwarf2out_source_line (unsigned int line, unsigned int column,
>>       {
>>         if (!RESETTING_VIEW_P (table->view))
>>           {
>> +           table->symviews_since_reset++;
>> +           if (table->symviews_since_reset > symview_upper_bound)
>> +             symview_upper_bound = table->symviews_since_reset;
>
> You could have used
>               symview_upper_bound
>                 = MAX (symview_upper_bound, table->symviews_since_reset);
>
> Also, I'd say there should be
>   symview_upper_bound = 0;
> in dwarf2out_c_finalize for better behavior of GCC JIT.
>
> Otherwise LGTM, but please give Jason a day to comment on.

OK.

Jason