From: Jason Merrill <jason@redhat.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: C++ PATCHes to dependent template-id parsing
Date: Thu, 06 Jul 2017 18:26:00 -0000 [thread overview]
Message-ID: <CADzB+2m7KRUe2ME-rQoufhbKj1xxzvBF24DkyOZu7bA8rw7W1A@mail.gmail.com> (raw)
In-Reply-To: <CADzB+2nH2oFtMVpnRA2Y4TZLAKc31qhOfF14+548yzmoiOa0Mg@mail.gmail.com>
On Wed, Jun 28, 2017 at 3:38 PM, Jason Merrill <jason@redhat.com> wrote:
> 81204 is a regression whereby previously we would accidentally get the
> parsing of res.template set<I> right because when we did the lookup in
> the surrounding context, we found the function template and then
> ignored it. This patch partially reverts the handling of .template to
> how it was in GCC 6.
>
> But this bug is really a special case of 54769; we should be treating
> that name as dependent and not doing a lookup in the enclosing context
> at all. As I noted in discussion of 55576, we need to pass
> template_keyword_p into nested_name_specifier_opt. So this patch does
> that, and also adjusts cp_parser_template_name to consider object
> scope.
I'm reverting the 81204 patch for both 7 and 8, as it is wrong under
DR 141 and the 54769 patch is better.
Jason
prev parent reply other threads:[~2017-07-06 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 19:39 Jason Merrill
2017-07-06 18:26 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2m7KRUe2ME-rQoufhbKj1xxzvBF24DkyOZu7bA8rw7W1A@mail.gmail.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).