From: Jason Merrill <jason@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Jonathan Wakely <jwakely@redhat.com>,
libstdc++@gcc.gnu.org,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: RFA (libstdc++): PATCH to implement C++17 over-aligned new
Date: Tue, 13 Sep 2016 12:54:00 -0000 [thread overview]
Message-ID: <CADzB+2m99CQABVSVmm3H8ZYpF1sNBkwxmrZnHVtgAeE49KEpfQ@mail.gmail.com> (raw)
In-Reply-To: <mvm60q0c74b.fsf@hawking.suse.de>
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
Does this help?
On Tue, Sep 13, 2016 at 8:32 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Sep 12 2016, Jason Merrill <jason@redhat.com> wrote:
>
>> I'm checking in this patch, which should fix the remaining issues:
>
> Unfortunatly that breaks a few other tests:
>
> FAIL: g++.dg/cpp0x/alignas5.C -std=c++11 (test for excess errors)
> FAIL: g++.dg/cpp0x/alignas5.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/cpp0x/gen-attrs-21.C -std=c++11 (test for excess errors)
> FAIL: g++.dg/cpp0x/gen-attrs-21.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/cpp0x/gen-attrs-51.C -std=c++11 (test for excess errors)
> FAIL: g++.dg/cpp0x/gen-attrs-51.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/cpp0x/gen-attrs-54.C -std=c++11 (test for excess errors)
> FAIL: g++.dg/cpp0x/gen-attrs-54.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/ipa/devirt-33.C (test for excess errors)
> FAIL: g++.dg/lookup/name-clash11.C -std=gnu++11 (test for excess errors)
> FAIL: g++.dg/lookup/name-clash11.C -std=gnu++14 (test for excess errors)
> FAIL: g++.dg/pr67989.C (test for excess errors)
>
> They all fail with "warning: requested alignment %d is larger than 2
> [-Wattributes]".
>
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
[-- Attachment #2: uhwi.diff --]
[-- Type: text/plain, Size: 1690 bytes --]
commit 113f925a58a37cb8f18cd9c7aeeb4c03f5fc6afe
Author: Jason Merrill <jason@redhat.com>
Date: Tue Sep 13 08:46:06 2016 -0400
* c-common.c (check_cxx_fundamental_alignment_constraints): Use
unsigned HOST_WIDE_INT.
diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c
index 9b5e016..e3dc0f5 100644
--- a/gcc/c-family/c-common.c
+++ b/gcc/c-family/c-common.c
@@ -7861,8 +7861,9 @@ check_cxx_fundamental_alignment_constraints (tree node,
int flags)
{
bool alignment_too_large_p = false;
- unsigned requested_alignment = (1U << align_log) * BITS_PER_UNIT;
- unsigned max_align = 0;
+ unsigned HOST_WIDE_INT requested_alignment
+ = (unsigned HOST_WIDE_INT)BITS_PER_UNIT << align_log;
+ unsigned HOST_WIDE_INT max_align = 0;
if ((!(flags & ATTR_FLAG_CXX11) && !warn_cxx_compat)
|| (node == NULL_TREE || node == error_mark_node))
@@ -7910,14 +7911,15 @@ check_cxx_fundamental_alignment_constraints (tree node,
largest alignment the object file can represent, but a type that is
only allocated dynamically could request even larger alignment. So
only limit type alignment to what TYPE_ALIGN can represent. */
- if (requested_alignment > (max_align = 8U << 28))
+ if (requested_alignment > (max_align = (unsigned HOST_WIDE_INT)8 << 28))
alignment_too_large_p = true;
}
if (alignment_too_large_p)
pedwarn (input_location, OPT_Wattributes,
"requested alignment %d is larger than %d",
- requested_alignment / BITS_PER_UNIT, max_align / BITS_PER_UNIT);
+ int(requested_alignment / BITS_PER_UNIT),
+ int(max_align / BITS_PER_UNIT));
return !alignment_too_large_p;
}
next prev parent reply other threads:[~2016-09-13 12:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 7:10 Jason Merrill
2016-09-08 8:32 ` Marc Glisse
2016-09-08 11:18 ` Jonathan Wakely
2016-09-09 21:40 ` Jason Merrill
2016-09-10 7:03 ` Christophe Lyon
2016-09-10 10:14 ` Marc Glisse
2016-09-10 10:35 ` Jonathan Wakely
2016-09-11 9:14 ` Christophe Lyon
2016-09-11 9:55 ` Jonathan Wakely
2016-09-11 9:56 ` Jonathan Wakely
2016-09-11 10:20 ` Christophe Lyon
2016-09-11 12:09 ` Jonathan Wakely
2016-09-13 13:04 ` Szabolcs Nagy
2016-09-10 10:14 ` Jonathan Wakely
2016-09-11 7:09 ` Andreas Schwab
2016-09-12 21:13 ` Jason Merrill
2016-09-13 8:41 ` Christophe Lyon
2016-09-13 12:37 ` Andreas Schwab
2016-09-13 12:54 ` Jason Merrill [this message]
2016-09-13 13:18 ` Andreas Schwab
2016-09-13 13:21 ` Jason Merrill
2016-09-14 12:13 ` Andreas Schwab
2016-09-14 16:11 ` Christophe Lyon
2016-09-14 16:37 ` Jason Merrill
2016-09-15 10:00 ` Rainer Orth
2016-09-15 12:23 ` Christophe Lyon
2016-09-15 20:09 ` Jason Merrill
2016-09-16 7:12 ` Rainer Orth
2016-09-16 8:15 ` Christophe Lyon
2016-09-16 9:14 ` Jonathan Wakely
2016-09-16 9:51 ` Marc Glisse
2016-09-16 11:12 ` Jonathan Wakely
2016-09-16 13:13 ` Jonathan Wakely
2016-09-16 13:17 ` Rainer Orth
2016-09-16 18:19 ` Jonathan Wakely
2016-09-12 14:15 ` Rainer Orth
2016-09-12 16:19 ` Jonathan Wakely
2016-09-12 18:57 ` Jason Merrill
2016-09-14 12:11 ` Rainer Orth
2016-09-08 11:00 ` Jonathan Wakely
2017-11-24 14:26 ` Marc Glisse
2017-11-29 21:23 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2m99CQABVSVmm3H8ZYpF1sNBkwxmrZnHVtgAeE49KEpfQ@mail.gmail.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).