From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-468462-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 74419 invoked by alias); 4 Dec 2017 20:35:18 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 74409 invoked by uid 89); 4 Dec 2017 20:35:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=reserved, Hx-languages-length:448
X-HELO: mail-it0-f52.google.com
Received: from mail-it0-f52.google.com (HELO mail-it0-f52.google.com) (209.85.214.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Dec 2017 20:35:15 +0000
Received: by mail-it0-f52.google.com with SMTP id t1so16022607ite.5        for <gcc-patches@gcc.gnu.org>; Mon, 04 Dec 2017 12:35:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:in-reply-to:references:from:date         :message-id:subject:to:cc;        bh=Xxb18cqiHIk2H8CYfR9j4GIlj48WsbXRS+moVLVqrog=;        b=DYiuKSpYSwLtqk32eEvhB1Lzc4WjpbZkHPgiaRtEJAAIGjvUW1wlgdEFnagWgiQLms         eHfL3/mW68V0EW6KD/UxB1i+OhKn4bezVD769kSlxxrBteTvzVtedBpw66nAMef6+7ca         8JamSkzfEFXovKearYZXW5sNKXrDNV88BWrQ1MLflEZNs/BPfWb/Zgzlw6mStx4dTcjH         ocRnexx/pMSCRJAnXURemJ+J/C9/mlSwPcX/IUAQfjM0d8qe9Qq8tkyLGhTCLYxMappz         BHVmMgFTf/nC2THoFz1jp5GciyeTaAtKUjiMVp8TYMeku+VGuDZO9yv3GgH5hwZDKFdN         NL3w==
X-Gm-Message-State: AKGB3mLJUTK+O/Xw3f/Upb4nH0DhDiwqJyot52Uku0CYZqb8ANBXjxvx	8Db59ckEmEtjrB+xBVXaH1RBR9ibmth73YI+fKwqsw==
X-Google-Smtp-Source: AGs4zMab7lCDRy3y5lxcqWvmutuM0pH+ItD2AHZ12Tuf9O2+p259Veue0BcjYt/Xs6fWrWNkg+iJK3ZklxsHrMprmL0=
X-Received: by 10.36.93.5 with SMTP id w5mr15208028ita.124.1512419714150; Mon, 04 Dec 2017 12:35:14 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.171.134 with HTTP; Mon, 4 Dec 2017 12:34:53 -0800 (PST)
In-Reply-To: <1512406850-21612-3-git-send-email-dmalcolm@redhat.com>
References: <1512406850-21612-1-git-send-email-dmalcolm@redhat.com> <1512406850-21612-3-git-send-email-dmalcolm@redhat.com>
From: Jason Merrill <jason@redhat.com>
Date: Mon, 04 Dec 2017 20:35:00 -0000
Message-ID: <CADzB+2mBh0XFT-7w6Xx-mbVz2K6akNr9R63zXffVAcML-qGNAA@mail.gmail.com>
Subject: Re: [PATCH 2/2] v3: C/C++: don't suggest implementation names as spelling fixes (PR c/83236)
To: David Malcolm <dmalcolm@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>, gcc-patches List <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-IsSubscribed: yes
X-SW-Source: 2017-12/txt/msg00165.txt.bz2

On Mon, Dec 4, 2017 at 12:00 PM, David Malcolm <dmalcolm@redhat.com> wrote:
> * don't filter suggestions if the name name being looked up
> is itself reserved for implementation

I wonder if we want to avoid filtering if the name being looked up
starts with a single _, on the theory that the user meant to write __.

Other than that, looks good.

Jason