From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: "Andre Vieira (lists)" <Andre.SimoesDiasVieira@arm.com>,
Yao Qi <qiyaoltc@gmail.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix dwarf2out regression from C++17 inline variables changes
Date: Thu, 27 Oct 2016 13:55:00 -0000 [thread overview]
Message-ID: <CADzB+2mHdfimA9GYYraY0aSpL1us8Z2TUKcBMde7rnEOs_0cnA@mail.gmail.com> (raw)
In-Reply-To: <20161025195614.GB3541@tucnak.redhat.com>
OK.
On Tue, Oct 25, 2016 at 3:56 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Tue, Oct 25, 2016 at 08:06:12PM +0200, Jakub Jelinek wrote:
>> I think this patch should fix it, will bootstrap/regtest it now:
>>
>> 2016-10-25 Jakub Jelinek <jakub@redhat.com>
>>
>> * dwarf2out.c (gen_member_die): Only reparent_child instead of
>> splice_child_die if child doesn't have DW_AT_specification attribute.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux now, with this
> patch C++14 static data members are treated in debug info as they were in
> the past, just C++17 static constexpr data mambers or other static inline
> data members are treated the new way (definition in DW_TAG_member).
>
> Ok for trunk?
>
>> --- gcc/dwarf2out.c.jj 2016-10-25 19:49:28.000000000 +0200
>> +++ gcc/dwarf2out.c 2016-10-25 20:02:33.264639847 +0200
>> @@ -22624,7 +22624,8 @@ gen_member_die (tree type, dw_die_ref co
>> /* Handle inline static data members, which only have in-class
>> declarations. */
>> if (child->die_tag == DW_TAG_variable
>> - && child->die_parent == comp_unit_die ())
>> + && child->die_parent == comp_unit_die ()
>> + && get_AT (child, DW_AT_specification) == NULL)
>> {
>> reparent_child (child, context_die);
>> child->die_tag = DW_TAG_member;
>>
>
> Jakub
next prev parent reply other threads:[~2016-10-27 13:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 13:39 [C++ PATCH] RFC: implement P0386R2 - C++17 inline variables Jakub Jelinek
2016-10-13 19:34 ` Jason Merrill
2016-10-20 16:21 ` Andre Vieira (lists)
2016-10-21 14:57 ` Yao Qi
2016-10-21 15:15 ` Jakub Jelinek
2016-10-25 15:05 ` Andre Vieira (lists)
2016-10-25 18:06 ` Jakub Jelinek
2016-10-25 19:56 ` [PATCH] Fix dwarf2out regression from C++17 inline variables changes Jakub Jelinek
2016-10-27 13:55 ` Jason Merrill [this message]
2016-10-26 10:07 ` [C++ PATCH] RFC: implement P0386R2 - C++17 inline variables Yao Qi
2016-10-20 10:51 ` Eric Botcazou
2016-10-20 11:02 ` Jakub Jelinek
2016-10-20 11:22 ` Eric Botcazou
2016-10-20 16:02 ` Jakub Jelinek
2016-10-20 16:23 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2mHdfimA9GYYraY0aSpL1us8Z2TUKcBMde7rnEOs_0cnA@mail.gmail.com \
--to=jason@redhat.com \
--cc=Andre.SimoesDiasVieira@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).