From: Jason Merrill <jason@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH,DWARF,v2] AIX dwarf2out label fix
Date: Thu, 01 Jun 2017 20:16:00 -0000 [thread overview]
Message-ID: <CADzB+2mV7mW6FH7CxTtDkQw49ev8YAF_0SSiKR9tLjKZfc277w@mail.gmail.com> (raw)
In-Reply-To: <CAGWvnynRE2cEdAkeqtva3G=ZhedoQSc5uzV7D8_0_J=OC_9gEQ@mail.gmail.com>
On Thu, Jun 1, 2017 at 3:27 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
> On Thu, Jun 1, 2017 at 3:03 PM, Jason Merrill <jason@redhat.com> wrote:
>> On 05/18/2017 06:00 AM, David Edelsohn wrote:
>>>
>>> This version adds a macro DWARF_INITIAL_LENGTH_SIZE_STR based on
>>> DWARF_OFFSET_SIZE to define the string expression to append to the
>>> label to correct the offset.
>>>
>>> Because AIX Assembler inserts the section length, the section label
>>> generated by GCC points to the wrong location and must be adjusted
>>> when referenced in DW_AT_stmt_list.
>>>
>>> + char dl_section_label[MAX_ARTIFICIAL_LABEL_BYTES];
>>
>> It seems inaccurate to call this variable "label" when it's a label name
>> minus offset. Maybe dl_section_ref?
>
> Hi, Jason
>
> Thanks for taking a look at this!
>
> Any naming suggestions are appreciated -- I was trying to choose a
> short variable name. dl_section_ref is fine with me.
Let's go with that, then. OK with that change.
Jason
prev parent reply other threads:[~2017-06-01 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 10:09 David Edelsohn
2017-06-01 19:03 ` Jason Merrill
2017-06-01 19:27 ` David Edelsohn
2017-06-01 20:16 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2mV7mW6FH7CxTtDkQw49ev8YAF_0SSiKR9tLjKZfc277w@mail.gmail.com \
--to=jason@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).