From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128816 invoked by alias); 24 May 2017 19:03:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 127936 invoked by uid 89); 24 May 2017 19:03:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=U*tbsaunde, tbsaunde@tbsaunde.org, tbsaundetbsaundeorg, D*tbsaunde.org X-HELO: mail-io0-f176.google.com Received: from mail-io0-f176.google.com (HELO mail-io0-f176.google.com) (209.85.223.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 May 2017 19:03:10 +0000 Received: by mail-io0-f176.google.com with SMTP id p24so123819509ioi.0 for ; Wed, 24 May 2017 12:03:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EXpfr8ekbjBNJdA2T2tfmAmo7+7w37bkZafuGM4SGbQ=; b=oxrJAA75lnBZ74DbO7vEJg2qe+HIL5s7tU60qMSpCuR7CwEUXEWHX9rSHArGK/HTrr kFy0WVtLfqTebFuOdIFsEQ9+KbKzbNq3fzPe8Zp6arQYBFvilRgRVblKeqp5WJN/bElQ T8d7GuMjs+9/6PhpW1aGoA5Qzy73D3Sr/z/MAZn8jXl9FCiba8c+71F3NGQRe2iGhuyS E2iKFLt3WysuVp61ilBqnr7pn5KtroHaGIfC+ExGSmprMYp7tmcL2XnhTeKB4e9hYZs1 bACeUyb8iihx2PTtreIwSCsykbAK4HrVvCP2tsZ6jShJ81lspGyo0BaEnq3+psenvpYE NDiQ== X-Gm-Message-State: AODbwcCLTMwLFeYoXRpUFx2aBD920meAUDB2htyavZxGQFf8uhzVFSSX yNvKtzOZSudr8wdsmMsFwbgcXM/o+8MU X-Received: by 10.107.6.218 with SMTP id f87mr33166958ioi.2.1495652592287; Wed, 24 May 2017 12:03:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.6.226 with HTTP; Wed, 24 May 2017 12:02:51 -0700 (PDT) In-Reply-To: <20170524110418.i5jbqqqlj5lltejr@ball> References: <381BC021-5087-40F5-B517-8EB0239900B2@suse.de> <1910af49-f2eb-60ce-68a8-52a5de4c0205@acm.org> <20170524110418.i5jbqqqlj5lltejr@ball> From: Jason Merrill Date: Wed, 24 May 2017 19:12:00 -0000 Message-ID: Subject: Re: [PATCH] Try harder to fix recently introduced crashes in ggc_collect To: Trevor Saunders Cc: Nathan Sidwell , Bernd Edlinger , Richard Biener , "gcc-patches@gcc.gnu.org" , Jakub Jelinek , Jeff Law Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg01899.txt.bz2 On Wed, May 24, 2017 at 7:04 AM, Trevor Saunders wrote: > On Fri, May 19, 2017 at 10:10:23AM -0400, Nathan Sidwell wrote: >> On 05/19/2017 10:05 AM, Bernd Edlinger wrote: >> >> > hwi cannot be the root cause of the problem, >> > because it can only be long_integer_type_node >> > or long_long_integer_type_node, otherwise >> > an error would be triggered. >> >> that's the error I made with the static fns. PCH moves things around, so >> anything that can be streamed via PCH must be GTY marked. Also, I'm not >> sure if the current GC is a compacting GC (given PCH can compact things?) > > other than pch which I'm not sure about I'm pretty sure its not, and is > just basic mark and sweep. > > That said if modules can get merged for gcc 8 I'm very tempted to rm pch > now. I think it would be premature to remove PCH from GCC 8. The Modules specification is far from stable, and moving current PCH users to Modules will take significant work (at least if we get something like the current draft rather than the relatively transparent scheme that clang uses). Jason