From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122392 invoked by alias); 1 May 2018 12:53:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 122380 invoked by uid 89); 1 May 2018 12:53:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f46.google.com Received: from mail-oi0-f46.google.com (HELO mail-oi0-f46.google.com) (209.85.218.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 May 2018 12:53:04 +0000 Received: by mail-oi0-f46.google.com with SMTP id p62-v6so9970336oie.10 for ; Tue, 01 May 2018 05:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=V5MHpAZuq4CoBwUanQG/pDfO1cMcBL1xNviBJ/BdbO4=; b=lT+uNQ7OqVx807M430Q8fHxB6irEWAy9rug0EzR0JjV0RrDWg0BaCZOFYHOi/9Xac+ KitIMJAvN4GGVOnnH10P2n3l/QlRobpKLC6wlKv+YML7rQ6h6N+5q3Xtq7legQTjtpqI GaBftfFYpMfVode2K5BKEfbqUaUOqtO1yFrdirj+e0UEiHwZT4RGFiQhVx79FEhm+PF3 LD0uFx3KmHH5dYvtYnOzyFvXy+HBXmHD0zHA30zNONXJKcFE0vmv3xGXz5kMYN7fJ6+0 7wM7puVuE0k5kZeab5kytU/TlHbqg54qWuzolK1XbrTJoDP+vb03CnROqOzl+oFS6PmW 06PQ== X-Gm-Message-State: ALQs6tA8BmGKlSm+mIFp3wNTKXz4gcQWZOIbwh75ujaW4T9wwz7J1eD4 hg/txRoosdsVHmN9HzFsgO6jIgXk+RboywZqdhICZMl9 X-Google-Smtp-Source: AB8JxZqAuGzhHK7em+jSOIv7VP4sBNv+p343/TRH/O8XcHlt6MOI/Had++oJ8cAyMR0LlgC+Yqgxswg0T7XRPoYGkto= X-Received: by 2002:aca:5b89:: with SMTP id p131-v6mr3067159oib.8.1525179182855; Tue, 01 May 2018 05:53:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.201.13.229 with HTTP; Tue, 1 May 2018 05:52:42 -0700 (PDT) From: Jason Merrill Date: Tue, 01 May 2018 12:53:00 -0000 Message-ID: Subject: C++ PATCH for c++/85580, wrong name class error with extern "C" locals To: gcc-patches List Cc: Nathan Sidwell , Jakub Jelinek Content-Type: multipart/mixed; boundary="0000000000006a6161056b247361" X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00013.txt.bz2 --0000000000006a6161056b247361 Content-Type: text/plain; charset="UTF-8" Content-length: 294 It wasn't a problem before that we didn't check for namespace scope, because we were only looking at functions. Now that we look at variables as well, we need to consider their scope. Tested x86_64-pc-linux-gnu, applying to trunk. Jakub, this looks like a P1, should it go into 8.1 as well? --0000000000006a6161056b247361 Content-Type: text/x-patch; charset="US-ASCII"; name="85580.diff" Content-Disposition: attachment; filename="85580.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jgnnr8ty0 Content-length: 1647 Y29tbWl0IGE5N2FmODQxNzE4Nzc5YjYxNWJkMGE1OTljYWM5NTYzOTZjOGM4 NWEKQXV0aG9yOiBKYXNvbiBNZXJyaWxsIDxqYXNvbkByZWRoYXQuY29tPgpE YXRlOiAgIE1vbiBBcHIgMzAgMTc6Mzc6MjAgMjAxOCAtMDQwMAoKICAgICAg ICAgICAgUFIgYysrLzg1NTgwIC0gZXh0ZXJuICJDIiBhbmQgbG9jYWwgdmFy aWFibGVzCiAgICAKICAgICAgICAgICAgKiBuYW1lLWxvb2t1cC5jIChjaGVj a19leHRlcm5fY19jb25mbGljdCk6IElnbm9yZSBsb2NhbCBkZWNscy4KCmRp ZmYgLS1naXQgYS9nY2MvY3AvbmFtZS1sb29rdXAuYyBiL2djYy9jcC9uYW1l LWxvb2t1cC5jCmluZGV4IDJhZjI0NjI4MjVjLi42NGM3YjZmMDA2ZSAxMDA2 NDQKLS0tIGEvZ2NjL2NwL25hbWUtbG9va3VwLmMKKysrIGIvZ2NjL2NwL25h bWUtbG9va3VwLmMKQEAgLTI1MjcsNiArMjUyNywxMCBAQCBjaGVja19leHRl cm5fY19jb25mbGljdCAodHJlZSBkZWNsKQogICBpZiAoREVDTF9BUlRJRklD SUFMIChkZWNsKSB8fCBERUNMX0lOX1NZU1RFTV9IRUFERVIgKGRlY2wpKQog ICAgIHJldHVybjsKIAorICAvKiBUaGlzIG9ubHkgYXBwbGllcyB0byBkZWNs cyBhdCBuYW1lc3BhY2Ugc2NvcGUuICAqLworICBpZiAoIURFQ0xfTkFNRVNQ QUNFX1NDT1BFX1AgKGRlY2wpKQorICAgIHJldHVybjsKKwogICBpZiAoIWV4 dGVybl9jX2RlY2xzKQogICAgIGV4dGVybl9jX2RlY2xzID0gaGFzaF90YWJs ZTxuYW1lZF9kZWNsX2hhc2g+OjpjcmVhdGVfZ2djICgxMjcpOwogCmRpZmYg LS1naXQgYS9nY2MvdGVzdHN1aXRlL2crKy5kZy9wYXJzZS9leHRlcm4tQy0y LkMgYi9nY2MvdGVzdHN1aXRlL2crKy5kZy9wYXJzZS9leHRlcm4tQy0yLkMK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmQ4YTRl MTRiNGI3Ci0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nKysu ZGcvcGFyc2UvZXh0ZXJuLUMtMi5DCkBAIC0wLDAgKzEsMjIgQEAKKy8vIFBS IGMrKy84NTU4MAorCitleHRlcm4gIkMiCit7CisKKyAgdm9pZCBmMSgpCisg IHsKKyAgICB1bmlvbiBzb21lX3R5cGV7CisgICAgICBjaGFyIGFbMl07Cisg ICAgICBpbnQgYjsKKyAgICB9IHZhcmlhYmxlOworICB9CisKKyAgdm9pZCBm MigpCisgIHsKKyAgICB1bmlvbiBzb21lX3R5cGV7CisgICAgICBjaGFyIGFb Ml07CisgICAgICBpbnQgYjsKKyAgICB9IHZhcmlhYmxlOworICB9CisKK30K --0000000000006a6161056b247361--