From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3805 invoked by alias); 20 Jun 2017 17:59:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 3241 invoked by uid 89); 20 Jun 2017 17:59:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mail-it0-f53.google.com Received: from mail-it0-f53.google.com (HELO mail-it0-f53.google.com) (209.85.214.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Jun 2017 17:59:09 +0000 Received: by mail-it0-f53.google.com with SMTP id m47so18762319iti.1 for ; Tue, 20 Jun 2017 10:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cmTUmJy9VZ/fGznfzMjHroHZhfACkY7jIBvAGP7x6kY=; b=YJmdQhJtWtjNbl6vWKoYF/OFHT8z3kd+2cVwLG5Qij9jRboEAv8aWnBgGB9CP11gXS 8CbKFbPFUgrFTlJvo3dfGI1cAd2h6QrGR/N+RkPHkU/sZGUrkfJ+Ku94vtHN09UEaYkh J2+VFG0zCWsW3aL+8+GQ/RZ/T2qT2o9kbq3XqX+bhVcNVMjKaucv6Hc8kZMgGee3Qtaa 4srX5VmXDlnDTy+L8c5mEZOjd57/7ZyHNytWXno6qG0YpHBwZHgMK8DWKBE2AtSdufBw 8azrvDYWahsqQhbSxI3i/PioOgoUlaVk3SsKFte5WIUnZJOKp1ol7Sp8qgwssY5lkzux CUNA== X-Gm-Message-State: AKS2vOzWunqFEk90tccnGrtT4Y1Ga+tgQaNI3/NWuVdVuB1/njB0yCmb /GLP3JC7vlwDfmQWYeLIXYyRmL25zHCp X-Received: by 10.36.219.132 with SMTP id c126mr4968040itg.73.1497981547359; Tue, 20 Jun 2017 10:59:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.20.139 with HTTP; Tue, 20 Jun 2017 10:58:46 -0700 (PDT) In-Reply-To: <1497973859.7551.171.camel@redhat.com> References: <1496689294-11629-1-git-send-email-dmalcolm@redhat.com> <1497973859.7551.171.camel@redhat.com> From: Jason Merrill Date: Tue, 20 Jun 2017 17:59:00 -0000 Message-ID: Subject: Re: [PING] C++ Re: [PATCH] C/C++: fix quoting of "aka" typedef information (PR 62170) To: David Malcolm Cc: gcc-patches List Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg01490.txt.bz2 On Tue, Jun 20, 2017 at 11:50 AM, David Malcolm wrote: >> + ob->next_free = p + type_start + type_len; I'm uncomfortable with modifying the obstack directly. Why not use obstack_free? I guess for that you'd want to change type_start to a pointer and get it from obstack_next_free. Jason