From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] Another bunch of location fixes
Date: Mon, 16 Sep 2019 15:42:00 -0000 [thread overview]
Message-ID: <CADzB+2n0b+6tseQpnKE6fjkbb=HEweUyiBqZLO3Zc8bSXN3nkw@mail.gmail.com> (raw)
In-Reply-To: <3c829e52-803c-f19e-470d-96cb53a33a00@oracle.com>
On Mon, Sep 16, 2019 at 5:22 AM Paolo Carlini <paolo.carlini@oracle.com> wrote:
>
> On 15/09/19 16:22, Jason Merrill wrote:
> > On 9/12/19 9:41 AM, Paolo Carlini wrote:
> >> + if (!valid_array_size_p (dname
> >> + ? declarator->id_loc : input_location,
> >
> > Use the id_loc local variable?
>
> This diagnostic is inside the loop over declarator->declarator.
> Eventually, outside the loop, the id_loc local is updated to the final
> declarator->id_loc or input_location. Norrmally in the loop we use the
> current declarator->id_loc: what I tested seems more correct to me (we
> have to account for input_location too because valid_array_size_p,
> shared with the C front-end, wants a sound location)
OK.
Jason
prev parent reply other threads:[~2019-09-16 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 14:42 Paolo Carlini
2019-09-15 14:22 ` Jason Merrill
2019-09-16 9:22 ` Paolo Carlini
2019-09-16 15:42 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2n0b+6tseQpnKE6fjkbb=HEweUyiBqZLO3Zc8bSXN3nkw@mail.gmail.com' \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).