From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74870 invoked by alias); 25 Apr 2019 21:10:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74816 invoked by uid 89); 25 Apr 2019 21:10:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*RU:sk:mail-oi, HX-HELO:sk:mail-oi, HX-Spam-Relays-External:sk:mail-oi, H*r:sk:mail-oi X-HELO: mail-oi1-f196.google.com Received: from mail-oi1-f196.google.com (HELO mail-oi1-f196.google.com) (209.85.167.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Apr 2019 21:09:59 +0000 Received: by mail-oi1-f196.google.com with SMTP id l12so1203457oie.13 for ; Thu, 25 Apr 2019 14:09:59 -0700 (PDT) MIME-Version: 1.0 References: <20190425112739.GJ21066@tucnak> In-Reply-To: <20190425112739.GJ21066@tucnak> From: Jason Merrill Date: Thu, 25 Apr 2019 21:14:00 -0000 Message-ID: Subject: Re: [PATCH] Fix -Wunused-var-35.C (was Re: [PATCH][C++] Improve compile-time by ordering expensive checks last) To: Jakub Jelinek Cc: Richard Biener , Rainer Orth , gcc-patches List Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg01012.txt.bz2 OK. On Thu, Apr 25, 2019 at 7:27 AM Jakub Jelinek wrote: > > On Thu, Apr 25, 2019 at 01:09:00PM +0200, Rainer Orth wrote: > > > cp/ > > > * call.c (null_ptr_cst_p): Order checks according to expensiveness. > > > (conversion_null_warnings): Likewise. > > > * typeck.c (same_type_ignoring_top_level_qualifiers_p): Return > > > early if type1 == type2. > > > > this patch caused > > > > +XPASS: g++.dg/warn/Wunused-var-35.C -std=gnu++98 bug (test for warnings, line 14) > > > > First seen on i386-pc-solaris2.11 and sparc-sun-solaris2.11, according > > to gcc-testresults everywhere. Confirmed by reverting the patch locally > > and re-testing the affected testcase. > > I can reproduce that too, seems to be the > @@ -6896,8 +6897,8 @@ > } > /* Handle zero as null pointer warnings for cases other > than EQ_EXPR and NE_EXPR */ > - else if (null_ptr_cst_p (expr) && > - (TYPE_PTR_OR_PTRMEM_P (totype) || NULLPTR_TYPE_P (totype))) > + else if ((TYPE_PTR_OR_PTRMEM_P (totype) || NULLPTR_TYPE_P (totype)) > + && null_ptr_cst_p (expr)) > { > location_t loc = get_location_for_expr_unwinding_for_system_header (expr); > maybe_warn_zero_as_null_pointer_constant (expr, loc); > hunk. The Wunused-var-35.C patch hasn't been posted to gcc-patches, but > judging from the corresponding PR, I'd say the right thing is below. > > Regtested on x86_64-linux and i686-linux, ok for trunk? > > 2019-04-25 Jakub Jelinek > > PR c++/44648 > * g++.dg/warn/Wunused-var-35.C: Remove xfail. > > --- gcc/testsuite/g++.dg/warn/Wunused-var-35.C.jj 2019-02-04 09:44:31.365413407 +0100 > +++ gcc/testsuite/g++.dg/warn/Wunused-var-35.C 2019-04-25 13:24:49.717065815 +0200 > @@ -11,9 +11,8 @@ int main() > else > return 1; > > - if (const bool b2 = 1) // { dg-warning "\\\[-Wunused-variable\\\]" "bug" { xfail c++98_only } } > + if (const bool b2 = 1) // { dg-warning "\\\[-Wunused-variable\\\]" } > return 0; > else > return 1; > } > - > > > Jakub