From: Jason Merrill <jason@redhat.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] c++: Reject anonymous struct with bases
Date: Sat, 31 Jul 2021 10:46:41 -0400 [thread overview]
Message-ID: <CADzB+2nQAsPTZ4_ECRQhLDOkEOi-ohhj2reqFN0RWd+=AmZH0Q@mail.gmail.com> (raw)
In-Reply-To: <CA+=Sn1nz8U6eaJCrTOwaVFmdwUEL2tsKruk1VQK5iY1Ffm7aow@mail.gmail.com>
On Fri, Jul 30, 2021 at 3:35 PM Andrew Pinski <pinskia@gmail.com> wrote:
> On Fri, Jul 30, 2021 at 9:26 AM Jason Merrill via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
> >
> > In discussion of jakub's patch for C++20 pointer-interconvertibility, it
> > came up that we allow anonymous structs to have bases, but don't do
> anything
> > usable with them. Let's reject it.
> >
> > The comment change is something I noticed while looking for the right
> place
> > to diagnose this: finish_struct_anon does not actually check for anything
> > invalid, so it shouldn't claim to.
>
> This should fix PR 96636 by rejecting the code.
>
Thanks.
Jason
prev parent reply other threads:[~2021-07-31 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 16:23 Jason Merrill
2021-07-30 19:35 ` Andrew Pinski
2021-07-31 14:46 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2nQAsPTZ4_ECRQhLDOkEOi-ohhj2reqFN0RWd+=AmZH0Q@mail.gmail.com' \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).