From: Jason Merrill <jason@redhat.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: C++ PATCH to remove WITH_CLEANUP_EXPR handling
Date: Thu, 29 Jun 2017 21:44:00 -0000 [thread overview]
Message-ID: <CADzB+2nRM9tATBZxGvqwEQ-+Zhmwp3rn6w8wYL2MY0sg_VGA-g@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
The C++ front end hasn't generated WITH_CLEANUP_EXPR in a very long
time (20+ years?), so there's no need to handle it.
Tested x86_64-pc-linux-gnu, applying to trunk.
[-- Attachment #2: wce.diff --]
[-- Type: text/plain, Size: 2121 bytes --]
commit 8ce76bba3bf7866a2338125b4c55b0a1e3ce9221
Author: Jason Merrill <jason@redhat.com>
Date: Thu Jun 29 15:56:20 2017 -0400
* constexpr.c, error.c, tree.c: Remove WITH_CLEANUP_EXPR handling.
diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c
index 5a57452..32180a7 100644
--- a/gcc/cp/constexpr.c
+++ b/gcc/cp/constexpr.c
@@ -4519,7 +4519,6 @@ cxx_eval_constant_expression (const constexpr_ctx *ctx, tree t,
/* GCC internal stuff. */
case VA_ARG_EXPR:
case OBJ_TYPE_REF:
- case WITH_CLEANUP_EXPR:
case NON_DEPENDENT_EXPR:
case BASELINK:
case OFFSET_REF:
@@ -5533,7 +5532,6 @@ potential_constant_expression_1 (tree t, bool want_rval, bool strict,
case BIND_EXPR:
return RECUR (BIND_EXPR_BODY (t), want_rval);
- case WITH_CLEANUP_EXPR:
case CLEANUP_POINT_EXPR:
case MUST_NOT_THROW_EXPR:
case TRY_CATCH_EXPR:
diff --git a/gcc/cp/error.c b/gcc/cp/error.c
index 86fa804..43b5cec 100644
--- a/gcc/cp/error.c
+++ b/gcc/cp/error.c
@@ -2664,7 +2664,6 @@ dump_expr (cxx_pretty_printer *pp, tree t, int flags)
break;
case TRY_CATCH_EXPR:
- case WITH_CLEANUP_EXPR:
case CLEANUP_POINT_EXPR:
dump_expr (pp, TREE_OPERAND (t, 0), flags);
break;
diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index a52a9e8..c037b2c 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -90,7 +90,6 @@ lvalue_kind (const_tree ref)
case PREINCREMENT_EXPR:
case PREDECREMENT_EXPR:
case TRY_CATCH_EXPR:
- case WITH_CLEANUP_EXPR:
case REALPART_EXPR:
case IMAGPART_EXPR:
return lvalue_kind (TREE_OPERAND (ref, 0));
@@ -3584,11 +3583,6 @@ cp_tree_equal (tree t1, tree t2)
return cp_tree_equal (TREE_OPERAND (t1, 1), TREE_OPERAND (t2, 1));
}
- case WITH_CLEANUP_EXPR:
- if (!cp_tree_equal (TREE_OPERAND (t1, 0), TREE_OPERAND (t2, 0)))
- return false;
- return cp_tree_equal (TREE_OPERAND (t1, 1), TREE_OPERAND (t1, 1));
-
case PARM_DECL:
/* For comparing uses of parameters in late-specified return types
with an out-of-class definition of the function, but can also come
next reply other threads:[~2017-06-29 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 21:44 Jason Merrill [this message]
2017-06-30 12:39 ` Nathan Sidwell
2017-07-03 9:35 ` Marek Polacek
2017-07-04 2:03 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2nRM9tATBZxGvqwEQ-+Zhmwp3rn6w8wYL2MY0sg_VGA-g@mail.gmail.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).