From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87319 invoked by alias); 18 Feb 2017 02:45:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 87212 invoked by uid 89); 18 Feb 2017 02:45:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-ot0-f171.google.com Received: from mail-ot0-f171.google.com (HELO mail-ot0-f171.google.com) (74.125.82.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Feb 2017 02:45:26 +0000 Received: by mail-ot0-f171.google.com with SMTP id 32so42579520oth.3 for ; Fri, 17 Feb 2017 18:45:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aXHswF8DAaad8E0+XgewfIAWh3FHXyKaNXLmIF7qksc=; b=ScQ4x65KK7dGi1eOhCPoNOCJ7nITj2rc4q7/5f1LuVZQKuxcO9hjctZclRI83lYdwU Ul6d+iKnOYr4HC4+bFxiAODYH2inUDzN7mMw0uRqczCa6GlPz57wK0FNhjbXPIPzF8iI o9fb8azCIxtYjbBjPX5n+Jbgz3Ys4lEsu1rPqcMwr9Kut+OCSUFJuE9NlsX2UQC6av/p 1AX3Vouv9OxWdG18cSog6Q92iofZ549/pVwDfOvS066lWOvQcgjOml4Y/4J1wVe/B+ND VtUNtV3tXA3CSgIS6NlWwwc5Ag/wA+lQ/b+9bPPxubfcGxqUzwCkpfVDSr/q69mFa4X8 ZR5A== X-Gm-Message-State: AMke39lGtbCu0o4qFCHO8I4aUdmUbmau7x0PyvhdgR85MmWvjkP3UUs5qgP735YQllyZXJpNofhWAydZiE4O6Xt0 X-Received: by 10.157.34.130 with SMTP id y2mr5499502ota.241.1487385924730; Fri, 17 Feb 2017 18:45:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.5.4 with HTTP; Fri, 17 Feb 2017 18:45:04 -0800 (PST) In-Reply-To: References: From: Jason Merrill Date: Sat, 18 Feb 2017 04:53:00 -0000 Message-ID: Subject: Re: [PATCH][C++] Annotate more functions with MEM-STATs To: Richard Biener Cc: gcc-patches List , Jakub Jelinek Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg01163.txt.bz2 On Fri, Feb 17, 2017 at 6:51 AM, Richard Biener wrote: > > The following annotates two key wrappers around copy_node in the C++ FE > with MEM-STAT info (and with CXX_MEM_STAT_INFO this is surprisingly > easy, without adding _stat variants and macros as we have for the classic > way from the pre-C++ era). > > It also annotates more type building functions in tree.c (all in the > attempt to get a better idea on where all the types are built for C++ > sources). > > Bootstrapped without --enable-gather-detailed-mem-stats, bootstrapped > with --enable-gather-detailed-mem-stats and visually inspected the > improved stats on some example C++ code. > > There are still some more functions worth annotating: > > tree.c:8239 (build_range_type_1) 840: 0.0% > 666120: 3.2% > tree.c:8362 (build_array_type_1) 3024: 0.0% > 671496: 3.2% > tree.c:4841 (build_type_attribute_qual_variant) 13776: 0.1% > 67032: 0.3% > tree.c:8681 (build_method_type_directly) 41832: 0.3% > 202944: 1.0% > hash-table.h:736 (expand) 15136: 0.1% > 5826600: 27.8% > tree.c:8532 (build_function_type) 148344: 1.1% > 3538080: 16.9% > cp/lex.c:556 (retrofit_lang_decl) 78628: 0.6% > 43776: 0.2% > cp/lex.c:526 (build_lang_decl_loc) 87968: 0.6% > 260776: 1.2% 3902184: 7.5% 536840: 23.8% 15444 > > is it ok if I go forward with this (at this stage, also for C++ > specifics above?) > > Would it be welcome to scrap _stat and the macro wrappings everywhere > at this stage? The patch looks fine to me, I don't have an opinion about appropriateness for this stage. Jason