From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)
Date: Wed, 14 Sep 2016 05:56:00 -0000 [thread overview]
Message-ID: <CADzB+2nYKrK7F1L-K8WFbEbkUrNX-cvwC0kf4NMpSr2KHc21og@mail.gmail.com> (raw)
In-Reply-To: <20160910145843.GJ19950@redhat.com>
On Sat, Sep 10, 2016 at 10:58 AM, Marek Polacek <polacek@redhat.com> wrote:
> Spurred by the recent <http://www.viva64.com/en/b/0425/> findings, I decided to
> implement a warning that warns when a pointer is compared with a zero character
> literal (constant), because this isn't likely to be intended. So e.g.
>
> ptr == L'\0'
>
> is probably wrong and should've been written as
>
> ptr[0] == L'\0'
>
> Jonathan pointed out that this would actually be invalid C++11 since pointer
> conversions are only allowed for integer literals, not char literals.
Ah, indeed. And if we fix that, we get an error rather than a
warning. Maybe let's handle this by wrapping character literals in a
redundant NOP_EXPR?
Jason
next prev parent reply other threads:[~2016-09-14 4:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 15:06 Marek Polacek
2016-09-10 15:13 ` Jakub Jelinek
2016-09-10 15:48 ` Marek Polacek
2016-09-14 5:56 ` Jason Merrill [this message]
2016-09-15 12:31 ` Marek Polacek
2016-09-19 19:51 ` Jason Merrill
2016-09-21 19:55 ` Jason Merrill
2016-09-23 13:29 ` Marek Polacek
2016-09-23 14:37 ` Jason Merrill
2016-09-30 16:52 ` Marek Polacek
2016-09-30 17:22 ` Martin Sebor
2016-09-30 19:52 ` Martin Sebor
2016-09-30 20:02 ` Marek Polacek
2016-09-30 22:16 ` Martin Sebor
2016-09-30 22:16 ` Jason Merrill
2016-10-01 14:41 ` Marek Polacek
2016-10-02 18:43 ` Jason Merrill
2017-01-04 6:56 ` Eric Gallager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2nYKrK7F1L-K8WFbEbkUrNX-cvwC0kf4NMpSr2KHc21og@mail.gmail.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).