From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Marek Polacek <polacek@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ PATCH] Fix ICEs due to cp_parser_postfix_dot_deref_expression workaround (PR c++/84082, take 2)
Date: Tue, 06 Feb 2018 22:45:00 -0000 [thread overview]
Message-ID: <CADzB+2neLYAirmffeqbRhAg3424t=70VGyFLDuQH0FScVvkL-A@mail.gmail.com> (raw)
In-Reply-To: <20180206202857.GC5867@tucnak>
On Tue, Feb 6, 2018 at 3:28 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Feb 02, 2018 at 03:13:21PM -0500, Jason Merrill wrote:
>> > Or should I change the switch body to do other kind = overrides?
>>
>> I think we want to avoid clobbering NON_LVALUE_EXPR location wrappers, too.
>>
>> This has gotten large enough that it should break out into its own function.
>>
>> OK with those changes.
>
> So like this? Bootstrapped/regtested on x86_64-linux and i686-linux.
>
> + case NON_LVALUE_EXPR:
> + if (location_wrapper_p (*postfix_expression))
I don't think we need this test, as NON_LVALUE_EXPR should only appear
as a location wrapper. OK with it removed.
Jason
prev parent reply other threads:[~2018-02-06 22:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 0:30 [C++ PATCH] Fix ICEs due to cp_parser_postfix_dot_deref_expression workaround (PR c++/84082) Jakub Jelinek
2018-02-02 20:13 ` Jason Merrill
2018-02-06 20:29 ` [C++ PATCH] Fix ICEs due to cp_parser_postfix_dot_deref_expression workaround (PR c++/84082, take 2) Jakub Jelinek
2018-02-06 22:45 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADzB+2neLYAirmffeqbRhAg3424t=70VGyFLDuQH0FScVvkL-A@mail.gmail.com' \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).