From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64528 invoked by alias); 6 Feb 2018 22:45:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64475 invoked by uid 89); 6 Feb 2018 22:45:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-it0-f66.google.com Received: from mail-it0-f66.google.com (HELO mail-it0-f66.google.com) (209.85.214.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Feb 2018 22:45:51 +0000 Received: by mail-it0-f66.google.com with SMTP id b66so4559708itd.5 for ; Tue, 06 Feb 2018 14:45:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OJtSpEt8KWib5blFDzbZ5JFT8zlE0lmVutUMaYCr/DE=; b=YAV2TGhtmACUybHPbMh4NlXfUIqQnrr/SFj50DDGunfD+PBIWyZG/3UnIAjHi4CNLO OM3ikAj8b1xLxqqu7IwtXRRp9693FyRITtxM6JxhxER0V+9r4AsaXCqPEGefRDUHxZpG wxjNzD0BprP7T5sBO8IvnNUWnLpHrvSKZ8xi8gXkZ4aBNzQNsu2EKFjYlhbiSxc9B1VV glyiBAgXtjy1jf9ObgxfW5UE5z0fPdrUaasdxgJxN3oN9N4wgZkEg6f8NhJmKA5weykn AO9c9yA4Fwu9XfU5GhO5h1BkzkdfGbMtpt/h5Fv29Hje5vSoJScU9yf12767GovvkCZc PXBw== X-Gm-Message-State: APf1xPCDfx9WrN3vCjWSuxZNp4Uy66DpX+8IHj+5uwtLSZft5PAo1HMf fOrOv5HuK12ewvOeNKA9eKrbCQMG23/U+HEFgy9a+A== X-Google-Smtp-Source: AH8x227wwLs4EA+2pVELE5ar8Z2J1J/IczhdxDBhlI5tvSX+nzRJiO7CpKd5Nv37dkO3dD1xZ6Qg50OqmxYQTPzB3NM= X-Received: by 10.36.61.142 with SMTP id n136mr5455958itn.6.1517957146679; Tue, 06 Feb 2018 14:45:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.17.206 with HTTP; Tue, 6 Feb 2018 14:45:26 -0800 (PST) In-Reply-To: <20180206202857.GC5867@tucnak> References: <20180129232912.GT2063@tucnak> <20180206202857.GC5867@tucnak> From: Jason Merrill Date: Tue, 06 Feb 2018 22:45:00 -0000 Message-ID: Subject: Re: [C++ PATCH] Fix ICEs due to cp_parser_postfix_dot_deref_expression workaround (PR c++/84082, take 2) To: Jakub Jelinek Cc: Marek Polacek , gcc-patches List Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00283.txt.bz2 On Tue, Feb 6, 2018 at 3:28 PM, Jakub Jelinek wrote: > On Fri, Feb 02, 2018 at 03:13:21PM -0500, Jason Merrill wrote: >> > Or should I change the switch body to do other kind = overrides? >> >> I think we want to avoid clobbering NON_LVALUE_EXPR location wrappers, too. >> >> This has gotten large enough that it should break out into its own function. >> >> OK with those changes. > > So like this? Bootstrapped/regtested on x86_64-linux and i686-linux. > > + case NON_LVALUE_EXPR: > + if (location_wrapper_p (*postfix_expression)) I don't think we need this test, as NON_LVALUE_EXPR should only appear as a location wrapper. OK with it removed. Jason