From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] PR 80896 ("[[nodiscard]] is ignored for functions returning references")
Date: Wed, 31 May 2017 19:03:00 -0000 [thread overview]
Message-ID: <CADzB+2no6xp-hJminZP3Dn+byhjvU5YXR3Y7Ngoco4zY_RJwXQ@mail.gmail.com> (raw)
In-Reply-To: <875f093a-0b8f-7ddc-cd46-cece5a24cb2f@oracle.com>
OK.
On Wed, May 31, 2017 at 8:04 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Hi,
>
> this one appears to be a rather simple case of missing diagnostic: in
> convert_to_void we aren't calling maybe_warn_nodiscard when we strip an
> INDIRECT_REF wrapping a CALL_EXPR thus we don't issue the diagnostic that we
> normally provide for plain CALL_EXPRs (eg, for a func returning a plain
> int). Tested x86_64-linux.
>
> Thanks, Paolo.
>
> //////////////////
>
prev parent reply other threads:[~2017-05-31 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 12:04 Paolo Carlini
2017-05-31 19:03 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADzB+2no6xp-hJminZP3Dn+byhjvU5YXR3Y7Ngoco4zY_RJwXQ@mail.gmail.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).