From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23334 invoked by alias); 31 May 2017 18:48:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23254 invoked by uid 89); 31 May 2017 18:48:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-it0-f49.google.com Received: from mail-it0-f49.google.com (HELO mail-it0-f49.google.com) (209.85.214.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 May 2017 18:48:49 +0000 Received: by mail-it0-f49.google.com with SMTP id m47so1557092iti.0 for ; Wed, 31 May 2017 11:48:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VmBvTp1fogLuLhVYlbLrNE5FxNxYUy5/ra7AOae2No0=; b=ZGwNYbgRwvQtmOQBIq4hrwASc/yMTongwV1wQ+mbX7MXQdo6pJ1pCOdwIS0gD7zSyF A2tuC8avviKr+CJ3fT4LOMMQzUDNAvNePIOnK3BenRVthahoZ3uzU7gFYK6o6M2vwMwF D1Ht0cTWakU31UgOq7nHje9FCwnQvYllCSnrIKtjYCOb2d+h7Kkdc80S9bowQB3Cv80K V/2z3XP9do+z0tZsV1ig9FjSIcf/YtLEEqVepBhjefl64FuuxluygJceSmbT5rYn7i3K PUUXk6Z58uk4AYXJIOLgvLbht+jMMvabBA0TuUyNVKYandxulwFvKdDtuHtbnMUMHeFg /0Nw== X-Gm-Message-State: AODbwcDPdpcRSMReE5NweQsKruSHBQn2uy/c8LXJTv2NRe1YU1Hcbo0Z sfErmUtuhR+LOHNlyjfBVomfh/Me6P4p X-Received: by 10.36.224.133 with SMTP id c127mr9221901ith.73.1496256531616; Wed, 31 May 2017 11:48:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.6.226 with HTTP; Wed, 31 May 2017 11:48:31 -0700 (PDT) In-Reply-To: <875f093a-0b8f-7ddc-cd46-cece5a24cb2f@oracle.com> References: <875f093a-0b8f-7ddc-cd46-cece5a24cb2f@oracle.com> From: Jason Merrill Date: Wed, 31 May 2017 19:03:00 -0000 Message-ID: Subject: Re: [C++ Patch] PR 80896 ("[[nodiscard]] is ignored for functions returning references") To: Paolo Carlini Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02398.txt.bz2 OK. On Wed, May 31, 2017 at 8:04 AM, Paolo Carlini wrote: > Hi, > > this one appears to be a rather simple case of missing diagnostic: in > convert_to_void we aren't calling maybe_warn_nodiscard when we strip an > INDIRECT_REF wrapping a CALL_EXPR thus we don't issue the diagnostic that we > normally provide for plain CALL_EXPRs (eg, for a func returning a plain > int). Tested x86_64-linux. > > Thanks, Paolo. > > ////////////////// >