From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3043 invoked by alias); 21 Sep 2016 19:52:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2748 invoked by uid 89); 21 Sep 2016 19:52:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f44.google.com Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Sep 2016 19:52:32 +0000 Received: by mail-oi0-f44.google.com with SMTP id w11so73079875oia.2 for ; Wed, 21 Sep 2016 12:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ziYdEFdXzkDRzAe6L2kknRfKzu7iBbgz8gAYToo0iXs=; b=e583D4H0pNefi2hUBaSV3VZnQ7c+smnuG/8DOtwQB/+XrN77vK0/JpdYwtoiJZ47Bc D+EetvAI5OCozKSUbYK/tHHFtoYy9xVUv9Cx0CiU/QnGq0UuQjv4Zdik1h31hye3HsHy gXzK+zlc2APeu5NuAAG22tqgAEKQAr732UWjMgFAJ7HxEs7VO+/7Mxaf4Qk5hn/El+6w at54h25gkbZ7+G6F8UsKmEFwHLN/CJl93idDX8H4xzrZJccRhOoKwpTbT3b1C4vP4sNo 9frecoHvH8XvApxSeftD4BRinMxRMFIlm3GidvAjVWkXd2B/yZxsAR1QVs03kA00BMOA 4FEA== X-Gm-Message-State: AE9vXwO725Ijz81VD5ypKiDLyyYiwZFMMONwBZGnVLR7zSrrmvUg8PYHWr+etpNpmiSKFr87P3DJUX+V1xiWWEqg X-Received: by 10.202.102.198 with SMTP id m67mr49914078oik.1.1474487550411; Wed, 21 Sep 2016 12:52:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.105.167 with HTTP; Wed, 21 Sep 2016 12:52:09 -0700 (PDT) In-Reply-To: References: <20160910145843.GJ19950@redhat.com> <20160915121631.GY19950@redhat.com> From: Jason Merrill Date: Wed, 21 Sep 2016 19:55:00 -0000 Message-ID: Subject: Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767) To: Marek Polacek Cc: GCC Patches , Joseph Myers Content-Type: multipart/mixed; boundary=001a1140a92cac0cf2053d09e2e6 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01464.txt.bz2 --001a1140a92cac0cf2053d09e2e6 Content-Type: text/plain; charset=UTF-8 Content-length: 262 On Mon, Sep 19, 2016 at 2:49 PM, Jason Merrill wrote: > I suppose that an INTEGER_CST of character type is necessarily a > character constant, so adding a check for !char_type_p ought to do the > trick. Indeed it does. I'm checking this in: --001a1140a92cac0cf2053d09e2e6 Content-Type: text/x-patch; charset=US-ASCII; name="char903.diff" Content-Disposition: attachment; filename="char903.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itdbqmwd0 Content-length: 1245 Y29tbWl0IGQyZjIzN2VmMGY2M2IzZWUzZGE3OWJjYmZhZDA4ZmVkYjMyNWQ1 NTQKQXV0aG9yOiBKYXNvbiBNZXJyaWxsIDxqYXNvbkByZWRoYXQuY29tPgpE YXRlOiAgIFdlZCBTZXAgMjEgMTA6NTg6MzkgMjAxNiAtMDQwMAoKICAgICAg ICAgICAgQ29yZSA5MDMKICAgICAgICAgICAgKiBjYWxsLmMgKG51bGxfcHRy X2NzdF9wKTogQ2hlY2sgY2hhcl90eXBlX3AuCgpkaWZmIC0tZ2l0IGEvZ2Nj L2NwL2NhbGwuYyBiL2djYy9jcC9jYWxsLmMKaW5kZXggMzkzYWFiOS4uMjgw NGJkOCAxMDA2NDQKLS0tIGEvZ2NjL2NwL2NhbGwuYworKysgYi9nY2MvY3Av Y2FsbC5jCkBAIC01MjcsNiArNTI3LDcgQEAgbnVsbF9wdHJfY3N0X3AgKHRy ZWUgdCkKICAgICB7CiAgICAgICAvKiBDb3JlIGlzc3VlIDkwMyBzYXlzIG9u bHkgbGl0ZXJhbCAwIGlzIGEgbnVsbCBwb2ludGVyIGNvbnN0YW50LiAgKi8K ICAgICAgIGlmIChUUkVFX0NPREUgKHR5cGUpID09IElOVEVHRVJfVFlQRQor CSAgJiYgIWNoYXJfdHlwZV9wICh0eXBlKQogCSAgJiYgVFJFRV9DT0RFICh0 KSA9PSBJTlRFR0VSX0NTVAogCSAgJiYgaW50ZWdlcl96ZXJvcCAodCkKIAkg ICYmICFUUkVFX09WRVJGTE9XICh0KSkKZGlmZiAtLWdpdCBhL2djYy90ZXN0 c3VpdGUvZysrLmRnL2NwcDB4L251bGxwdHIzNi5DIGIvZ2NjL3Rlc3RzdWl0 ZS9nKysuZGcvY3BwMHgvbnVsbHB0cjM2LkMKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMC4uNWY0Mzg4MQotLS0gL2Rldi9udWxsCisrKyBi L2djYy90ZXN0c3VpdGUvZysrLmRnL2NwcDB4L251bGxwdHIzNi5DCkBAIC0w LDAgKzEsMyBAQAorLy8geyBkZy1kbyBjb21waWxlIHsgdGFyZ2V0IGMrKzEx IH0gfQorCit2b2lkICpwID0gJ1wwJzsJCQkvLyB7IGRnLWVycm9yICJpbnZh bGlkIGNvbnZlcnNpb24iIH0K --001a1140a92cac0cf2053d09e2e6--