From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 426E13858439 for ; Wed, 20 Dec 2023 09:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 426E13858439 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 426E13858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703065500; cv=none; b=KSxsJhmwiB/Qf4N3GHKJBAJEQu8G9fWHi7X6X+AQIgAc0jHXmbW89e77TPL9BLZNFfOiUXYWrM9E3q5k1EeC0VauKGhdMYRHeBdw0K1v8r+kwLsbXZqe/IucMA3nD04ePET+9yGfSwPNuz8r3HHbwSylU72/HsVfdqyfClp/zeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703065500; c=relaxed/simple; bh=RDN9w5JlL79tRU7+udPaagh4Vdf82kLJv5pxh5Gr6so=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=a1dvaHqrv6LOwZLWrucG0IJ9wTIdekjXP15hxBAGdSwA6kTgTL8JG5AP+icM4ozc73OJV1H34ggrbH0ogRJrlepEw8/daqIY6no3XRo1QGijgMu9NO4qU/aIVcKhbHvL8vo+STN4OJhwDxwjVzy5wLK0W+0AhcfgXX5vDQNT9EQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2cc7087c6c4so40001121fa.2 for ; Wed, 20 Dec 2023 01:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1703065497; x=1703670297; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=E/8stdWe3Pz3Mp0QCu26LG1pDpdYVHVPJZPZ7aJC7OI=; b=hs8Hw3OW40CTQ2Bp6P2uTap2neMKH5uDNRVkUl+36cKENgneGLnU3GwMVao5xW6gzS ocU73ogu+lv/yKKAbEIQX4Xig5UP3aSWEdtQGWi0LlfBt0YsTkcUle5R1RwTJbJ6Upmd 1qitPPqSuFRhskJagcI0GOI0fE0CknUFWo98Fv1DpF7R4HWK+fPxDhxti+982+sAkXkp NUHNOWWOOxY7BGJjsbFX5coR8F9wPUaf81Oc5S7j4Yrkt/DVPSXAETeNZr17MPJ/w5DV LKXFBgu1N8QxN/2mzD5qusXzFxV+UxprQYuYkeVwAPdfWypPSHImtkXxZii/33QvBjDA gPGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703065497; x=1703670297; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E/8stdWe3Pz3Mp0QCu26LG1pDpdYVHVPJZPZ7aJC7OI=; b=YVIgJfwXkwAoqngdJUzHSbjUIDx2UD2Sl+5EFX6xGIt5pbGTS/2puaO+sJYVmXHofX v2p1RtO2I2HeEGovb9mUHkJupNjYDk3u5jAdhcgsfwACzLRAM5jocoOClg4GK88AMVKb X9eEtOjUnboj8Js+x+Lbs9oZnpDb2fk2NUIoDjyFxPW0VwSbEpDjduM0ZzPL3y4m6o3o 6StrVLNu5viPdKVsY2I0h1bJ4E9AIOul2s0rZtWdIKZZeLyZpCXevM9PddqVvw8E8iDf tDGsNThymdHhEPr2bnD6C80Z4QfpOOgnfAp1hwDvjbYghNH5O8BQRzTxnNCom2vwW0Cb 0VmQ== X-Gm-Message-State: AOJu0YwMsvF+5732ZlzgBz4XaVrT6rx0lrIPrAYDlxkD2TLtA8CanVel 5FhtpfykSGhwZz10L6dmp0La61XUdOKmIm+4IRjMJg== X-Google-Smtp-Source: AGHT+IGH0bQYBwsNN/tFA+KyN0AXh4E90z7+koRQqxTgRl3BkeXar5yYlgC07AOi6/UXQ3Q2XWeObp/gTUVyTd6zKFA= X-Received: by 2002:a05:651c:b09:b0:2cc:88bd:d4dd with SMTP id b9-20020a05651c0b0900b002cc88bdd4ddmr920203ljr.63.1703065496599; Wed, 20 Dec 2023 01:44:56 -0800 (PST) MIME-Version: 1.0 References: <20231219095348.356551-1-slewis@rivosinc.com> <20231219095348.356551-2-slewis@rivosinc.com> <5098d3c3-845f-4b71-ba8f-751b03b73240@gmail.com> In-Reply-To: <5098d3c3-845f-4b71-ba8f-751b03b73240@gmail.com> From: Sergei Lewis Date: Wed, 20 Dec 2023 09:44:45 +0000 Message-ID: Subject: Re: [PATCH v2 1/3] RISC-V: movmem for RISCV with V extension To: Jeff Law Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="000000000000f4526b060cedd584" X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f4526b060cedd584 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, this patchset has been tested with the following configurations: rv64gcv_zvl128b rv64gcv_zvl256b rv32imafd_zve32x1p0 rv32gc_zve64f_zvl128b Will fix the formatting in v3. Thanks On Wed, Dec 20, 2023 at 5:28=E2=80=AFAM Jeff Law wr= ote: > > > On 12/19/23 02:53, Sergei Lewis wrote: > > gcc/ChangeLog > > > > * config/riscv/riscv.md (movmem): Use > riscv_vector::expand_block_move, > > if and only if we know the entire operation can be performed using > one vector > > load followed by one vector store > > > > gcc/testsuite/ChangeLog > > > > PR target/112109 > > * gcc.target/riscv/rvv/base/movmem-1.c: New test > So this needs to be regression tested. Given that it only affects RVV, > I would suggest testing rv64gcv or rv32gcv. > > > > > +(define_expand "movmem" > > + [(parallel [(set (match_operand:BLK 0 "general_operand") > > + (match_operand:BLK 1 "general_operand")) > > + (use (match_operand:P 2 "const_int_operand")) > > + (use (match_operand:SI 3 "const_int_operand"))])] > > + "TARGET_VECTOR" > > +{ > > + if ((INTVAL (operands[2]) >=3D TARGET_MIN_VLEN/8) > > + && (INTVAL (operands[2]) <=3D TARGET_MIN_VLEN) > > + && riscv_vector::expand_block_move (operands[0], operands[1], > > + operands[2])) > > + DONE; > > + else > > + FAIL; > > +}) > Just a formatting nit. A space on each side of the '/' operator above. > > > Jeff > --000000000000f4526b060cedd584--