From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fritzoreese@gmail.com>
Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com
 [IPv6:2607:f8b0:4864:20::e30])
 by sourceware.org (Postfix) with ESMTPS id CA766385C019;
 Mon,  6 Apr 2020 20:10:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CA766385C019
Received: by mail-vs1-xe30.google.com with SMTP id 184so726241vsu.3;
 Mon, 06 Apr 2020 13:10:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=ItY9/fe1x4qXfyBkaMJWiZPjEzNaZb2cep/UlNPAOCw=;
 b=HZL4AyyRaEKkst41iMU/EAgYKz8IVas4S2o6i/mMmR63AQWSqkl392GFtZBFc+IClt
 5RThqamt0BKuyWJpC3PGznJUvkXW/ojJUm1k5SiTnlYSWDnOB2i2t7OLBivyQ7xSVIhw
 /+VCsCD2ydwp14QuLmvW3WAT5fEhcdNCJRBp8yQCtK1wMfG8HcuudJzD+3HRpIhQaDt+
 yRpNDhWA6GyzU6CO/6I6NIiXaa3yF2HU7G641R5DuNE+kSfsvRu80Lxzh/dBmbiPnAOV
 Pn0gjr9S0BFt8j2MoQx9sc5Smuk+lfRT8hLzBj32KPkiRFOc4aesRh7Aka1rtAzESBdj
 ty6w==
X-Gm-Message-State: AGi0PuY3CQgTnyz7CArBS4JWBW8codwhU0e4zfQKUKrKkRR9mlH+kE+C
 J+jBtDmkvBBhaGQRgUTY5z2ji6WJ0qxqfjspqNf1Q4gP
X-Google-Smtp-Source: APiQypIvXfpgSxevgsWLvFSQjsJbCWJVDLmREzgjEv8OynUzL+Is0gmEAPqAh0UGHe/RD6pC1aoAixWJiHL7dBdQDdE=
X-Received: by 2002:a67:f851:: with SMTP id b17mr1280264vsp.57.1586203835345; 
 Mon, 06 Apr 2020 13:10:35 -0700 (PDT)
MIME-Version: 1.0
References: <20200404185811.GA72336@troutmask.apl.washington.edu>
In-Reply-To: <20200404185811.GA72336@troutmask.apl.washington.edu>
From: Fritz Reese <fritzoreese@gmail.com>
Date: Mon, 6 Apr 2020 16:10:24 -0400
Message-ID: <CAE4aFAkN85UKFqHgVZtDR61ofL4dJkb7prReOq1CeV_2-Sz-YA@mail.gmail.com>
Subject: Re: Fix an ICE found in PR93686
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: fortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_2,
 GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Apr 2020 20:10:37 -0000

On Sat, Apr 4, 2020 at 2:58 PM Steve Kargl via Fortran
<fortran@gcc.gnu.org> wrote:
>
> This patch fixes the ICE found in PR93686.
>
>
> Index: gcc/fortran/decl.c
> ===================================================================
> --- gcc/fortran/decl.c  (revision 280157)
> +++ gcc/fortran/decl.c  (working copy)
> @@ -696,6 +696,10 @@ gfc_match_data (void)
>           /* F2008:C567 (R536) A data-i-do-object or a variable that appears
>              as a data-stmt-object shall not be an object designator in which
>              a pointer appears other than as the entire rightmost part-ref.  */
> +         if (!e->ref && e->ts.type == BT_DERIVED
> +             && e->symtree->n.sym->attr.pointer)
> +           goto partref;
> +
>           ref = e->ref;
>           if (e->symtree->n.sym->ts.type == BT_DERIVED
>               && e->symtree->n.sym->attr.pointer
>
> --
> Steve

LGTM, thanks for the patch. I will commit along with the testcases from the PR.

---
Fritz