* Re: Fix an ICE found in PR93686 [not found] <20200404185811.GA72336@troutmask.apl.washington.edu> @ 2020-04-06 20:10 ` Fritz Reese 2020-04-06 21:47 ` Steve Kargl 0 siblings, 1 reply; 3+ messages in thread From: Fritz Reese @ 2020-04-06 20:10 UTC (permalink / raw) To: Steve Kargl; +Cc: fortran, gcc-patches On Sat, Apr 4, 2020 at 2:58 PM Steve Kargl via Fortran <fortran@gcc.gnu.org> wrote: > > This patch fixes the ICE found in PR93686. > > > Index: gcc/fortran/decl.c > =================================================================== > --- gcc/fortran/decl.c (revision 280157) > +++ gcc/fortran/decl.c (working copy) > @@ -696,6 +696,10 @@ gfc_match_data (void) > /* F2008:C567 (R536) A data-i-do-object or a variable that appears > as a data-stmt-object shall not be an object designator in which > a pointer appears other than as the entire rightmost part-ref. */ > + if (!e->ref && e->ts.type == BT_DERIVED > + && e->symtree->n.sym->attr.pointer) > + goto partref; > + > ref = e->ref; > if (e->symtree->n.sym->ts.type == BT_DERIVED > && e->symtree->n.sym->attr.pointer > > -- > Steve LGTM, thanks for the patch. I will commit along with the testcases from the PR. --- Fritz ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix an ICE found in PR93686 2020-04-06 20:10 ` Fix an ICE found in PR93686 Fritz Reese @ 2020-04-06 21:47 ` Steve Kargl 2020-04-07 15:41 ` Fritz Reese 0 siblings, 1 reply; 3+ messages in thread From: Steve Kargl @ 2020-04-06 21:47 UTC (permalink / raw) To: Fritz Reese; +Cc: fortran, gcc-patches On Mon, Apr 06, 2020 at 04:10:24PM -0400, Fritz Reese wrote: > On Sat, Apr 4, 2020 at 2:58 PM Steve Kargl via Fortran > <fortran@gcc.gnu.org> wrote: > > > > This patch fixes the ICE found in PR93686. > > > > > > Index: gcc/fortran/decl.c > > =================================================================== > > --- gcc/fortran/decl.c (revision 280157) > > +++ gcc/fortran/decl.c (working copy) > > @@ -696,6 +696,10 @@ gfc_match_data (void) > > /* F2008:C567 (R536) A data-i-do-object or a variable that appears > > as a data-stmt-object shall not be an object designator in which > > a pointer appears other than as the entire rightmost part-ref. */ > > + if (!e->ref && e->ts.type == BT_DERIVED > > + && e->symtree->n.sym->attr.pointer) > > + goto partref; > > + > > ref = e->ref; > > if (e->symtree->n.sym->ts.type == BT_DERIVED > > && e->symtree->n.sym->attr.pointer > > > > -- > > Steve > > LGTM, thanks for the patch. I will commit along with the testcases from the PR. > Thanks. For reference, my original code did not check the left-most partref for the pointer attribute. This patch implements this check. BTW, if you haven't committed the degree trig functions, then I think you should to get the fixes in for 10.1. -- Steve ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix an ICE found in PR93686 2020-04-06 21:47 ` Steve Kargl @ 2020-04-07 15:41 ` Fritz Reese 0 siblings, 0 replies; 3+ messages in thread From: Fritz Reese @ 2020-04-07 15:41 UTC (permalink / raw) To: Steve Kargl; +Cc: fortran, gcc-patches On Mon, Apr 6, 2020 at 5:47 PM Steve Kargl <sgk@troutmask.apl.washington.edu> wrote: [...] > BTW, if you haven't committed the degree trig functions, > then I think you should to get the fixes in for 10.1. Roger that. --- Fritz ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-07 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200404185811.GA72336@troutmask.apl.washington.edu>
2020-04-06 20:10 ` Fix an ICE found in PR93686 Fritz Reese
2020-04-06 21:47 ` Steve Kargl
2020-04-07 15:41 ` Fritz Reese
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).