* [RFC/RFA][PATCH v2 02/12] Add built-ins and tests for bit-forward and bit-reversed CRCs
@ 2024-07-26 18:05 Mariam Arutunian
2024-08-25 17:45 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Mariam Arutunian @ 2024-07-26 18:05 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1.1: Type: text/plain, Size: 8627 bytes --]
This patch introduces new built-in functions to GCC for computing
bit-forward and bit-reversed CRCs.
These builtins aim to provide efficient CRC calculation capabilities.
When the target architecture supports CRC operations (as indicated by
the presence of a CRC optab),
the builtins will utilize the expander to generate CRC code.
In the absence of hardware support, the builtins default to generating
code for a table-based CRC calculation.
The built-ins are defined as follows:
__builtin_rev_crc16_data8,
__builtin_rev_crc32_data8, __builtin_rev_crc32_data16,
__builtin_rev_crc32_data32
__builtin_rev_crc64_data8, __builtin_rev_crc64_data16,
__builtin_rev_crc64_data32, __builtin_rev_crc64_data64,
__builtin_crc8_data8,
__builtin_crc16_data16, __builtin_crc16_data8,
__builtin_crc32_data8, __builtin_crc32_data16, __builtin_crc32_data32,
__builtin_crc64_data8, __builtin_crc64_data16, __builtin_crc64_data32,
__builtin_crc64_data64
Each built-in takes three parameters:
crc: The initial CRC value.
data: The data to be processed.
polynomial: The CRC polynomial without the leading 1.
To validate the correctness of these built-ins, this patch also includes
additions to the GCC testsuite.
This enhancement allows GCC to offer developers high-performance CRC
computation options
that automatically adapt to the capabilities of the target hardware.
Co-authored-by: Joern Rennecke <joern.rennecke@embecosm.com>
Not complete. May continue the work if these built-ins are needed.
gcc/
* builtin-types.def (BT_FN_UINT8_UINT8_UINT8_CONST_SIZE):
Define.
(BT_FN_UINT16_UINT16_UINT8_CONST_SIZE): Likewise.
(BT_FN_UINT16_UINT16_UINT16_CONST_SIZE): Likewise.
(BT_FN_UINT32_UINT32_UINT8_CONST_SIZE): Likewise.
(BT_FN_UINT32_UINT32_UINT16_CONST_SIZE): Likewise.
(BT_FN_UINT32_UINT32_UINT32_CONST_SIZE): Likewise.
(BT_FN_UINT64_UINT64_UINT8_CONST_SIZE): Likewise.
(BT_FN_UINT64_UINT64_UINT16_CONST_SIZE): Likewise.
(BT_FN_UINT64_UINT64_UINT32_CONST_SIZE): Likewise.
(BT_FN_UINT64_UINT64_UINT64_CONST_SIZE): Likewise.
* builtins.cc (associated_internal_fn): Handle
BUILT_IN_CRC8_DATA8,
BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
BUILT_IN_CRC32_DATA32,
BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
BUILT_IN_CRC64_DATA32,
BUILT_IN_CRC64_DATA64,
BUILT_IN_REV_CRC8_DATA8,
BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
BUILT_IN_REV_CRC32_DATA32.
(expand_builtin_crc_table_based): New function.
(expand_builtin): Handle BUILT_IN_CRC8_DATA8,
BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
BUILT_IN_CRC32_DATA32,
BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
BUILT_IN_CRC64_DATA32,
BUILT_IN_CRC64_DATA64,
BUILT_IN_REV_CRC8_DATA8,
BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
BUILT_IN_REV_CRC32_DATA32,
BUILT_IN_REV_CRC64_DATA8, BUILT_IN_REV_CRC64_DATA16,
BUILT_IN_REV_CRC64_DATA32,
BUILT_IN_REV_CRC64_DATA64.
* builtins.def (BUILT_IN_CRC8_DATA8): New builtin.
(BUILT_IN_CRC16_DATA8): Likewise.
(BUILT_IN_CRC16_DATA16): Likewise.
(BUILT_IN_CRC32_DATA8): Likewise.
(BUILT_IN_CRC32_DATA16): Likewise.
(BUILT_IN_CRC32_DATA32): Likewise.
(BUILT_IN_CRC64_DATA8): Likewise.
(BUILT_IN_CRC64_DATA16): Likewise.
(BUILT_IN_CRC64_DATA32): Likewise.
(BUILT_IN_CRC64_DATA64): Likewise.
(BUILT_IN_REV_CRC8_DATA8): New builtin.
(BUILT_IN_REV_CRC16_DATA8): Likewise.
(BUILT_IN_REV_CRC16_DATA16): Likewise.
(BUILT_IN_REV_CRC32_DATA8): Likewise.
(BUILT_IN_REV_CRC32_DATA16): Likewise.
(BUILT_IN_REV_CRC32_DATA32): Likewise.
(BUILT_IN_REV_CRC64_DATA8): Likewise.
(BUILT_IN_REV_CRC64_DATA16): Likewise.
(BUILT_IN_REV_CRC64_DATA32): Likewise.
(BUILT_IN_REV_CRC64_DATA64): Likewise.
* builtins.h (expand_builtin_crc_table_based): New function
declaration.
* doc/extend.texti (__builtin_rev_crc8_data8,
__builtin_rev_crc16_data16, __builtin_rev_crc16_data8,
__builtin_rev_crc32_data32, __builtin_rev_crc32_data8,
__builtin_rev_crc32_data16, __builtin_rev_crc64_data64,
__builtin_rev_crc64_data8, __builtin_rev_crc64_data16,
__builtin_rev_crc64_data32, __builtin_crc8_data8,
__builtin_crc16_data16, __builtin_crc16_data8,
__builtin_crc32_data32, __builtin_crc32_data8,
__builtin_crc32_data16, __builtin_crc64_data64,
__builtin_crc64_data8, __builtin_crc64_data16,
__builtin_crc64_data32): Document.
gcc/testsuite/
(BT_FN_UINT64_UINT64_UINT64_CONST_SIZE): Likewise.
* builtins.cc (associated_internal_fn): Handle
BUILT_IN_CRC8_DATA8,
BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
BUILT_IN_CRC32_DATA32,
BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
BUILT_IN_CRC64_DATA32,
BUILT_IN_CRC64_DATA64,
BUILT_IN_REV_CRC8_DATA8,
BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
BUILT_IN_REV_CRC32_DATA32.
(expand_builtin_crc_table_based): New function.
(expand_builtin): Handle BUILT_IN_CRC8_DATA8,
BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
BUILT_IN_CRC32_DATA32,
BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
BUILT_IN_CRC64_DATA32,
BUILT_IN_CRC64_DATA64,
BUILT_IN_REV_CRC8_DATA8,
BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
BUILT_IN_REV_CRC32_DATA32,
BUILT_IN_REV_CRC64_DATA8, BUILT_IN_REV_CRC64_DATA16,
BUILT_IN_REV_CRC64_DATA32,
BUILT_IN_REV_CRC64_DATA64.
* builtins.def (BUILT_IN_CRC8_DATA8): New builtin.
(BUILT_IN_CRC16_DATA8): Likewise.
(BUILT_IN_CRC16_DATA16): Likewise.
(BUILT_IN_CRC32_DATA8): Likewise.
(BUILT_IN_CRC32_DATA16): Likewise.
(BUILT_IN_CRC32_DATA32): Likewise.
(BUILT_IN_CRC64_DATA8): Likewise.
(BUILT_IN_CRC64_DATA16): Likewise.
(BUILT_IN_CRC64_DATA32): Likewise.
(BUILT_IN_CRC64_DATA64): Likewise.
(BUILT_IN_REV_CRC8_DATA8): New builtin.
(BUILT_IN_REV_CRC16_DATA8): Likewise.
(BUILT_IN_REV_CRC16_DATA16): Likewise.
(BUILT_IN_REV_CRC32_DATA8): Likewise.
(BUILT_IN_REV_CRC32_DATA16): Likewise.
(BUILT_IN_REV_CRC32_DATA32): Likewise.
(BUILT_IN_REV_CRC64_DATA8): Likewise.
(BUILT_IN_REV_CRC64_DATA16): Likewise.
(BUILT_IN_REV_CRC64_DATA32): Likewise.
(BUILT_IN_REV_CRC64_DATA64): Likewise.
* builtins.h (expand_builtin_crc_table_based): New function
declaration.
* doc/extend.texti (__builtin_rev_crc8_data8,
__builtin_rev_crc16_data16, __builtin_rev_crc16_data8,
__builtin_rev_crc32_data32, __builtin_rev_crc32_data8,
__builtin_rev_crc32_data16, __builtin_rev_crc64_data64,
__builtin_rev_crc64_data8, __builtin_rev_crc64_data16,
__builtin_rev_crc64_data32, __builtin_crc8_data8,
__builtin_crc16_data16, __builtin_crc16_data8,
__builtin_crc32_data32, __builtin_crc32_data8,
__builtin_crc32_data16, __builtin_crc64_data64,
__builtin_crc64_data8, __builtin_crc64_data16,
__builtin_crc64_data32): Document.
gcc/testsuite/
* gcc.dg/crc-builtin-rev-target32.c
* gcc.dg/crc-builtin-rev-target64.c
* gcc.dg/crc-builtin-target32.c
* gcc.dg/crc-builtin-target64.c
Signed-off-by: Mariam Arutunian <mariamarutunian@gmail.com>
[-- Attachment #2: 0002-Add-built-ins-and-tests-for-bit-forward-and-bit-reve.patch --]
[-- Type: text/x-patch, Size: 22391 bytes --]
diff --git a/gcc/builtin-types.def b/gcc/builtin-types.def
index c97d6bad1de..a0c4b8b9ca6 100644
--- a/gcc/builtin-types.def
+++ b/gcc/builtin-types.def
@@ -829,6 +829,26 @@ DEF_FUNCTION_TYPE_3 (BT_FN_PTR_SIZE_SIZE_PTRMODE,
BT_PTR, BT_SIZE, BT_SIZE, BT_PTRMODE)
DEF_FUNCTION_TYPE_3 (BT_FN_VOID_PTR_UINT8_PTRMODE, BT_VOID, BT_PTR, BT_UINT8,
BT_PTRMODE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT8_UINT8_UINT8_CONST_SIZE, BT_UINT8, BT_UINT8,
+ BT_UINT8, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT16_UINT16_UINT8_CONST_SIZE, BT_UINT16, BT_UINT16,
+ BT_UINT8, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT16_UINT16_UINT16_CONST_SIZE, BT_UINT16,
+ BT_UINT16, BT_UINT16, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT32_UINT32_UINT8_CONST_SIZE, BT_UINT32, BT_UINT32,
+ BT_UINT8, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT32_UINT32_UINT16_CONST_SIZE, BT_UINT32,
+ BT_UINT32, BT_UINT16, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT32_UINT32_UINT32_CONST_SIZE, BT_UINT32,
+ BT_UINT32, BT_UINT32, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT64_UINT64_UINT8_CONST_SIZE, BT_UINT64, BT_UINT64,
+ BT_UINT8, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT64_UINT64_UINT16_CONST_SIZE, BT_UINT64,
+ BT_UINT64, BT_UINT16, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT64_UINT64_UINT32_CONST_SIZE, BT_UINT64,
+ BT_UINT64, BT_UINT32, BT_CONST_SIZE)
+DEF_FUNCTION_TYPE_3 (BT_FN_UINT64_UINT64_UINT64_CONST_SIZE, BT_UINT64,
+ BT_UINT64, BT_UINT64, BT_CONST_SIZE)
DEF_FUNCTION_TYPE_4 (BT_FN_SIZE_CONST_PTR_SIZE_SIZE_FILEPTR,
BT_SIZE, BT_CONST_PTR, BT_SIZE, BT_SIZE, BT_FILEPTR)
diff --git a/gcc/builtins.cc b/gcc/builtins.cc
index f8d94c4b435..0d1751fca87 100644
--- a/gcc/builtins.cc
+++ b/gcc/builtins.cc
@@ -2207,7 +2207,28 @@ associated_internal_fn (built_in_function fn, tree return_type)
if (REAL_MODE_FORMAT (TYPE_MODE (return_type))->b == 2)
return IFN_LDEXP;
return IFN_LAST;
-
+ case BUILT_IN_CRC8_DATA8:
+ case BUILT_IN_CRC16_DATA8:
+ case BUILT_IN_CRC16_DATA16:
+ case BUILT_IN_CRC32_DATA8:
+ case BUILT_IN_CRC32_DATA16:
+ case BUILT_IN_CRC32_DATA32:
+ case BUILT_IN_CRC64_DATA8:
+ case BUILT_IN_CRC64_DATA16:
+ case BUILT_IN_CRC64_DATA32:
+ case BUILT_IN_CRC64_DATA64:
+ return IFN_CRC;
+ case BUILT_IN_REV_CRC8_DATA8:
+ case BUILT_IN_REV_CRC16_DATA8:
+ case BUILT_IN_REV_CRC16_DATA16:
+ case BUILT_IN_REV_CRC32_DATA8:
+ case BUILT_IN_REV_CRC32_DATA16:
+ case BUILT_IN_REV_CRC32_DATA32:
+ case BUILT_IN_REV_CRC64_DATA8:
+ case BUILT_IN_REV_CRC64_DATA16:
+ case BUILT_IN_REV_CRC64_DATA32:
+ case BUILT_IN_REV_CRC64_DATA64:
+ return IFN_CRC_REV;
default:
return IFN_LAST;
}
@@ -7751,6 +7772,37 @@ expand_speculation_safe_value (machine_mode mode, tree exp, rtx target,
return targetm.speculation_safe_value (mode, target, val, failsafe);
}
+/* Expand CRC* or REV_CRC* built-ins. */
+
+rtx
+expand_builtin_crc_table_based (internal_fn fn, scalar_mode data_mode,
+ scalar_mode crc_mode, machine_mode mode,
+ tree exp, rtx target)
+{
+ tree rhs1 = CALL_EXPR_ARG (exp, 0); // crc
+ tree rhs2 = CALL_EXPR_ARG (exp, 1); // data
+ tree rhs3 = CALL_EXPR_ARG (exp, 2); // polynomial
+
+ gcc_assert (word_mode >= crc_mode);
+
+ if (!target || mode == VOIDmode)
+ target = gen_reg_rtx (crc_mode);
+
+ rtx op1 = expand_normal (rhs1);
+ rtx op2 = expand_normal (rhs2);
+ gcc_assert (TREE_CODE (rhs3) == INTEGER_CST);
+ rtx op3 = gen_int_mode (TREE_INT_CST_LOW (rhs3), crc_mode);
+
+ if (fn == IFN_CRC)
+ expand_crc_table_based (target, op1, op2, op3, data_mode);
+ else
+ /* If it's IFN_CRC_REV generate bit-reversed CRC. */
+ expand_reversed_crc_table_based (target, op1, op2, op3,
+ data_mode,
+ generate_reflecting_code_standard);
+ return target;
+}
+
/* Expand an expression EXP that calls a built-in function,
with result going to TARGET if that's convenient
(and in mode MODE if that's convenient).
@@ -8928,6 +8980,66 @@ expand_builtin (tree exp, rtx target, rtx subtarget, machine_mode mode,
mode = get_builtin_sync_mode (fcode - BUILT_IN_SPECULATION_SAFE_VALUE_1);
return expand_speculation_safe_value (mode, exp, target, ignore);
+ case BUILT_IN_CRC8_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC, QImode, QImode, mode,
+ exp, target);
+ case BUILT_IN_CRC16_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC, HImode, QImode, mode,
+ exp, target);
+ case BUILT_IN_CRC16_DATA16:
+ return expand_builtin_crc_table_based (IFN_CRC, HImode, HImode, mode,
+ exp, target);
+ case BUILT_IN_CRC32_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC, SImode, QImode, mode,
+ exp, target);
+ case BUILT_IN_CRC32_DATA16:
+ return expand_builtin_crc_table_based (IFN_CRC, SImode, HImode, mode,
+ exp, target);
+ case BUILT_IN_CRC32_DATA32:
+ return expand_builtin_crc_table_based (IFN_CRC, SImode, SImode, mode,
+ exp, target);
+ case BUILT_IN_CRC64_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, QImode, mode,
+ exp, target);
+ case BUILT_IN_CRC64_DATA16:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, HImode, mode,
+ exp, target);
+ case BUILT_IN_CRC64_DATA32:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, SImode, mode,
+ exp, target);
+ case BUILT_IN_CRC64_DATA64:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, DImode, mode,
+ exp, target);
+ case BUILT_IN_REV_CRC8_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC_REV, QImode, QImode,
+ mode, exp, target);
+ case BUILT_IN_REV_CRC16_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC_REV, HImode, QImode,
+ mode, exp, target);
+ case BUILT_IN_REV_CRC16_DATA16:
+ return expand_builtin_crc_table_based (IFN_CRC_REV, HImode, HImode,
+ mode, exp, target);
+ case BUILT_IN_REV_CRC32_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC_REV, SImode, QImode,
+ mode, exp, target);
+ case BUILT_IN_REV_CRC32_DATA16:
+ return expand_builtin_crc_table_based (IFN_CRC_REV, SImode, HImode,
+ mode, exp, target);
+ case BUILT_IN_REV_CRC32_DATA32:
+ return expand_builtin_crc_table_based (IFN_CRC_REV, SImode, SImode,
+ mode, exp, target);
+ case BUILT_IN_REV_CRC64_DATA8:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, QImode, mode,
+ exp, target);
+ case BUILT_IN_REV_CRC64_DATA16:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, HImode, mode,
+ exp, target);
+ case BUILT_IN_REV_CRC64_DATA32:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, SImode, mode,
+ exp, target);
+ case BUILT_IN_REV_CRC64_DATA64:
+ return expand_builtin_crc_table_based (IFN_CRC, DImode, DImode, mode,
+ exp, target);
default: /* just do library call, if unknown builtin */
break;
}
diff --git a/gcc/builtins.def b/gcc/builtins.def
index f6f3e104f6a..085602603d9 100644
--- a/gcc/builtins.def
+++ b/gcc/builtins.def
@@ -704,7 +704,26 @@ DEF_EXT_LIB_BUILTIN (BUILT_IN_Y1L, "y1l", BT_FN_LONGDOUBLE_LONGDOUBLE, ATTR_M
DEF_EXT_LIB_BUILTIN (BUILT_IN_YN, "yn", BT_FN_DOUBLE_INT_DOUBLE, ATTR_MATHFN_FPROUNDING_ERRNO)
DEF_EXT_LIB_BUILTIN (BUILT_IN_YNF, "ynf", BT_FN_FLOAT_INT_FLOAT, ATTR_MATHFN_FPROUNDING_ERRNO)
DEF_EXT_LIB_BUILTIN (BUILT_IN_YNL, "ynl", BT_FN_LONGDOUBLE_INT_LONGDOUBLE, ATTR_MATHFN_FPROUNDING_ERRNO)
-
+DEF_GCC_BUILTIN (BUILT_IN_CRC8_DATA8, "crc8_data8", BT_FN_UINT8_UINT8_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC16_DATA8, "crc16_data8", BT_FN_UINT16_UINT16_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC16_DATA16, "crc16_data16", BT_FN_UINT16_UINT16_UINT16_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC32_DATA8, "crc32_data8", BT_FN_UINT32_UINT32_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC32_DATA16, "crc32_data16", BT_FN_UINT32_UINT32_UINT16_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC32_DATA32, "crc32_data32", BT_FN_UINT32_UINT32_UINT32_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC64_DATA8, "crc64_data8", BT_FN_UINT64_UINT64_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC64_DATA16, "crc64_data16", BT_FN_UINT64_UINT64_UINT16_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC64_DATA32, "crc64_data32", BT_FN_UINT64_UINT64_UINT32_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_CRC64_DATA64, "crc64_data64", BT_FN_UINT64_UINT64_UINT64_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC8_DATA8, "rev_crc8_data8", BT_FN_UINT8_UINT8_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC16_DATA8, "rev_crc16_data8", BT_FN_UINT16_UINT16_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC16_DATA16, "rev_crc16_data16", BT_FN_UINT16_UINT16_UINT16_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC32_DATA8, "rev_crc32_data8", BT_FN_UINT32_UINT32_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC32_DATA16, "rev_crc32_data16", BT_FN_UINT32_UINT32_UINT16_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC32_DATA32, "rev_crc32_data32", BT_FN_UINT32_UINT32_UINT32_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC64_DATA8, "rev_crc64_data8", BT_FN_UINT64_UINT64_UINT8_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC64_DATA16, "rev_crc64_data16", BT_FN_UINT64_UINT64_UINT16_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC64_DATA32, "rev_crc64_data32", BT_FN_UINT64_UINT64_UINT32_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
+DEF_GCC_BUILTIN (BUILT_IN_REV_CRC64_DATA64, "rev_crc64_data64", BT_FN_UINT64_UINT64_UINT64_CONST_SIZE, ATTR_CONST_NOTHROW_LEAF_LIST)
/* Category: _Complex math builtins. */
DEF_C99_COMPL_BUILTIN (BUILT_IN_CABS, "cabs", BT_FN_DOUBLE_COMPLEX_DOUBLE, ATTR_MATHFN_FPROUNDING)
DEF_C99_COMPL_BUILTIN (BUILT_IN_CABSF, "cabsf", BT_FN_FLOAT_COMPLEX_FLOAT, ATTR_MATHFN_FPROUNDING)
diff --git a/gcc/builtins.h b/gcc/builtins.h
index 8d93f75a9a4..0094b9dcc3f 100644
--- a/gcc/builtins.h
+++ b/gcc/builtins.h
@@ -133,6 +133,9 @@ extern void expand_builtin_trap (void);
extern void expand_ifn_atomic_bit_test_and (gcall *);
extern void expand_ifn_atomic_compare_exchange (gcall *);
extern void expand_ifn_atomic_op_fetch_cmp_0 (gcall *);
+extern rtx expand_builtin_crc_table_based (internal_fn, scalar_mode,
+ scalar_mode, machine_mode,
+ tree, rtx);
extern rtx expand_builtin (tree, rtx, rtx, machine_mode, int);
extern enum built_in_function builtin_mathfn_code (const_tree);
extern tree fold_builtin_expect (location_t, tree, tree, tree, tree);
diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
index 8786249fb6f..932847b34f9 100644
--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -15835,6 +15835,115 @@ Returns the openacc gang, worker or vector size depending on whether @var{x} is
0, 1 or 2.
@enddefbuiltin
+@defbuiltin{uint8_t __builtin_rev_crc8_data8 (uint8_t @var{crc}, uint8_t @var{data}, uint8_t @var{poly})}
+Returns the calculated 8-bit bit-reversed CRC using the initial CRC (8-bit),
+data (8-bit) and the polynomial (8-bit).
+@var{crc} is the initial CRC, @var{data} is the data and
+@var{poly} is the polynomial without leading 1.
+Table-based or clmul-based CRC may be used for the
+calculation, depending on the target architecture.
+@enddefbuiltin
+
+@defbuiltin{uint16_t __builtin_rev_crc16_data16 (uint16_t @var{crc}, uint16_t @var{data}, uint16_t @var{poly})}
+Similar to @code{__builtin_rev_crc8_data8}, except the argument and return types
+are 16-bit.
+@enddefbuiltin
+
+@defbuiltin{uint16_t __builtin_rev_crc16_data8 (uint16_t @var{crc}, uint8_t @var{data}, uint16_t @var{poly})}
+Similar to @code{__builtin_rev_crc16_data16}, except the @var{data} argument
+type is 8-bit.
+@enddefbuiltin
+
+@defbuiltin{uint32_t __builtin_rev_crc32_data32 (uint32_t @var{crc}, uint32_t @var{data}, uint32_t @var{poly})}
+Similar to @code{__builtin_rev_crc8_data8}, except the argument and return types
+are 32-bit and for the CRC calculation may be also used crc* machine instruction
+depending on the target and the polynomial.
+@enddefbuiltin
+
+@defbuiltin{uint32_t __builtin_rev_crc32_data8 (uint32_t @var{crc}, uint8_t @var{data}, uint32_t @var{poly})}
+Similar to @code{__builtin_rev_crc32_data32}, except the @var{data} argument
+type is 8-bit.
+@enddefbuiltin
+
+@defbuiltin{uint32_t __builtin_rev_crc32_data16 (uint32_t @var{crc}, uint16_t @var{data}, uint32_t @var{poly})}
+Similar to @code{__builtin_rev_crc32_data32}, except the @var{data} argument
+type is 16-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_rev_crc64_data64 (uint64_t @var{crc}, uint64_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_rev_crc8_data8}, except the argument and return types
+are 64-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_rev_crc64_data8 (uint64_t @var{crc}, uint8_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_rev_crc64_data64}, except the @var{data} argument type
+is 8-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_rev_crc64_data16 (uint64_t @var{crc}, uint16_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_rev_crc64_data64}, except the @var{data} argument type
+is 16-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_rev_crc64_data32 (uint64_t @var{crc}, uint32_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_rev_crc64_data64}, except the @var{data} argument type
+is 32-bit.
+@enddefbuiltin
+
+@defbuiltin{uint8_t __builtin_crc8_data8 (uint8_t @var{crc}, uint8_t @var{data}, uint8_t @var{poly})}
+Returns the calculated 8-bit bit-forward CRC using the initial CRC (8-bit),
+data (8-bit) and the polynomial (8-bit).
+@var{crc} is the initial CRC, @var{data} is the data and
+@var{poly} is the polynomial without leading 1.
+Table-based or clmul-based CRC may be used for the
+calculation, depending on the target architecture.
+@enddefbuiltin
+
+@defbuiltin{uint16_t __builtin_crc16_data16 (uint16_t @var{crc}, uint16_t @var{data}, uint16_t @var{poly})}
+Similar to @code{__builtin_crc8_data8}, except the argument and return types
+are 16-bit.
+@enddefbuiltin
+
+@defbuiltin{uint16_t __builtin_crc16_data8 (uint16_t @var{crc}, uint8_t @var{data}, uint16_t @var{poly})}
+Similar to @code{__builtin_crc16_data16}, except the @var{data} argument type
+is 8-bit.
+@enddefbuiltin
+
+@defbuiltin{uint32_t __builtin_crc32_data32 (uint32_t @var{crc}, uint32_t @var{data}, uint32_t @var{poly})}
+Similar to @code{__builtin_crc8_data8}, except the argument and return types
+are 32-bit.
+@enddefbuiltin
+
+@defbuiltin{uint32_t __builtin_crc32_data8 (uint32_t @var{crc}, uint8_t @var{data}, uint32_t @var{poly})}
+Similar to @code{__builtin_crc32_data32}, except the @var{data} argument type
+is 8-bit.
+@enddefbuiltin
+
+@defbuiltin{uint32_t __builtin_crc32_data16 (uint32_t @var{crc}, uint16_t @var{data}, uint32_t @var{poly})}
+Similar to @code{__builtin_crc32_data32}, except the @var{data} argument type
+is 16-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_crc64_data64 (uint64_t @var{crc}, uint64_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_crc8_data8}, except the argument and return types
+are 64-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_crc64_data8 (uint64_t @var{crc}, uint8_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_crc64_data64}, except the @var{data} argument type
+is 8-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_crc64_data16 (uint64_t @var{crc}, uint16_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_crc64_data64}, except the @var{data} argument type
+is 16-bit.
+@enddefbuiltin
+
+@defbuiltin{uint64_t __builtin_crc64_data32 (uint64_t @var{crc}, uint32_t @var{data}, uint64_t @var{poly})}
+Similar to @code{__builtin_crc64_data64}, except the @var{data} argument type
+is 32-bit.
+@enddefbuiltin
+
@node Target Builtins
@section Built-in Functions Specific to Particular Target Machines
diff --git a/gcc/testsuite/gcc.dg/crc-builtin-rev-target32.c b/gcc/testsuite/gcc.dg/crc-builtin-rev-target32.c
new file mode 100644
index 00000000000..c068c14edce
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/crc-builtin-rev-target32.c
@@ -0,0 +1,37 @@
+/* { dg-do compile } */
+
+#include <stdint-gcc.h>
+
+int8_t rev_crc8_data8 ()
+{
+ return __builtin_rev_crc8_data8 (0x34, 'a', 0x12);
+}
+
+int16_t rev_crc16_data8 ()
+{
+ return __builtin_rev_crc16_data8 (0x1234, 'a', 0x1021);
+}
+
+int16_t rev_crc16_data16 ()
+{
+ return __builtin_rev_crc16_data16 (0x1234, 0x3214, 0x1021);
+}
+
+int32_t rev_crc32_data8 ()
+{
+ return __builtin_rev_crc32_data8 (0xffffffff, 0x32, 0x4002123);
+}
+
+int32_t rev_crc32_data16 ()
+{
+ return __builtin_rev_crc32_data16 (0xffffffff, 0x3232, 0x4002123);
+}
+
+int32_t rev_crc32_data32 ()
+{
+ return __builtin_rev_crc32_data32 (0xffffffff, 0x123546ff, 0x4002123);
+}
+
+/* { dg-final { scan-assembler "crc_table_for_crc_8_polynomial_0x12|mul"} } */
+/* { dg-final { scan-assembler "crc_table_for_crc_16_polynomial_0x1021|mul"} } */
+/* { dg-final { scan-assembler "crc_table_for_crc_32_polynomial_0x4002123|mul"} } */
\ No newline at end of file
diff --git a/gcc/testsuite/gcc.dg/crc-builtin-rev-target64.c b/gcc/testsuite/gcc.dg/crc-builtin-rev-target64.c
new file mode 100644
index 00000000000..1eb6969068f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/crc-builtin-rev-target64.c
@@ -0,0 +1,60 @@
+/* { dg-do compile { target lp64 } } */
+#include <stdint-gcc.h>
+
+int8_t rev_crc8_data8 ()
+{
+ return __builtin_rev_crc8_data8 (0x34, 'a', 0x12);
+}
+
+int16_t rev_crc16_data8 ()
+{
+ return __builtin_rev_crc16_data8 (0x1234, 'a', 0x1021);
+}
+
+int16_t rev_crc16_data16 ()
+{
+ return __builtin_rev_crc16_data16 (0x1234, 0x3214, 0x1021);
+}
+
+int32_t rev_crc32_data8 ()
+{
+ return __builtin_rev_crc32_data8 (0xffffffff, 0x32, 0x4002123);
+}
+
+int32_t rev_crc32_data16 ()
+{
+ return __builtin_rev_crc32_data16 (0xffffffff, 0x3232, 0x4002123);
+}
+
+int32_t rev_crc32_data32 ()
+{
+ return __builtin_rev_crc32_data32 (0xffffffff, 0x123546ff, 0x4002123);
+}
+
+int64_t rev_crc64_data8 ()
+{
+ return __builtin_rev_crc64_data8 (0xffffffffffffffff, 0x32,
+ 0x40021234002123);
+}
+
+int64_t rev_crc64_data16 ()
+{
+ return __builtin_rev_crc64_data16 (0xffffffffffffffff, 0x3232,
+ 0x40021234002123);
+}
+
+int64_t rev_crc64_data32 ()
+{
+ return __builtin_rev_crc64_data32 (0xffffffffffffffff, 0x123546ff,
+ 0x40021234002123);
+}
+
+int64_t rev_crc64_data64 ()
+{
+ return __builtin_rev_crc64_data64 (0xffffffffffffffff, 0x123546ff123546ff,
+ 0x40021234002123);
+}
+
+/* { dg-final { scan-assembler "crc_table_for_crc_8_polynomial_0x12|mul" } } */
+/* { dg-final { scan-assembler "crc_table_for_crc_16_polynomial_0x1021|mul" } } */
+/* { dg-final { scan-assembler "crc_table_for_crc_32_polynomial_0x4002123|mul" } } */
\ No newline at end of file
diff --git a/gcc/testsuite/gcc.dg/crc-builtin-target32.c b/gcc/testsuite/gcc.dg/crc-builtin-target32.c
new file mode 100644
index 00000000000..9cdd38f5364
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/crc-builtin-target32.c
@@ -0,0 +1,37 @@
+/* { dg-do compile } */
+
+#include <stdint-gcc.h>
+
+int8_t crc8_data8 ()
+{
+ return __builtin_crc8_data8 (0x34, 'a', 0x12);
+}
+
+int16_t crc16_data8 ()
+{
+ return __builtin_crc16_data8 (0x1234, 'a', 0x1021);
+}
+
+int16_t crc16_data16 ()
+{
+ return __builtin_crc16_data16 (0x1234, 0x3214, 0x1021);
+}
+
+int32_t crc32_data8 ()
+{
+ return __builtin_crc32_data8 (0xffffffff, 0x32, 0x4002123);
+}
+
+int32_t crc32_data16 ()
+{
+ return __builtin_crc32_data16 (0xffffffff, 0x3232, 0x4002123);
+}
+
+int32_t crc32_data32 ()
+{
+ return __builtin_crc32_data32 (0xffffffff, 0x123546ff, 0x4002123);
+}
+
+/* { dg-final { scan-assembler "crc_table_for_crc_8_polynomial_0x12|mul" } } */
+/* { dg-final { scan-assembler "crc_table_for_crc_16_polynomial_0x1021|mul"} } */
+/* { dg-final { scan-assembler "crc_table_for_crc_32_polynomial_0x4002123|mul"} } */
diff --git a/gcc/testsuite/gcc.dg/crc-builtin-target64.c b/gcc/testsuite/gcc.dg/crc-builtin-target64.c
new file mode 100644
index 00000000000..41884be0fbc
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/crc-builtin-target64.c
@@ -0,0 +1,59 @@
+/* { dg-do compile { target lp64 } } */
+#include <stdint-gcc.h>
+
+int8_t crc8_data8 ()
+{
+ return __builtin_crc8_data8 (0x34, 'a', 0x12);
+}
+
+int16_t crc16_data8 ()
+{
+ return __builtin_crc16_data8 (0x1234, 'a', 0x1021);
+}
+
+int16_t crc16_data16 ()
+{
+ return __builtin_crc16_data16 (0x1234, 0x3214, 0x1021);
+}
+
+int32_t crc32_data8 ()
+{
+ return __builtin_crc32_data8 (0xffffffff, 0x32, 0x4002123);
+}
+
+int32_t crc32_data16 ()
+{
+ return __builtin_crc32_data16 (0xffffffff, 0x3232, 0x4002123);
+}
+
+int32_t crc32_data32 ()
+{
+ return __builtin_crc32_data32 (0xffffffff, 0x123546ff, 0x4002123);
+}
+
+int64_t crc64_data8 ()
+{
+ return __builtin_crc64_data8 (0xffffffffffffffff, 0x32, 0x40021234002123);
+}
+
+int64_t crc64_data16 ()
+{
+ return __builtin_crc64_data16 (0xffffffffffffffff, 0x3232, 0x40021234002123);
+}
+
+int64_t crc64_data32 ()
+{
+ return __builtin_crc64_data32 (0xffffffffffffffff, 0x123546ff,
+ 0x40021234002123);
+}
+
+int64_t crc64_data64 ()
+{
+ return __builtin_crc64_data64 (0xffffffffffffffff, 0x123546ff123546ff,
+ 0x40021234002123);
+}
+
+/* { dg-final { scan-assembler "crc_table_for_crc_8_polynomial_0x12|mul" } } */
+/* { dg-final { scan-assembler "crc_table_for_crc_16_polynomial_0x1021|mul" } } */
+/* { dg-final { scan-assembler "crc_table_for_crc_32_polynomial_0x4002123|mul" } } */
+/* { dg-final { scan-assembler "crc_table_for_crc_64_polynomial_0x40021234002123|mul" } } */
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC/RFA][PATCH v2 02/12] Add built-ins and tests for bit-forward and bit-reversed CRCs
2024-07-26 18:05 [RFC/RFA][PATCH v2 02/12] Add built-ins and tests for bit-forward and bit-reversed CRCs Mariam Arutunian
@ 2024-08-25 17:45 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2024-08-25 17:45 UTC (permalink / raw)
To: Mariam Arutunian, GCC Patches
On 7/26/24 12:05 PM, Mariam Arutunian wrote:
> This patch introduces new built-in functions to GCC for computing
> bit-forward and bit-reversed CRCs.
> These builtins aim to provide efficient CRC calculation capabilities.
> When the target architecture supports CRC operations (as indicated
> by the presence of a CRC optab),
> the builtins will utilize the expander to generate CRC code.
> In the absence of hardware support, the builtins default to
> generating code for a table-based CRC calculation.
>
> The built-ins are defined as follows:
> __builtin_rev_crc16_data8,
> __builtin_rev_crc32_data8, __builtin_rev_crc32_data16,
> __builtin_rev_crc32_data32
> __builtin_rev_crc64_data8, __builtin_rev_crc64_data16,
> __builtin_rev_crc64_data32, __builtin_rev_crc64_data64,
> __builtin_crc8_data8,
> __builtin_crc16_data16, __builtin_crc16_data8,
> __builtin_crc32_data8, __builtin_crc32_data16, __builtin_crc32_data32,
> __builtin_crc64_data8, __builtin_crc64_data16,
> __builtin_crc64_data32, __builtin_crc64_data64
>
> Each built-in takes three parameters:
> crc: The initial CRC value.
> data: The data to be processed.
> polynomial: The CRC polynomial without the leading 1.
>
> To validate the correctness of these built-ins, this patch also
> includes additions to the GCC testsuite.
> This enhancement allows GCC to offer developers high-performance CRC
> computation options
> that automatically adapt to the capabilities of the target hardware.
>
> Co-authored-by: Joern Rennecke <joern.rennecke@embecosm.com
> <mailto:joern.rennecke@embecosm.com>>
>
> Not complete. May continue the work if these built-ins are needed.
>
> gcc/
>
> * builtin-types.def (BT_FN_UINT8_UINT8_UINT8_CONST_SIZE):
> Define.
> (BT_FN_UINT16_UINT16_UINT8_CONST_SIZE): Likewise.
> (BT_FN_UINT16_UINT16_UINT16_CONST_SIZE): Likewise.
> (BT_FN_UINT32_UINT32_UINT8_CONST_SIZE): Likewise.
> (BT_FN_UINT32_UINT32_UINT16_CONST_SIZE): Likewise.
> (BT_FN_UINT32_UINT32_UINT32_CONST_SIZE): Likewise.
> (BT_FN_UINT64_UINT64_UINT8_CONST_SIZE): Likewise.
> (BT_FN_UINT64_UINT64_UINT16_CONST_SIZE): Likewise.
> (BT_FN_UINT64_UINT64_UINT32_CONST_SIZE): Likewise.
> (BT_FN_UINT64_UINT64_UINT64_CONST_SIZE): Likewise.
> * builtins.cc (associated_internal_fn): Handle
> BUILT_IN_CRC8_DATA8,
> BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
> BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
> BUILT_IN_CRC32_DATA32,
> BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
> BUILT_IN_CRC64_DATA32,
> BUILT_IN_CRC64_DATA64,
> BUILT_IN_REV_CRC8_DATA8,
> BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
> BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
> BUILT_IN_REV_CRC32_DATA32.
> (expand_builtin_crc_table_based): New function.
> (expand_builtin): Handle BUILT_IN_CRC8_DATA8,
> BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
> BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
> BUILT_IN_CRC32_DATA32,
> BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
> BUILT_IN_CRC64_DATA32,
> BUILT_IN_CRC64_DATA64,
> BUILT_IN_REV_CRC8_DATA8,
> BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
> BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
> BUILT_IN_REV_CRC32_DATA32,
> BUILT_IN_REV_CRC64_DATA8, BUILT_IN_REV_CRC64_DATA16,
> BUILT_IN_REV_CRC64_DATA32,
> BUILT_IN_REV_CRC64_DATA64.
> * builtins.def (BUILT_IN_CRC8_DATA8): New builtin.
> (BUILT_IN_CRC16_DATA8): Likewise.
> (BUILT_IN_CRC16_DATA16): Likewise.
> (BUILT_IN_CRC32_DATA8): Likewise.
> (BUILT_IN_CRC32_DATA16): Likewise.
> (BUILT_IN_CRC32_DATA32): Likewise.
> (BUILT_IN_CRC64_DATA8): Likewise.
> (BUILT_IN_CRC64_DATA16): Likewise.
> (BUILT_IN_CRC64_DATA32): Likewise.
> (BUILT_IN_CRC64_DATA64): Likewise.
> (BUILT_IN_REV_CRC8_DATA8): New builtin.
> (BUILT_IN_REV_CRC16_DATA8): Likewise.
> (BUILT_IN_REV_CRC16_DATA16): Likewise.
> (BUILT_IN_REV_CRC32_DATA8): Likewise.
> (BUILT_IN_REV_CRC32_DATA16): Likewise.
> (BUILT_IN_REV_CRC32_DATA32): Likewise.
> (BUILT_IN_REV_CRC64_DATA8): Likewise.
> (BUILT_IN_REV_CRC64_DATA16): Likewise.
> (BUILT_IN_REV_CRC64_DATA32): Likewise.
> (BUILT_IN_REV_CRC64_DATA64): Likewise.
> * builtins.h (expand_builtin_crc_table_based): New
> function declaration.
> * doc/extend.texti (__builtin_rev_crc8_data8,
> __builtin_rev_crc16_data16, __builtin_rev_crc16_data8,
> __builtin_rev_crc32_data32, __builtin_rev_crc32_data8,
> __builtin_rev_crc32_data16, __builtin_rev_crc64_data64,
> __builtin_rev_crc64_data8, __builtin_rev_crc64_data16,
> __builtin_rev_crc64_data32, __builtin_crc8_data8,
> __builtin_crc16_data16, __builtin_crc16_data8,
> __builtin_crc32_data32, __builtin_crc32_data8,
> __builtin_crc32_data16, __builtin_crc64_data64,
> __builtin_crc64_data8, __builtin_crc64_data16,
> __builtin_crc64_data32): Document.
>
> gcc/testsuite/
>
> (BT_FN_UINT64_UINT64_UINT64_CONST_SIZE): Likewise.
> * builtins.cc (associated_internal_fn): Handle
> BUILT_IN_CRC8_DATA8,
> BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
> BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
> BUILT_IN_CRC32_DATA32,
> BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
> BUILT_IN_CRC64_DATA32,
> BUILT_IN_CRC64_DATA64,
> BUILT_IN_REV_CRC8_DATA8,
> BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
> BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
> BUILT_IN_REV_CRC32_DATA32.
> (expand_builtin_crc_table_based): New function.
> (expand_builtin): Handle BUILT_IN_CRC8_DATA8,
> BUILT_IN_CRC16_DATA8, BUILT_IN_CRC16_DATA16,
> BUILT_IN_CRC32_DATA8, BUILT_IN_CRC32_DATA16,
> BUILT_IN_CRC32_DATA32,
> BUILT_IN_CRC64_DATA8, BUILT_IN_CRC64_DATA16,
> BUILT_IN_CRC64_DATA32,
> BUILT_IN_CRC64_DATA64,
> BUILT_IN_REV_CRC8_DATA8,
> BUILT_IN_REV_CRC16_DATA8, BUILT_IN_REV_CRC16_DATA16,
> BUILT_IN_REV_CRC32_DATA8, BUILT_IN_REV_CRC32_DATA16,
> BUILT_IN_REV_CRC32_DATA32,
> BUILT_IN_REV_CRC64_DATA8, BUILT_IN_REV_CRC64_DATA16,
> BUILT_IN_REV_CRC64_DATA32,
> BUILT_IN_REV_CRC64_DATA64.
> * builtins.def (BUILT_IN_CRC8_DATA8): New builtin.
> (BUILT_IN_CRC16_DATA8): Likewise.
> (BUILT_IN_CRC16_DATA16): Likewise.
> (BUILT_IN_CRC32_DATA8): Likewise.
> (BUILT_IN_CRC32_DATA16): Likewise.
> (BUILT_IN_CRC32_DATA32): Likewise.
> (BUILT_IN_CRC64_DATA8): Likewise.
> (BUILT_IN_CRC64_DATA16): Likewise.
> (BUILT_IN_CRC64_DATA32): Likewise.
> (BUILT_IN_CRC64_DATA64): Likewise.
> (BUILT_IN_REV_CRC8_DATA8): New builtin.
> (BUILT_IN_REV_CRC16_DATA8): Likewise.
> (BUILT_IN_REV_CRC16_DATA16): Likewise.
> (BUILT_IN_REV_CRC32_DATA8): Likewise.
> (BUILT_IN_REV_CRC32_DATA16): Likewise.
> (BUILT_IN_REV_CRC32_DATA32): Likewise.
> (BUILT_IN_REV_CRC64_DATA8): Likewise.
> (BUILT_IN_REV_CRC64_DATA16): Likewise.
> (BUILT_IN_REV_CRC64_DATA32): Likewise.
> (BUILT_IN_REV_CRC64_DATA64): Likewise.
> * builtins.h (expand_builtin_crc_table_based): New
> function declaration.
> * doc/extend.texti (__builtin_rev_crc8_data8,
> __builtin_rev_crc16_data16, __builtin_rev_crc16_data8,
> __builtin_rev_crc32_data32, __builtin_rev_crc32_data8,
> __builtin_rev_crc32_data16, __builtin_rev_crc64_data64,
> __builtin_rev_crc64_data8, __builtin_rev_crc64_data16,
> __builtin_rev_crc64_data32, __builtin_crc8_data8,
> __builtin_crc16_data16, __builtin_crc16_data8,
> __builtin_crc32_data32, __builtin_crc32_data8,
> __builtin_crc32_data16, __builtin_crc64_data64,
> __builtin_crc64_data8, __builtin_crc64_data16,
> __builtin_crc64_data32): Document.
>
> gcc/testsuite/
>
> * gcc.dg/crc-builtin-rev-target32.c
> * gcc.dg/crc-builtin-rev-target64.c
> * gcc.dg/crc-builtin-target32.c
> * gcc.dg/crc-builtin-target64.c
>
> Signed-off-by: Mariam Arutunian <mariamarutunian@gmail.com
> <mailto:mariamarutunian@gmail.com>>
This is fine for the trunk.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-25 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-26 18:05 [RFC/RFA][PATCH v2 02/12] Add built-ins and tests for bit-forward and bit-reversed CRCs Mariam Arutunian
2024-08-25 17:45 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).