[Test] Fix for PRPR53981

[Test] Fix for PRPR53981

[Anna Tikhonova]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

Hi all,

I've fixed test which was failing on Android NDK

testsuite/ChangeLog:
2012-07-20  Anna Tikhonova  <anna.m.tikhonova@gmail.com>

        * gcc.dg/20020201-1.c: Include <stdlib.h>.


Patch attached.

Ok for trunk & 4.7?

[-- Attachment #2: 20020201-1.p --]
[-- Type: application/octet-stream, Size: 358 bytes --]

diff --git gcc/testsuite/gcc.dg/20020201-1.c gcc/testsuite/gcc.dg/20020201-1.c
index 6002c59..05aab6c 100644
--- gcc/testsuite/gcc.dg/20020201-1.c
+++ gcc/testsuite/gcc.dg/20020201-1.c
@@ -7,6 +7,8 @@
 /* { dg-options "-fprofile-arcs" } */
 /* { dg-do run { target native } } */
 
+#include <stdlib.h>
+
 extern void abort (void);
 extern void exit (int);
 

Re: [Test] Fix for PRPR53981

[Janis Johnson]

On 07/20/2012 05:23 AM, Anna Tikhonova wrote:
> Hi all,
> 
> I've fixed test which was failing on Android NDK
> 
> testsuite/ChangeLog:
> 2012-07-20  Anna Tikhonova  <anna.m.tikhonova@gmail.com>
> 
>         * gcc.dg/20020201-1.c: Include <stdlib.h>.
> 
> 
> Patch attached.
> 
> Ok for trunk & 4.7?

OK if you remove the declarations for abort, exit, rand, and srand;
they're no longer needed.  Presumably an alternate fix would be to
add "extern" before the declarations of rand and srand.

Janis

Re: [Test] Fix for PRPR53981

[Anna Tikhonova]

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

Thanks!

I've removed declarations. New patch attached.

testsuite/ChangeLog:
2012-07-20  Anna Tikhonova  <anna.m.tikhonova@gmail.com>

         * gcc.dg/20020201-1.c: Remove declarations for exit, abort,
rand, srand. Include <stdlib.h>.


2012/7/24 Janis Johnson <janis_johnson@mentor.com>:
> On 07/20/2012 05:23 AM, Anna Tikhonova wrote:
>> Hi all,
>>
>> I've fixed test which was failing on Android NDK
>>
>> testsuite/ChangeLog:
>> 2012-07-20  Anna Tikhonova  <anna.m.tikhonova@gmail.com>
>>
>>         * gcc.dg/20020201-1.c: Include <stdlib.h>.
>>
>>
>> Patch attached.
>>
>> Ok for trunk & 4.7?
>
> OK if you remove the declarations for abort, exit, rand, and srand;
> they're no longer needed.  Presumably an alternate fix would be to
> add "extern" before the declarations of rand and srand.
>
> Janis

[-- Attachment #2: 20020201-1.p --]
[-- Type: application/octet-stream, Size: 434 bytes --]

diff --git a/gcc/testsuite/gcc.dg/20020201-1.c b/gcc/testsuite/gcc.dg/20020201-1.c
index 6002c59..1cb2a87 100644
--- a/gcc/testsuite/gcc.dg/20020201-1.c
+++ b/gcc/testsuite/gcc.dg/20020201-1.c
@@ -7,11 +7,7 @@
 /* { dg-options "-fprofile-arcs" } */
 /* { dg-do run { target native } } */
 
-extern void abort (void);
-extern void exit (int);
-
-int rand (void);
-void srand (unsigned int seed);
+#include <stdlib.h>
 
 int globvar;
 

Re: [Test] Fix for PRPR53981

[Kirill Yukhin]

>>
>> OK if you remove the declarations for abort, exit, rand, and srand;
>> they're no longer needed.  Presumably an alternate fix would be to
>> add "extern" before the declarations of rand and srand.
>>
>> Janis

Comitted to trunk and 4.7 branch

http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00811.html
http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00810.html

Thanks, K

Re: [Test] Fix for PRPR53981

[Anna Tikhonova]

Kirill has already checked it in for me, thanks!
Btw, I have FSF copyright assignment.

Is it possible to commit this patch to 4.6 branch? Since current ndk
is based on 4.6

2012/7/25 Janis Johnson <janis_johnson@mentor.com>:
> On 07/25/2012 03:58 AM, Anna Tikhonova wrote:
>> Thanks!
>>
>> I've removed declarations. New patch attached.
>
> You're not listed as "write after approval" in the MAINTAINERS
> file; would you like me to check this in for you?
>
> I didn't check to see if you have an FSF copyright assignment
> because this is a very small patch.
>
> Janis

Re: [Test] Fix for PRPR53981

[Anna Tikhonova]

Ping

2012/7/27 Anna Tikhonova <anna.m.tikhonova@gmail.com>:
> Kirill has already checked it in for me, thanks!
> Btw, I have FSF copyright assignment.
>
> Is it possible to commit this patch to 4.6 branch? Since current ndk
> is based on 4.6
>
> 2012/7/25 Janis Johnson <janis_johnson@mentor.com>:
>> On 07/25/2012 03:58 AM, Anna Tikhonova wrote:
>>> Thanks!
>>>
>>> I've removed declarations. New patch attached.
>>
>> You're not listed as "write after approval" in the MAINTAINERS
>> file; would you like me to check this in for you?
>>
>> I didn't check to see if you have an FSF copyright assignment
>> because this is a very small patch.
>>
>> Janis

Re: [Test] Fix for PRPR53981

[Janis Johnson]

Yes, you can put it on the 4.6 branch.

Janis

On 08/03/2012 03:09 AM, Anna Tikhonova wrote:
> Ping
> 
> 2012/7/27 Anna Tikhonova <anna.m.tikhonova@gmail.com>:
>> Kirill has already checked it in for me, thanks!
>> Btw, I have FSF copyright assignment.
>>
>> Is it possible to commit this patch to 4.6 branch? Since current ndk
>> is based on 4.6
>>
>> 2012/7/25 Janis Johnson <janis_johnson@mentor.com>:
>>> On 07/25/2012 03:58 AM, Anna Tikhonova wrote:
>>>> Thanks!
>>>>
>>>> I've removed declarations. New patch attached.
>>>
>>> You're not listed as "write after approval" in the MAINTAINERS
>>> file; would you like me to check this in for you?
>>>
>>> I didn't check to see if you have an FSF copyright assignment
>>> because this is a very small patch.
>>>
>>> Janis

Re: [Test] Fix for PRPR53981

[Kirill Yukhin]

> Yes, you can put it on the 4.6 branch.

Hi,
Thanks! Checked into 4.6 branch.

http://gcc.gnu.org/ml/gcc-cvs/2012-08/msg00130.html

Thanks, K

Re: [Test] Fix for PRPR53981

[Anna Tikhonova]

Anyone? Ping.

2012/7/20 Anna Tikhonova <anna.m.tikhonova@gmail.com>
>
> Hi all,
>
> I've fixed test which was failing on Android NDK
>
> testsuite/ChangeLog:
> 2012-07-20  Anna Tikhonova  <anna.m.tikhonova@gmail.com>
>
>         * gcc.dg/20020201-1.c: Include <stdlib.h>.
>
> Patch attached.
>
> Ok for trunk & 4.7?
>