From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75314 invoked by alias); 27 Feb 2018 08:14:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 75185 invoked by uid 89); 27 Feb 2018 08:14:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=micheal, Micheal, H*c:alternative, kindly X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Feb 2018 08:14:01 +0000 Received: by mail-wm0-f41.google.com with SMTP id z9so21885646wmb.3 for ; Tue, 27 Feb 2018 00:14:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=56/v647yBV3jIfAxYFNDBkhZXZONRwDxTPe0jsRIt2I=; b=eqs279ECxXUOan+qheteVZhnzRuFjKrqHOjI1D3HyPb+cpIjbwGTcXomTmZtVExn2j 9r7mFB835umkAOIyDDyEIUi4gEptWAPYsbmiPR4VpCgBKiC+RXXHSNPtC6q7YRdqSdpY ppFZTap8F/6QeDsZWgNledmzdDpw+/fEtQYsFJsNlOHKMV9tkY3jsrrTm+ikqMtjrWbE 2VR7YABLqlbZus5EXGghyr3KVwAsb/DIbQi58eSuGhK3JiiR6BCYjmZoyxu843E7sZNJ ge3wNPlA3BGy7WJlqZeup7XBnR9XnbRcC4iu5U/i8F/Ey5rrHtbqqRWU7Jz/ZdJFlATO MHZg== X-Gm-Message-State: APf1xPC5nBf7tgUkjii9IrWaVeLCRMP06/PHMeOJaBHGsk2tDXZroenc nX3IU66UwrgaR9TQUvyCeDeeDA4rOd34z4kh+0wXrMt3 X-Google-Smtp-Source: AG47ELshSez/xHv8d8uInXqp9ymJXzO9RHibGTj6Xv+sxN88UrXBsNsO3tPPs5uH4eHtiEbStiTD2xE78jaOA1NnBnE= X-Received: by 10.28.232.16 with SMTP id f16mr11422800wmh.92.1519719239724; Tue, 27 Feb 2018 00:13:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.178.66 with HTTP; Tue, 27 Feb 2018 00:13:59 -0800 (PST) In-Reply-To: <3ea62194-f081-0d2e-13f4-5884f1615e37@eagerm.com> References: <3ea62194-f081-0d2e-13f4-5884f1615e37@eagerm.com> From: Andrew Sadek Date: Tue, 27 Feb 2018 08:14:00 -0000 Message-ID: Subject: Re: [PATCH] [Microblaze]: PIC Data Text Relative To: Michael Eager Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-02/txt/msg01481.txt.bz2 Thanks Micheal for your response. I shall re-submit patches separately after re-running the whole GCC Test suite and re-checking code conventions. For sending to gdb-patches, it was a conflict from my side as actually I thought it is also for binutils. On Tue, Feb 27, 2018 at 2:07 AM, Michael Eager wrote: > On 02/25/2018 11:44 PM, Andrew Guirguis wrote: > >> Dears, >> >> Kindly find attached the patch bundle for Microblaze >> '-mpic-data-text-relative' feature. >> >> Description of the feature in the following link: >> https://github.com/andrewsadek/microblaze-pic-data-text-rel/ >> blob/pic_data_text_rel/README.md > k/microblaze-pic-data-text-rel/blob/pic_data_text_rel/README.md> >> >> Bundle includes: >> 1) Change logs for GCC, binutils >> 2) GCC Test results and comparison with the original. >> 3) New Test case (picdtr.c) >> 4) The Patches (against current heads) >> > > Hi Andrew -- > > Thanks for the submission. I have the following recommendations: > > Submit each patch to the appropriate project mailing list. Only submit > the patch for the specific project, without patches for other projects. > > Include a description of the changes with each patch as well as the > changelog. Include the patch in your email or as an attachment. > > It isn't clear why you sent your submission to the gdb-patches mailing > list, since there don't appear to be any GDB changes. Conversely, it is > not clear why you did not include the binutils mailing list, since you > include a patch to that project. > > Be sure to follow GNU coding conventions, Check brace placement, > indent, maximum line length, if statements, etc. I noticed a number > of places where these conventions are not followed in your patches. > > GCC regression tests should include all tests (e.g., gcc.dg), not just the > limited number of MicroBlaze-specific tests. > > -- > Michael Eager eager@eagerm.com > 1960 Park Blvd., Palo Alto, CA 94306 > -- Andrew