* [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section
@ 2013-12-02 21:54 Sterling Augustine
2013-12-02 22:00 ` Cary Coutant
0 siblings, 1 reply; 3+ messages in thread
From: Sterling Augustine @ 2013-12-02 21:54 UTC (permalink / raw)
To: gcc-patches; +Cc: Cary Coutant
[-- Attachment #1: Type: text/plain, Size: 452 bytes --]
The enclosed patch fixes a mismerge from google/gcc-4_7 to main. When
outputting a pubtype whose type has no skeleton section, it's DIE
offset should be from the comp_unit_die, instead of zero. Zero is
actually a place-holder for the end of the pubtypes.
Sterling
gcc/ChangeLog
2013-12-02 Sterling Augustine <saugustine@google.com>
* dwarf2out.c (output_pubnames): Use comp_unit_die ()->die_offset
when there
isn't a skeleton die.
[-- Attachment #2: pubtypes-bug.tot-patch --]
[-- Type: application/octet-stream, Size: 899 bytes --]
Index: contrib/mklog
===================================================================
--- contrib/mklog (revision 205405)
+++ contrib/mklog (working copy)
@@ -28,7 +28,7 @@
# Change these settings to reflect your profile.
$username = $ENV{'USER'};
-$name = `finger $username | grep -o 'Name: .*'`;
+$name = 'sterling'; # `finger $username | grep -o 'Name: .*'`;
@n = split(/: /, $name);
$name = @n[1]; chop($name);
$addr = $username . "\@my.domain.org";
Index: gcc/dwarf2out.c
===================================================================
--- gcc/dwarf2out.c (revision 205405)
+++ gcc/dwarf2out.c (working copy)
@@ -9293,7 +9293,7 @@
if (type_node != NULL)
die_offset = (type_node->skeleton_die != NULL
? type_node->skeleton_die->die_offset
- : 0);
+ : comp_unit_die ()->die_offset);
}
output_pubname (die_offset, pub);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section
2013-12-02 21:54 [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section Sterling Augustine
@ 2013-12-02 22:00 ` Cary Coutant
2013-12-02 22:11 ` Sterling Augustine
0 siblings, 1 reply; 3+ messages in thread
From: Cary Coutant @ 2013-12-02 22:00 UTC (permalink / raw)
To: Sterling Augustine; +Cc: gcc-patches
> gcc/ChangeLog
>
> 2013-12-02 Sterling Augustine <saugustine@google.com>
>
> * dwarf2out.c (output_pubnames): Use comp_unit_die ()->die_offset
> when there
> isn't a skeleton die.
This is OK, but your patch also has a local change to contrib/mklog.
Please be careful not to commit that.
Thanks!
-cary
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section
2013-12-02 22:00 ` Cary Coutant
@ 2013-12-02 22:11 ` Sterling Augustine
0 siblings, 0 replies; 3+ messages in thread
From: Sterling Augustine @ 2013-12-02 22:11 UTC (permalink / raw)
To: Cary Coutant; +Cc: gcc-patches
On Mon, Dec 2, 2013 at 1:59 PM, Cary Coutant <ccoutant@google.com> wrote:
> This is OK, but your patch also has a local change to contrib/mklog.
> Please be careful not to commit that.
Committed without the contrib/mklog portion.
Also committing on google/gcc-4_8 and google/main.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-02 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-02 21:54 [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section Sterling Augustine
2013-12-02 22:00 ` Cary Coutant
2013-12-02 22:11 ` Sterling Augustine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).