From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20570 invoked by alias); 17 Aug 2012 22:19:35 -0000 Received: (qmail 20555 invoked by uid 22791); 17 Aug 2012 22:19:33 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-gh0-f175.google.com (HELO mail-gh0-f175.google.com) (209.85.160.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Aug 2012 22:19:19 +0000 Received: by ghbz2 with SMTP id z2so4671990ghb.20 for ; Fri, 17 Aug 2012 15:19:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=VjpyeDqpquZfiXG1nKPAXZ4j7J30PtZDHUZVIlyJYAU=; b=Q0FPse+E49pIeKzmjLs9v5ITvjip3nPClkDongUHDsANNLJn8NhYfHEBrv37srK5QS EqQrWcIB9/mXYZujs8pBCKTNMgMuezOzNcB+vfSt69QXpPTtuLElKIyXJOv6/Q0v6+7q 7WRMCaEYUhRN8fG6wpz5ZwHwZuxjx1WSzoAuAWsPtjabIwxZqNXI2nC9WgdOeaSRlSY1 XDtY550YbfaXCC2wiIqCOf6bueIKS3wr9ihOMhmVJVh+J1jgmij0jYdBdyFt2ox3CaHR twJsidsES3eZutlV3jKlT1JE7iIdgAsnZOb324jGcq3LIcS4ru6aBm/7fYAFbMlSfXeM a0KA== Received: by 10.50.100.137 with SMTP id ey9mr3315332igb.61.1345241958924; Fri, 17 Aug 2012 15:19:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.100.137 with SMTP id ey9mr3315323igb.61.1345241958708; Fri, 17 Aug 2012 15:19:18 -0700 (PDT) Received: by 10.231.202.140 with HTTP; Fri, 17 Aug 2012 15:19:18 -0700 (PDT) In-Reply-To: <20120817220951.622DEE0426@ccoutant.mtv.corp.google.com> References: <20120817220951.622DEE0426@ccoutant.mtv.corp.google.com> Date: Fri, 17 Aug 2012 22:19:00 -0000 Message-ID: Subject: Re: [google/gcc-4_7] Fix ICE in output_pubnames where union contains a ctor From: Sterling Augustine To: Cary Coutant Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQkiuzfFyJomfSbu5VjJ/NuQZ+gSEQXTgGZYoC9LMPfIvNR6sdxhaOTZFlArAGRYcMTI5IIK/QUl/DCEuYtxONdOhLUL1yEmplMO75SbCW9KpYgxvWlmzZ7oghplkYwziPxkVQjj+p689wczBRaojSEx2yMmt4cL09MFH5ZGP5rhzC7i10lA8OuS+BmvAtC9K/MREGo2 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg01220.txt.bz2 On Fri, Aug 17, 2012 at 3:09 PM, Cary Coutant wrote: > This patch is for the google/gcc-4_7 branch. I'll submit it for trunk > after the Fission patches have gone in. > > When adding names to the pubnames table (-gsplit-dwarf or -gpubnames), > a method within a union may not get handled properly, sometimes resulting > in an internal compiler error in output_pubnames(). > > This patch fixes the problem by using the existing predicate, > class_scope_p, instead of is_class_die, which failed to test for > a union type. OK for Google 4.7 Sterling